Ads Manager 2 by Siropu [Paid] 2.4.22

[tajhay]

Siropu, i tried to update to the latest XF2.1 beta and upgrade crashed and the site just gives this error message:

Fatal error: Uncaught Error: Call to a member function addClassMap() on null in /home/tajhay/test.nzwarriors.com/src/addons/Siropu/AdsManager/Listener.php:11 Stack trace: #0 [internal function]: Siropu\AdsManager\Listener::appSetup(Object(XF\App)) #1 /home/tajhay/test.nzwarriors.com/src/XF/Extension.php(67): call_user_func_array(Array, Array) #2 /home/tajhay/test.nzwarriors.com/src/XF/App.php(2647): XF\Extension->fire('app_setup', Array, NULL) #3 /home/tajhay/test.nzwarriors.com/src/XF/App.php(1744): XF\App->fire('app_setup', Array) #4 /home/tajhay/test.nzwarriors.com/src/XF.php(365): XF\App->setup(Array) #5 /home/tajhay/test.nzwarriors.com/src/XF.php(354): XF::setupApp('\\XF\\App') #6 /home/tajhay/test.nzwarriors.com/src/XF.php(210): XF::app() #7 [internal function]: XF::handleFatalError() #8 {main} thrown in /home/tajhay/test.nzwarriors.com/src/addons/Siropu/AdsManager/Listener.php on line 11

Disabling the listeners in the config file gives me this error :

 

[Asser]

Siropu, i tried to update to the latest XF2.1 beta and upgrade crashed and the site just gives this error message:

Fatal error: Uncaught Error: Call to a member function addClassMap() on null in /home/tajhay/test.nzwarriors.com/src/addons/Siropu/AdsManager/Listener.php:11 Stack trace: #0 [internal function]: Siropu\AdsManager\Listener::appSetup(Object(XF\App)) #1 /home/tajhay/test.nzwarriors.com/src/XF/Extension.php(67): call_user_func_array(Array, Array) #2 /home/tajhay/test.nzwarriors.com/src/XF/App.php(2647): XF\Extension->fire('app_setup', Array, NULL) #3 /home/tajhay/test.nzwarriors.com/src/XF/App.php(1744): XF\App->fire('app_setup', Array) #4 /home/tajhay/test.nzwarriors.com/src/XF.php(365): XF\App->setup(Array) #5 /home/tajhay/test.nzwarriors.com/src/XF.php(354): XF::setupApp('\\XF\\App') #6 /home/tajhay/test.nzwarriors.com/src/XF.php(210): XF::app() #7 [internal function]: XF::handleFatalError() #8 {main} thrown in /home/tajhay/test.nzwarriors.com/src/addons/Siropu/AdsManager/Listener.php on line 11

Disabling the listeners in the config file gives me this error :
View attachment 190802

To disable listeners

I assume you can't do that from admin panel because something is bugged?

Then you can disable specific add-on from command line:

php cmd.php xf-addon:disable Addon/Name

to disable add-on with namespace Addon/Name

or

php cmd.php xf-addon:disable

to disable all add-ons

Type

php cmd.php list

for list of all available options

 

[tajhay]

To disable listeners

none of those work and the error keeps getting shown in CLI.

@Siropu can you please assist?

root@server [/home/tajhay/test.nzwarriors.com]# php cmd.php xf-addon:disable





Fatal error: Uncaught Error: Call to a member function addClassMap() on null in /home/tajhay/test.nzwarriors.com/src/addons/Siropu/AdsManager/Listener.php:11


Stack trace:


#0 [internal function]: Siropu\AdsManager\Listener::appSetup(Object(XF\App))


#1 /home/tajhay/test.nzwarriors.com/src/XF/Extension.php(67): call_user_func_array(Array, Array)


#2 /home/tajhay/test.nzwarriors.com/src/XF/App.php(2647): XF\Extension->fire('app_setup', Array, NULL)


#3 /home/tajhay/test.nzwarriors.com/src/XF/App.php(1744): XF\App->fire('app_setup', Array)


#4 /home/tajhay/test.nzwarriors.com/src/XF.php(365): XF\App->setup(Array)


#5 /home/tajhay/test.nzwarriors.com/src/XF.php(354): XF::setupApp('\\XF\\App')


#6 /home/tajhay/test.nzwarriors.com/src/XF.php(210): XF::app()


#7 [internal function]: XF::handleFatalError()


#8 {main}


thrown in /home/tajhay/test.nzwarriors.com/src/addons/Siropu/AdsManager/Listener.php on line 11


root@server [/home/tajhay/test.nzwarriors.com]#

 

[Siropu]

can you please assist?

Go to src/addons/Siropu/AdsManager/Listener.php and delete the following code from the appSetup method.

\XF::$autoLoader->addClassMap([
               'Mobile_Detect' => \XF::getAddOnDirectory() . '/Siropu/AdsManager/Vendor/MobileDetect/Mobile_Detect.php'
          ]);

See if you get any new errors after that.

 

[Nirjonadda]

@Siropu Lazy Loading are not working correctly with Code type ads. The multiple ads image still showing when page loading.

 

[Nirjonadda]

Also ads are not mobile response. You can check this out in my site.

 

[Siropu]

Are you referring to the images in the carousel? Will be fixed.

 

[Nirjonadda]

Are you referring to the images in the carousel? Will be fixed.

Yes do you found issue mobile response are not work? The image out of the style.

 

[Siropu]

Yes, the reason for that is because of the custom inline css width.

 

[Nirjonadda]

Yes, the reason for that is because of the custom inline css width.

Then if we remove Unit style: width: 600px; height: 222px; then image are not showing correctly.

See here: https://giant.gfycat.com/ForsakenRewardingCusimanse.webm

 

[Siropu]

Are you using any alignment in the settings? There seems to be an issue with alignment.

 

[Nirjonadda]

Are you using any alignment in the settings? There seems to be an issue with alignment.

See here.

 

[Siropu]

Set alignment to "Auto" and remove Unit style and see if it works that way.

 

[Nirjonadda]

Set alignment to "Auto" and remove Unit style and see if it works that way.

Done but see how its work now, showing all image from reloading and showing left side.

https://giant.gfycat.com/HideousInfatuatedLeveret.webm

 

[Siropu]

That happens until the scripts load and the carousel initiates. It is normal behavior.

 

[Nirjonadda]

That happens until the scripts load and the carousel initiates. It is normal behavior.

So Lazy Loading are not working correctly? Also why not work alignment in center? This should work alignment in center.

Not working navigation arrows and navigation dots from PC but work from mobile.

 

[Siropu]

So Lazy Loading are not working correctly?

Have you enabled it in admin options (Ads Manager [General]?

Also why not work alignment in center?

Carousel aligns automatically in the center. There seems to be a bug when you force alignment.

Not working navigation arrows and navigation dots from PC but work from mobile.

They work but for some reason they become barely visible.

 

[Nirjonadda]

Have you enabled it in admin options (Ads Manager [General]?

Yes, Enabled Lazy Loading option.

 

[Siropu]

It is working fine for me so it could be something that I have fixed in the upcoming release.

 

[Nirjonadda]

It is working fine for me so it could be something that I have fixed in the upcoming release.

Have a plan for release?