Add-on Install & Upgrade 1.4.3

[Chris D]

Chris D updated Add-on Install & Upgrade with a new update entry:

Fix for invalid Resource Manager URL error

This version includes a fix which no longer forces you to enter a non-HTTPS Resource Manager URL.

Read the rest of this update entry...

 

[Tealk]

oh sorry

 

[isaacl]

Is there any reason why this won't work with Resource Maanager links on other Xenforo sites (like in cases where the add-ons aren't hosted directly on the Xenforo forums)?
I tried one, and it gave me the "Only proper Resource Manager URLs are valid" error...
Thanks!

 

[oman]

Is there any reason why this won't work with Resource Maanager links on other Xenforo sites (like in cases where the add-ons aren't hosted directly on the Xenforo forums)?
I tried one, and it gave me the "Only proper Resource Manager URLs are valid" error...
Thanks!

It's because it's designed to allow you to upgrade add ons directly and only from the XenForo site. Specifically with the ability to provide your XenForo community log in details.

 

[isaacl]

Shouldn't that work with any Xenforo site with Resource Manager, if the login details are the same?

 

[Chris D]

It was designed to only work with XenForo.com.

The feature quite possibly pre-dates the RM being released publicly, I can't remember.

 

[isaacl]

Any chance of updating it to work with other XF sites as well?
This would help with addons being hosted on other sites, especially paid add-ons...
Thanks a lot!

 

[ogirginc]

Hi Chris,
While I was trying to update by using Option 1 for XenReviews, I am keep getting this error:


Later I was suggested to "delete everything under install/addons" but it didn't help neither. Even though I have deleted everything under intalls/addons, when I click to update a new folder appears under the same spot. Any idea what might be causing the error?

Thanks!

 

[Liam W]

Something that annoys me with this addon is that it appears to completely consume any exception thrown during install and redirect back to the addon list...

 

[GliX]

There is no file styles/AddOnInstaller/check.png in latest archive posted here.

 

[Mouth]

Suggestion: Update Checker to ignore or filter disabled add-ons.

 

[Jeff Berry]

Hi Chris,

In regards to @puropedia's report, and several other users that have tried to use your installer to install my add-on, I finally dove into your code to find the issue. Wanted to post this here so you can get it included in the next release.

OPEN library/AddOnInstaller/Model/AddOn.php

FIND

while ($contents = readdir($directoryHandle))

REPLACE WITH

while (($contents = readdir($directoryHandle)) !== false)

Cheers,

Jeff

 

[Tealk]

Is it possible that the uploaded files get there own folder so they don't spaam the root folder?

 

[Chris D]

Nothing spams the root folder...

 

[Tealk]

Nothing spams the root folder...

if i update or install a plugin the .rar and the install.xml are all time in the root folder

 

[Chris D]

It doesn't do that... it extracts files to the install/addons folder.

This is the part of the code that handles that:



It always uses 'install/addons' as its base directory for extraction.

 

[Tealk]

ok, yes i see but why i have there some .rar and .xml? now i'm confused
in install/addon i have only 3 zip :/

 

[Chris D]

Technically, you shouldn't have anything in install/addon because it is supposed to clean up the files after install (but sometimes that might fail).

Anything in install/addon can be removed.

It's possible that one of your add-ons includes a rar and an XML file in the root of the ZIP package. It's preferable that add-on developers put everything they intend to be uploaded into a folder called "upload". The logic my add-on goes through then finds that the easiest way of identifying what should be "uploaded" and what shouldn't.

In the event my add-on can't find an "upload" folder in the ZIP file, it will go through a process to "guess" the correct files to upload.

Alternatively, the add-on developer has decided to put a rar and an XML file in the upload folder in which case that will just get uploaded into root.

If you can identify which add-on it is I can explain in more detail why it's happening, but there's probably not a lot I can do about it.

 

[Tealk]

If you can identify which add-on it is I can explain in more detail why it's happening, but there's probably not a lot I can do about it.

This one: https://xenforo.com/community/resources/bd-social-share.2182/
And i know the problem with zipped files, i have write a shell script for minecraft which works similar like yours and there the same with the ZIP^^

 

[Chris D]

Unfortunately I don't have access to that add-on.

I assume there is a rar file and an XML somewhere in the zip package; is it located in a folder called "upload" as I suspected? Or is there just not a folder called "upload"?