Installing multiple addons at once ignores addon requirements, leading to unexpected install/upgrade failures

[Xon]

Affected version

2.2.15

If Addon A depends on Addon B, but users select addon A and addon B zip files (in that order); this will cause the install/upgrade to fail despite them providing all the required addons. If they manage to select addon B and addon A in the upload dialog then install/upgrade will works without errors.

This results in a deeply confusion experience where the order of selecting files in the file upload dialog matters.

 

[FTL]

Clearly, there should be some way to alert the user of such dependencies.

Also, XF should perhaps allow installation of A, but leave it disabled until B is installed too. It wouldn't be that hard to develop this function, either. XF provides the framework and the developer uses it to develop dependency-safe add-ons.

 

[Lee]

Clearly, there should be some way to alert the user of such dependencies.

Also, XF should perhaps allow installation of A, but leave it disabled until B is installed too. It wouldn't be that hard to develop this function, either. XF provides the framework and the developer uses it to develop dependency-safe add-ons.

What if the installation of addon A requires dependencies within addon B?

 

[FTL]

Not a problem, just put it into the XF installation protocol to show a warning and prevent the installation. On top of that, the add-on could optionally contain a link to download the dependent add-on.

 

[Xon]

It isn't that hard to sort add-on by their requirements and ensure they are installed in the right order.

The code needs to visit each addon's addon.json to verify requirements anyway, so this is just adding a sort step between extracting addon.json and checking requirements.