s9e Media Sites 2.16.7

Chromaniac · Oct 30, 2021

Yeah. Found this out myself quite recently.

Not a bug - Two issues related to unfurling URLs

First one is really weird. Here is what happens. I post a link in a post. I publish the post. Link is unfurled. I edit the post and edit just the link bit. Publish the post. Updated link appears as linked url and does not get unfurled. I am not sure why XenForo does not update the URL on...

xenforo.com

JoshyPHP · Oct 30, 2021

JoshyPHP updated s9e Media Sites with a new update entry:

Fixed unfurl'ing when creating a custom URL BBCode

Custom URL BBCodes with a media attribute should be unfurl'ed properly now, even if the URL has never been used before.

https://xenforo.com/community/threads/s9e-media-sites.139274/post-1544027

Xon · Oct 30, 2021

Chromaniac said:
This is interesting... Might finally let me stop adding the source link after the embed perhaps.

At least this way the original URL is preserved so rendering a url after the embed is easy while keeping it as just the single bb-code

Chromaniac · Oct 30, 2021

yeah. the only issue i see with this optional setting is that if you migrate to some other forum software in future, getting the embeds to work would require too much work. regular embed codes might work out of the box for some of the services.

Xon · Oct 30, 2021

@JoshyPHP I've had reports that the youtube embeds have started autoplaying on scrolling past them despite the disable autoplay option being set.

JoshyPHP · Oct 30, 2021

Xon said:
At least this way the original URL is preserved so rendering a url after the embed is easy while keeping it as just the single bb-code

I should mention that currently, even if you've enabled the XenForo option to add a link after regular embeds, that link won't be added added after the custom [URL] tag. This is not because of some technical reason, I just didn't want to end up with duplicate links everywhere. It could be changed back and/or be made an option but I'm not sure it's worth adding yet another option to the admin panel. If anyone's interested, the extra markup can be re-enabled (at posting time only) with this change:

Diff:

diff --git a/addon/Parser.php b/addon/Parser.php
index d9c6fcd..270dae0 100644
--- a/addon/Parser.php
+++ b/addon/Parser.php
@@ -311,7 +311,7 @@ class Parser
 
    public static function convertMediaTag(string $url, string $markup, ?Unfurl $unfurl): string
    {
-       if (preg_match('(^\\[MEDIA=(\\w++)\\]([^"\\[]++)\\[/MEDIA\\])i', $markup, $m))
+       if (preg_match('(^\\[MEDIA=(\\w++)\\]([^"\\[]++)\\[/MEDIA\\](.*))is', $markup, $m))
        {
            $attr = '';
            if (isset($unfurl))
@@ -320,7 +320,7 @@ class Parser
                $unfurl->logPendingUnfurl($url);
            }
 
-           $markup = '[URL' . $attr . ' media="' . $m[1] . ':' . $m[2] . '"]' . $url . '[/URL]';
+           $markup = '[URL' . $attr . ' media="' . $m[1] . ':' . $m[2] . '"]' . $url . '[/URL]' . $m[3];
        }
 
        return $markup;

Chromaniac said:
yeah. the only issue i see with this optional setting is that if you migrate to some other forum software in future, getting the embeds to work would require too much work. regular embed codes might work out of the box for some of the services.

Yeah, convertors would need to be aware of it, although I guess that applies to anything from this add-on. The [URL] tags can be converted back to [MEDIA] with a fairly simple regexp though, so hopefully it won't be an issue for those who want to move away from XenForo. [Edit: while we're on the subject, if someone wants to convert from or to XenForo and has questions related to this add-on, you can just send me a direct message and I'll give you a hand if possible.]

Xon said:
@JoshyPHP I've had reports that the youtube embeds have started autoplaying on scrolling past them despite the disable autoplay option being set.

That should be a coincidence because I can't imagine how one could cause the other but if you can send me a link to a page where that happens I will look into it.

arabia2 · Oct 30, 2021

welcome

Can this site be added to the plugin?

Community resources

Find activities that have been created by other teachers. Enter a search term to find public activities that are free to play.

wordwall.net

So that the videos appear without the need to include the code

JoshyPHP · Oct 30, 2021

arabia2 said:
Can this site be added to the plugin?

I don't think that would be a good fit for this add-on, sorry. I looked at this site's embed code and I think you'd need a separate add-on to make it work.

JoshyPHP · Oct 31, 2021

JoshyPHP updated s9e Media Sites with a new update entry:

Updated Vimeo, fixed an issue with case-sensitive host names

Added support for private Vimeo URLs.
Changed URL matching to match host names case-insensitively. The rest of the URL remains case-sensitive.

Read the rest of this update entry...

Xon · Nov 2, 2021

@JoshyPHP bug with the s9e_MediaSites_Markup option and unfurl which fails;

Code:

TypeError: s9e\MediaSites\Parser::convertMediaTag(): Argument #2 ($markup) must be of type string, null given, called in /var/www/html/src/addons/s9e/MediaSites/XF/BbCode/ProcessorAction/AutoLink.php on line 33 src/addons/s9e/MediaSites/Parser.php:318

#0 src/addons/s9e/MediaSites/XF/BbCode/ProcessorAction/AutoLink.php(33): s9e\MediaSites\Parser::convertMediaTag('http://forum.sp...', NULL, Object(SV\AdvancedBbCodesPack\XF\Repository\Unfurl))
#1 src/XF/BbCode/ProcessorAction/AutoLink.php(116): s9e\MediaSites\XF\BbCode\ProcessorAction\AutoLink->autoLinkUrl('http://forum.sp...')
#2 src/XF/BbCode/Processor.php(273): XF\BbCode\ProcessorAction\AutoLink->filterUrlTag(Array, Array, Object(XF\BbCode\Processor))
#3 src/XF/BbCode/Processor.php(307): XF\BbCode\Processor->XF\BbCode\{closure}(Array)
#4 src/XF/BbCode/Processor.php(264): XF\BbCode\Processor->filterTag(Array, Array)
#5 src/XF/BbCode/Traverser.php(63): XF\BbCode\Processor->renderTag(Array, Array)
#6 src/XF/BbCode/Processor.php(336): XF\BbCode\Traverser->renderSubTree(Array, Array)
#7 src/XF/BbCode/Processor.php(315): XF\BbCode\Processor->renderValidTag(Array, Array)
#8 src/XF/BbCode/Processor.php(264): XF\BbCode\Processor->filterTag(Array, Array)
#9 src/XF/BbCode/Traverser.php(63): XF\BbCode\Processor->renderTag(Array, Array)
...

PHP:

        public function autoLinkUrl($url)
        {
                $markup = parent::autoLinkUrl($url);
                if ($this->app->options()->s9e_MediaSites_Markup === 'url')
                {
                        $unfurl = (!empty($this->urlToRichPreview)) ? $this->app->repository('XF:Unfurl') : null;
                        $markup = Parser::convertMediaTag($url, $markup, $unfurl);
                }

                return $markup;
        }

autoLinkUrl can return null but Parser::convertMediaTag requires both $url and $markup to be non-null

I think a simple $markup !== null && $url !== null && added to the if statement would be enough.

JoshyPHP · Nov 2, 2021

JoshyPHP updated s9e Media Sites with a new update entry:

Fixed a PHP error on posting

This is a recommended upgrade if you're running 2.7.0 or later.

Read the rest of this update entry...

JoshyPHP · Nov 2, 2021

Dang, serves me right for not reading the body of a function. Thanks for the heads-up. I used isset() rather than a comparison because there was one in the vicinity but it should be equivalent.

Out of an abundance of caution I'd like to reproduce locally and make sure it's fixed for real, do you have the URL that triggered that error?

Xon · Nov 2, 2021

JoshyPHP said:
Out of an abundance of caution I'd like to reproduce locally and make sure it's fixed for real, do you have the URL that triggered that error?

The error was from editing an old long post with a large number of links, finding which URL failed with be a pain.

JoshyPHP · Nov 2, 2021

Ok, don't bother then. I'll look into it later.

RichDevman · Nov 3, 2021

Just an fyi: https://xenforo.com/community/threads/native-mobile-apps-ios-and-android-paid.168769/post-1544777

TCG2007 · Nov 4, 2021

Did IG update their video player? This is how video embeds look right now (actual video is the top portion).

Vid link - https://www.instagram.com/tv/CV3IZ4QFI3H/?utm_source=ig_web_copy_link

JoshyPHP · Nov 4, 2021

As far as I can tell, it's specific to this video because Instagram's API thinks the post should be 1024px tall for some reason. I tried other URLs and they were dimensioned correctly.

Code:

https://instagram.com/p/gbGaIXBQbn/
https://www.instagram.com/tv/BkQjCfsBIzi/

TCG2007 · Nov 4, 2021

Thanks. I had a hunch it might be that.

arabia2 · Nov 6, 2021

JoshyPHP said:
I don't think that would be a good fit for this add-on, sorry. I looked at this site's embed code and I think you'd need a separate add-on to make it work.

Can you tell me what the auxiliary component is?

JoshyPHP · Nov 6, 2021

What I meant is that you will likely need to create your own add-on to create that media site.

s9e Media Sites 2.16.7

Well-known member

Well-known member

Well-known member

Well-known member

Well-known member

Well-known member

Member

Well-known member

Well-known member

Well-known member

Well-known member

Well-known member

Well-known member

Well-known member

Active member

Well-known member

Well-known member

Well-known member

Member

Well-known member

Similar threads

We value your privacy