s9e Media Sites

s9e Media Sites 2.18.6

No permission to download
I don't think it's worth delaying your upgrade. Only a handful of sites are potentially affected, and it requires some specific circumstances to be able to trigger the error. The error itself doesn't prevent the rest of the post to be displayed.

A cursory look at the sites that match at least one of the criteria returns the following list: bbcnews, cbsnews, democracynow, facebook, gist, internetarchive, msnbc, pinterest, soundcloud, ted.
Thanks, Soundcloud is widely used on our forum. Therefore my question. :) In case of an issue, I could simply downgrade to a former version of S9e Media, yes?
 
You'd need to uninstall the add-on then install the old version, but otherwise yes, you should be able to revert to an earlier version without too much trouble.

With that said, if you find a type of embeds that can trigger this error, post it here and I'll fix it manually. As far as I can tell, there shouldn't be any other issues with SoundCloud.
 
Hey, I had a user report this and then they've pestered me about it since. I thought this might be related to the feature related to video popping out so you can watch while scrolling but just thought I'd ask here before checking with XF:

twitter.webp

Any idea? Thanks.

Also, I reached out to Truth Social support (something I thought I'd never say) but would be surprised if they respond ha. Thanks for explaining all that though.
 
I thought this might be related to the feature related to video popping out [...]
No, it's just 𝕏's interface. Clicking anywhere in a tweet will open it in a new tab, except for most of the video player but not all, because parts of the video player will cause the tweet to open in a new tab as well. So if that user is on mobile and/or does not click on the right pixel, it will open in a new tab. Static images and galleries / multi-video tweets always open in a new tab as well, I believe.

Let me know if you hear from Truth Social.
 
@DarkGizmo I've just looked into it and I can confirm the issue originates from this add-on. XFMG's Lightbox changed between 2.2 and 2.3, and some CSS that was required to be compatible with XFMG 2.2 now causes XMFG 2.3 to misbehave.

I need to do more testing to ensure I don't accidentally break 2.2 trying to fix 2.3, but in the meantime if you want to use both add-ons at the same time, you can add the following CSS to your extra.less:
CSS:
html[data-xf="2.3"] .js-embedContent>.bbWrapper>[data-s9e-mediaembed]:not([style])
{
	width: 640px;
}
This is a crude, temporary fix that should be removed as soon as a better solution is released, but it should work well enough for now.
 
@DarkGizmo I've just looked into it and I can confirm the issue originates from this add-on. XFMG's Lightbox changed between 2.2 and 2.3, and some CSS that was required to be compatible with XFMG 2.2 now causes XMFG 2.3 to misbehave.

I need to do more testing to ensure I don't accidentally break 2.2 trying to fix 2.3, but in the meantime if you want to use both add-ons at the same time, you can add the following CSS to your extra.less:
CSS:
html[data-xf="2.3"] .js-embedContent>.bbWrapper>[data-s9e-mediaembed]:not([style])
{
    width: 640px;
}
This is a crude, temporary fix that should be removed as soon as a better solution is released, but it should work well enough for now.
Okay thanks! I'll just wait for the fix. :-) I don't think too many people were fussed about the bbcodes, it was more the media gallery they wanted to utilize. :)
 
@welington It already works on XF 2.2 / XFMG 2.2, and XF 2.3 / XFMG 2.3.

@Earl In theory, yes. I haven't tried it in recent times and I'm not able to run my test suite on PHP 8.0 anymore because it's too old, so I can't guarantee it. As far as I can tell, the distributed files are all syntactically valid for PHP 8.0 and should work.
 
First of all thank you for continuing to support this awesome addon!

I have 2.16.2 installed on my XF 2.2.16 board, and I cannot save the Options -> s9e/MediaSites options page without this error:

Oops! We ran into some problems.
Line 312: Template tags are not well formed. Tag if was found when expecting set. - Template modifications: public:PAGE_CONTAINER

I'm not sure when this error started occurring, as I just accessed that options page recently.
 

Attachments

  • Screenshot 2024-08-08 at 12.53.11 PM.webp
    Screenshot 2024-08-08 at 12.53.11 PM.webp
    67.7 KB · Views: 9
I cannot save the Options -> s9e/MediaSites options page without this error:

Do you have any other add-ons installed, and if so, can you edit their options? That's the first time I see that error and off the top of my head I can't imagine anything in this add-on that could trigger it. You can try disabling the add-on's PAGE_CONTAINER template modification, but I wouldn't expect to change anything.

admin_screenshot.webp

You may need to ask in the general support forum for ideas on what could trigger that type of errors. If so, feel free to tag me so I can subscribe to your thread and stay updated.
 
Do you have any other add-ons installed, and if so, can you edit their options? That's the first time I see that error and off the top of my head I can't imagine anything in this add-on that could trigger it. You can try disabling the add-on's PAGE_CONTAINER template modification, but I wouldn't expect to change anything.

View attachment 308311

You may need to ask in the general support forum for ideas on what could trigger that type of errors. If so, feel free to tag me so I can subscribe to your thread and stay updated.

Thanks for the tips. I do have several other addons installed (mostly by Xon), and can save the options for those. I just tried disabling the template modification but I cannot 🙁. It comes up with the same error! So then I tried disabling other template modifications from other addons, that affected the PAGE_CONTAINER. Same error, just different line numbers.

I'll ask in the general forums. :)
 
I'll ask in the general forums. :)
Tag me when you do, I'd like to follow up on this.

I expect the issue to be an interaction with another template modification of the PAGE_CONTAINER. One thing you may try to diagnose the source is to go to the Template Modifications admin page and look for anything that modifies PAGE_CONTAINER. From there, you should be able to click on the name on the left (not the toggle button) to access the form used to edit the modification. If your installation is not in development mode, you shouldn't able to actually edit its content (nor would I recommend you do without further guidance) but you should have access to the "Test" button at the bottom. It will show you what the modification does. I'd look for anything overly broad, or anything that modifies, adds, or deletes a xf:if of xf:set tag.

Below is what this add-on's modification should look like. It should only add one single line that contains a link to the add-on's page. That modification can be toggled via an option in the add-on's options page, which is probably why you see an error related to templating when updating the add-on's options.
 

Attachments

  • admin_modifications.webp
    admin_modifications.webp
    35.6 KB · Views: 5
All new IG emeds are just loading as links now for me.


I'm on 2.2.something. But seems to have started this morning.

Edit: If I grab the link from the web, they work as normal. I tried a different page on mobile and the same thing, just embeds as a link.

Here is a link that wont embed from my phone.

 
Last edited:
All new IG emeds are just loading as links now for me.


The embeds on that page work fine for me on Chromium with no adblockers, and on Firefox with Enhanced Tracking Protection in Standard mode, but fails on Firefox with Enhanced Tracking Protection in Strict mode because it blocks everything on instagram.com.

https://www.instagram.com/katicmedia/reel/C-e2JN2vaXX/?igsh=bXR2OHg0dmxxY3cx
That type of links is new to me. I'll add support for it in the next update.
 
Back
Top Bottom