Report Improvements by Xon 2.18.3

[sgr]

@sgr I really need the request body to track that down. Can you open a ticket on my site and include it?

Yes. Done. We used our account there which has a different username.

 

[Xon]

Xon updated Report Improvements by Xon with a new update entry:

2.2.1 - Bugfix update

• Fix for error "Report-message: Please enter a valid message." when using 'send to forum' feature

Read the rest of this update entry...

 

[NicolasZN]

Hey Xon,

Seems like there's a conflict between report improvements and Siropu's chat add-on throwing this error:

[LIST]
[*]                
[*]LogicException: Macro public:siropu_chat_guest_macros :: username() error: Cannot instantiate XF:User (SV\ReportImprovements\XF\Entity\User) without primary key values
[*]               
[*]src/XF/Mvc/Entity/Manager.php:723
[*]            
[/LIST]
           
[LIST]
[*]                
[*]Generated by: Nicolas King
[*]               
[*]Apr 13, 2019 at 7:59 AM
[*]            
[/LIST]
        
       Stack trace
       
           #0 src/addons/XFA/CustomUsernameIcons/XF/Template/Templater.php(28): XF\Mvc\Entity\Manager->instantiateEntity('XF:User', Array)
#1 [internal function]: XFA\CustomUsernameIcons\XF\Template\Templater->fnUsernameLink(Object(SV\UserActivity\XF\Template\Templater), false, Array, false, Array)
#2 src/XF/Template/Templater.php(922): call_user_func_array(Array, Array)
#3 internal_data/code_cache/templates/l1/s6/public/siropu_chat_guest_macros.php(18): XF\Template\Templater->fn('username_link', Array)
#4 src/XF/Template/Templater.php(701): XF\Template\Templater->{closure}(Object(SV\UserActivity\XF\Template\Templater), Array, Array)
#5 internal_data/code_cache/templates/l1/s6/public/siropu_chat_room_message_helper.php(53): XF\Template\Templater->callMacro('siropu_chat_gue...', 'username', Array, Array)
#6 src/XF/Template/Templater.php(701): XF\Template\Templater->{closure}(Object(SV\UserActivity\XF\Template\Templater), Array, Array)
#7 internal_data/code_cache/templates/l1/s6/public/siropu_chat_room_message_row.php(16): XF\Template\Templater->callMacro('siropu_chat_roo...', 'message_content', Array, Array)
#8 src/XF/Template/Templater.php(1301): XF\Template\Templater->{closure}(Object(SV\UserActivity\XF\Template\Templater), Array)
#9 src/XF/Template/Templater.php(1374): XF\Template\Templater->renderTemplate('siropu_chat_roo...', Array)
#10 internal_data/code_cache/templates/l1/s6/public/siropu_chat_message_list.php(15): XF\Template\Templater->includeTemplate('public:siropu_c...', Array)
#11 src/XF/Template/Templater.php(701): XF\Template\Templater->{closure}(Object(SV\UserActivity\XF\Template\Templater), Array, Array)
#12 internal_data/code_cache/templates/l1/s6/public/siropu_chat.php(534): XF\Template\Templater->callMacro('siropu_chat_mes...', 'room', Array, Array)
#13 src/XF/Template/Templater.php(1301): XF\Template\Templater->{closure}(Object(SV\UserActivity\XF\Template\Templater), Array)
#14 src/XF/Widget/WidgetRenderer.php(62): XF\Template\Templater->renderTemplate('siropu_chat', Array)
#15 src/XF/Widget/WidgetRenderer.php(67): XF\Widget\WidgetRenderer->render()
#16 src/XF/Template/Templater.php(1620): XF\Widget\WidgetRenderer->__toString()
#17 internal_data/code_cache/templates/l1/s6/public/forum_list.php(243): XF\Template\Templater->widgetPosition('siropu_chat_bel...', Array)
#18 src/XF/Template/Templater.php(1301): XF\Template\Templater->{closure}(Object(SV\UserActivity\XF\Template\Templater), Array)
#19 src/XF/Template/Template.php(24): XF\Template\Templater->renderTemplate('forum_list', Array)
#20 src/XF/Mvc/Renderer/Html.php(48): XF\Template\Template->render()
#21 src/XF/Mvc/Dispatcher.php(418): XF\Mvc\Renderer\Html->renderView('XF:Forum\\Listin...', 'public:forum_li...', Array)
#22 src/XF/Mvc/Dispatcher.php(400): XF\Mvc\Dispatcher->renderView(Object(XF\Mvc\Renderer\Html), Object(XF\Mvc\Reply\View))
#23 src/XF/Mvc/Dispatcher.php(360): XF\Mvc\Dispatcher->renderReply(Object(XF\Mvc\Renderer\Html), Object(XF\Mvc\Reply\View))
#24 src/XF/Mvc/Dispatcher.php(53): XF\Mvc\Dispatcher->render(Object(XF\Mvc\Reply\View), 'html')
#25 src/XF/App.php(2177): XF\Mvc\Dispatcher->run()
#26 src/XF.php(390): XF\App->run()
#27 index.php(20): XF::runApp('XF\\Pub\\App')

 

[Xon]

@NicolasZN that bug is unrelated to this add-on. It would likely be a conflict with @Siropu's chat add-on and the XFA/CustomUsernameIcons add-on. Just looking at the extended entities in arguments is often very misleading.

 

[NicolasZN]

Thanks for pointing me in the right direction, Xon! All fixed now. ^_^

 

[Xon]

When a report is issued for a thread reply ban, the "View" link simply goes to /posts/

Logging thread reply bans to reports is actually part of Report Improvements.

 

[dethfire]

Logging thread reply bans to reports is actually part of Report Improvements.

lol I never know what is what

 

[Xon]

Xon updated Report Improvements by Xon with a new update entry:

2.2.2 - Bugfix update

• Fix the thread link for a thread reply ban logged into the report system would display as 'posts/'

Read the rest of this update entry...

 

[Xon]

Xon updated Report Improvements by Xon with a new update entry:

2.2.3 - Maintenance update

• Compatibility fix for Report Centre Essential v2.1.0

Read the rest of this update entry...

 

[Xon]

Xon updated Report Improvements by Xon with a new update entry:

2.2.4 - Bugfix update

• Reduce SQL queries when bulk-indexing report comments

Read the rest of this update entry...

 

[Joe Link]

@Xon

Looks like we've got a missing phrase "svReportImprov_thread_reply_ban"

 

[Xon]

Xon updated Report Improvements by Xon with a new update entry:

2.2.5 - Maintenance update

• Use correct phrase for when issuing a reply-ban from a post

Read the rest of this update entry...

 

[Xon]

Xon updated Report Improvements by Xon with a new update entry:

2.2.6 - Maintenance update

• add options icon
• Convert XF1 report mentions to XF2 format

Read the rest of this update entry...

 

[Xon]

Xon updated Report Improvements by Xon with a new update entry:

2.2.7 - Bugfix update

• Fixes for XF1 upgrade path
• Allow reply-banning through a closed threads for moderators

Read the rest of this update entry...

 

[Joe Link]

@Xon

Just saw this in our error log.

Server error log

    InvalidArgumentException: Accessed unknown getter 'title' on XF:ReportComment[516] src/XF/Mvc/Entity/Entity.php:194

    Generated by: Joe Link Jul 15, 2019 at 4:57 AM

Stack trace

#0 src/XF/Mvc/Entity/Entity.php(106): XF\Mvc\Entity\Entity->get('title')
#1 internal_data/code_cache/templates/l7/s26/public/alert_report_comment_like_summary.php(6): XF\Mvc\Entity\Entity->offsetGet('title')
#2 src/XF/Template/Templater.php(1301): XF\Template\Templater->{closure}(Object(SV\ConversationEssentials\XF\Template\Templater), Array)
#3 src/addons/AL/ThreadFilter/XF/Template/Templater.php(109): XF\Template\Templater->renderTemplate('alert_report_co...', Array, true)
#4 src/XF/Alert/AbstractHandler.php(80): AL\ThreadFilter\XF\Template\Templater->renderTemplate('public:alert_re...', Array)
#5 src/XF/Entity/UserAlert.php(69): XF\Alert\AbstractHandler->render(Object(SV\AlertImprovements\XF\Entity\UserAlert))
#6 [internal function]: XF\Entity\UserAlert->render()
#7 src/XF/Template/Templater.php(985): call_user_func_array(Array, Array)
#8 internal_data/code_cache/templates/l7/s26/public/alert_macros.php(42): XF\Template\Templater->method(Object(SV\AlertImprovements\XF\Entity\UserAlert), 'render', Array)
#9 src/XF/Template/Templater.php(701): XF\Template\Templater->{closure}(Object(SV\ConversationEssentials\XF\Template\Templater), Array, Array)
#10 internal_data/code_cache/templates/l7/s26/public/svAlertsImprov_account_alerts_popup.php(18): XF\Template\Templater->callMacro('alert_macros', 'row', Array, Array)
#11 src/XF/Template/Templater.php(1301): XF\Template\Templater->{closure}(Object(SV\ConversationEssentials\XF\Template\Templater), Array)
#12 src/addons/AL/ThreadFilter/XF/Template/Templater.php(109): XF\Template\Templater->renderTemplate('svAlertsImprov_...', Array, true)
#13 src/XF/Template/Template.php(24): AL\ThreadFilter\XF\Template\Templater->renderTemplate('public:svAlerts...', Array)
#14 src/XF/Mvc/Renderer/Json.php(84): XF\Template\Template->render()
#15 src/XF/Mvc/Renderer/Json.php(68): XF\Mvc\Renderer\Json->renderHtmlFallback('XF:Account\\Aler...', 'public:svAlerts...', Array)
#16 src/XF/Mvc/Dispatcher.php(418): XF\Mvc\Renderer\Json->renderView('XF:Account\\Aler...', 'public:svAlerts...', Array)
#17 src/XF/Mvc/Dispatcher.php(400): XF\Mvc\Dispatcher->renderView(Object(XF\Mvc\Renderer\Json), Object(XF\Mvc\Reply\View))
#18 src/XF/Mvc/Dispatcher.php(360): XF\Mvc\Dispatcher->renderReply(Object(XF\Mvc\Renderer\Json), Object(XF\Mvc\Reply\View))
#19 src/XF/Mvc/Dispatcher.php(53): XF\Mvc\Dispatcher->render(Object(XF\Mvc\Reply\View), 'json')
#20 src/XF/App.php(2177): XF\Mvc\Dispatcher->run()
#21 src/XF.php(390): XF\App->run()
#22 index.php(20): XF::runApp('XF\\Pub\\App')
#23 {main}

Could it have to do with this in our Warning_Summary_Message phrase?

[b]Member:[/b] @{username}
[b]Warning:[/b] [url='{warning_link}']{warning_title}[/url]
[b]Report:[/b] {report}
[b]Content:[/b] [url='{content_link}']{title}[/url]
[b]Notes:[/b] {notes}

 

[Xon]

This is a bug from my Alert Improvements add-on, should have an update soon

 

[donwon]

Will this add on allow you to edit report comments for staff members?

 

[Xon]

Nope

 

[donwon]

Nope

Can we get that added?

 

[Joe Link]

@Xon

When a moderator tries to click on the likes bar in a report to see who liked their comment, they get an error "Liking your own content is considered cheating".