Report Improvements by Xon

Report Improvements by Xon 2.18.3

No permission to download
@Xon last update solved all the issue previously reported. Thanks!

Question, is there anything that we could add so that the Like button isn't displayed in the first (original) report comment. It's really confusing to have a Like button in the comment of the member who reported a post because: 1) there is no need for the staff to Like a member report. 2) members can't see the Likes for the Reports. Maybe a conditional statement?
 
Last edited:
Possible bug? I am seeing a page not found warning when I click to see who liked a report. XF 2.1
 
Getting elastic search errors in ACP and looks related to report improvements?

example 1:
#0 src/addons/XFES/Elasticsearch/Api.php(330): XFES\Elasticsearch\Api->request('put', 'uberpeop_xen/re...', '{
"title": ...')
#1 src/addons/XFES/Elasticsearch/Api.php(348): XFES\Elasticsearch\Api->requestFromIndex('put', 'report/41073', Array)
#2 src/addons/XFES/Elasticsearch/Api.php(152): XFES\Elasticsearch\Api->requestById('put', 'report', 41073, Array)
#3 src/addons/XFES/Search/Source/Elasticsearch.php(66): XFES\Elasticsearch\Api->index('report', 41073, Array)
#4 src/XF/Search/Search.php(40): XFES\Search\Source\Elasticsearch->index(Object(XF\Search\IndexRecord))
#5 src/XF/Behavior/Indexable.php(46): XF\Search\Search->index('report', Object(SV\ReportImprovements\XF\Entity\Report), false)
#6 src/XF.php(290): XF\Behavior\Indexable->XF\Behavior\{closure}()
#7 src/XF/Mvc/Dispatcher.php(143): XF::triggerRunOnce(true)
#8 src/XF/Mvc/Dispatcher.php(50): XF\Mvc\Dispatcher->dispatchLoop(Object(XF\Mvc\RouteMatch))
#9 src/XF/App.php(2177): XF\Mvc\Dispatcher->run()
#10 src/XF.php(390): XF\App->run()
#11 index.php(20): XF::runApp('XF\\Pub\\App')
#12 {main}

example 2:
#0 src/addons/XFES/Elasticsearch/Api.php(330): XFES\Elasticsearch\Api->request('put', 'uberpeop_xen/re...', '{
"title": ...')
#1 src/addons/XFES/Elasticsearch/Api.php(348): XFES\Elasticsearch\Api->requestFromIndex('put', 'report_comment/...', Array)
#2 src/addons/XFES/Elasticsearch/Api.php(152): XFES\Elasticsearch\Api->requestById('put', 'report_comment', 120690, Array)
#3 src/addons/XFES/Search/Source/Elasticsearch.php(66): XFES\Elasticsearch\Api->index('report_comment', 120690, Array)
#4 src/XF/Search/Search.php(40): XFES\Search\Source\Elasticsearch->index(Object(XF\Search\IndexRecord))
#5 src/XF/Behavior/Indexable.php(46): XF\Search\Search->index('report_comment', Object(SV\ReportImprovements\XF\Entity\ReportComment), false)
#6 src/XF.php(290): XF\Behavior\Indexable->XF\Behavior\{closure}()
#7 src/XF/Mvc/Dispatcher.php(143): XF::triggerRunOnce(true)
#8 src/XF/Mvc/Dispatcher.php(50): XF\Mvc\Dispatcher->dispatchLoop(Object(XF\Mvc\RouteMatch))
#9 src/XF/App.php(2177): XF\Mvc\Dispatcher->run()
#10 src/XF.php(390): XF\App->run()
#11 index.php(20): XF::runApp('XF\\Pub\\App')
#12 {main}
 
I need to see the actual error message from the ElasticSearch logs (not the XenForo Logs!!!), but likely you need to delete and re-index things.
 
  • XFES\Elasticsearch\RequestException: Elasticsearch indexing error (queued): failed to parse [report_state]
  • src/addons/XFES/Elasticsearch/Api.php:409
  • Generated by: admin
  • Feb 12, 2019 at 6:47 AM
Stack trace

#0 src/addons/XFES/Elasticsearch/Api.php(330): XFES\Elasticsearch\Api->request('put', '_xen/re...', '{
"title": ...')
#1 src/addons/XFES/Elasticsearch/Api.php(348): XFES\Elasticsearch\Api->requestFromIndex('put', 'report/41096', Array)
#2 src/addons/XFES/Elasticsearch/Api.php(152): XFES\Elasticsearch\Api->requestById('put', 'report', 41096, Array)
#3 src/addons/XFES/Search/Source/Elasticsearch.php(66): XFES\Elasticsearch\Api->index('report', 41096, Array)
#4 src/XF/Search/Search.php(40): XFES\Search\Source\Elasticsearch->index(Object(XF\Search\IndexRecord))
#5 src/XF/Behavior/Indexable.php(46): XF\Search\Search->index('report', Object(SV\ReportImprovements\XF\Entity\Report), false)
#6 src/XF.php(290): XF\Behavior\Indexable->XF\Behavior\{closure}()
#7 src/XF/Mvc/Dispatcher.php(143): XF::triggerRunOnce(true)
#8 src/XF/Mvc/Dispatcher.php(50): XF\Mvc\Dispatcher->dispatchLoop(Object(XF\Mvc\RouteMatch))
#9 src/XF/App.php(2177): XF\Mvc\Dispatcher->run()
#10 src/XF.php(390): XF\App->run()
#11 index.php(20): XF::runApp('XF\\Pub\\App')
#12 {main}

array(4) {
["url"] => string(21) "/posts/47320/report"
["referrer"] => string(52) "https://le.net/threads/profile-posts.31007/"
["_GET"] => array(0) {
}
["_POST"] => array(5) {
["message"] => string(27) "Please see"
["_xfToken"] => string(8) "****"
["_xfRequestUri"] => string(30) "/threads/profile-posts.31007/"
["_xfWithData"] => string(1) "1"
["_xfResponseType"] => string(4) "json"
}
}
 
Hallo Xon,

i got the following error during installation
Code:
Server error log

    RuntimeException: Warning:32, Report: The minimum number of prefixes requirement for this forum (1) has not been met., Report-message: Please enter a valid message., Report-title: Please enter a valid title. src/addons/SV/ReportImprovements/Service/WarningLog/Creator.php:336

    Generated by: Tealk Feb 15, 2019 at 10:04 AM

Stack trace

#0 src/XF/Service/ValidateAndSavableTrait.php(17): SV\ReportImprovements\Service\WarningLog\Creator->_validate()
#1 src/addons/SV/ReportImprovements/Job/WarningLogMigration.php(71): SV\ReportImprovements\Service\WarningLog\Creator->validate(NULL)
#2 src/XF.php(478): SV\ReportImprovements\Job\WarningLogMigration->SV\ReportImprovements\Job\{closure}()
#3 src/addons/SV/ReportImprovements/Job/WarningLogMigration.php(81): XF::asVisitor(Object(SV\ReportImprovements\XF\Entity\User), Object(Closure))
#4 src/XF/Job/AbstractRebuildJob.php(47): SV\ReportImprovements\Job\WarningLogMigration->rebuildById(32)
#5 src/XF/Job/Manager.php(253): XF\Job\AbstractRebuildJob->run(G)
#6 src/XF/Job/Manager.php(195): XF\Job\Manager->runJobInternal(Array, G)
#7 src/XF/Job/Manager.php(111): XF\Job\Manager->runJobEntry(Array, G)
#8 src/XF/Admin/Controller/Tools.php(120): XF\Job\Manager->runByIds(Array, 8)
#9 src/XF/Mvc/Dispatcher.php(321): XF\Admin\Controller\Tools->actionRunJob(Object(XF\Mvc\ParameterBag))
#10 src/XF/Mvc/Dispatcher.php(244): XF\Mvc\Dispatcher->dispatchClass('XF:Tools', 'RunJob', Object(XF\Mvc\RouteMatch), Object(NF\TeamSpeak\XF\Admin\Controller\Tools), NULL)
#11 src/XF/Mvc/Dispatcher.php(100): XF\Mvc\Dispatcher->dispatchFromMatch(Object(XF\Mvc\RouteMatch), Object(NF\TeamSpeak\XF\Admin\Controller\Tools), NULL)
#12 src/XF/Mvc/Dispatcher.php(50): XF\Mvc\Dispatcher->dispatchLoop(Object(XF\Mvc\RouteMatch))
#13 src/XF/App.php(2177): XF\Mvc\Dispatcher->run()
#14 src/XF.php(390): XF\App->run()
#15 admin.php(13): XF::runApp('XF\\Admin\\App')
#16 {main}

Request state

array(4) {
  ["url"] => string(24) "/admin.php?tools/run-job"
  ["referrer"] => string(45) "https://anzahcraft.de/admin.php?tools/run-job"
  ["_GET"] => array(1) {
    ["tools/run-job"] => string(0) ""
  }
  ["_POST"] => array(3) {
    ["_xfRedirect"] => string(81) "https://anzahcraft.de/admin.php?add-ons/install-from-archive-complete&batch_id=27"
    ["_xfToken"] => string(8) "********"
    ["only_ids"] => string(4) "1306"
  }
}
 
Thanks for the quick update for the likes popup!

I'm not sure if this is as designed, or?
Post in reports includes an attachment/image
Moderator go to content > deletes post
Original post text still shows in report to moderator and admin
Image does not show to moderator in report after post has been deleted
Image shows to admin in report after post has been deleted

It would be helpful if moderators could see the image as the original report was made for other moderators to evaluate and for historical records.
 
Due to this error, it is also not possible to execute a report.
even after I uninstalled the addon again.
 
Last edited:
Due to this error, it is also not possible to execute a report.
even after I uninstalled the addon again.
You are pushing reports to a forum with a minimum prefix count (maybe using MultiPrefix?) without a default prefix set. This is honestly expected behaviour.

I think this is still broken, anyone else confirm?
The like list is working on your dev site!
 
Top Bottom