Report Improvements by Xon

Report Improvements by Xon 2.10.9

No permission to download

Xon

Well-known member
Xon submitted a new resource:

Report Improvements by Xon - A Collection of improvements to XF's reporting system

This add-on introduces potentially breaking changes to moderation permissions. Please review usergroup permissions carefully!

A Collection of improvements to XF's reporting system. Fully phrased.


On install, all existing warnings are copied into a new warning change tracking log and associated with reports. This process occurs as a background task, and is non-disruptive.

Note; when reports are sent to a forum, the warning<->report links...

Read more about this resource...
 

dethfire

Well-known member
Best thing about this is the warning log in the report. However the alignment is off?
192433

One thing that has always lacked in the reports is better searching. It's baffling to me you can only search by report username. So many more parameters are useful for searching for. Thanks!!
 
  • Like
Reactions: Xon

Xon

Well-known member
However the alignment is off?
Would require editing the svReportImprov_report_view_warning_log template to tweak the CSS used. Removing pairs--justified should do it.

One thing that has always lacked in the reports is better searching. It's baffling to me you can only search by report username. So many more parameters are useful for searching for. Thanks!!
If you leave this as a review it is very visible to anyone looking at the add-on :)
 

dethfire

Well-known member
Feature request:

In report have a link or popup to the reported user's shared ips, previous warnings and previous reports. Really comes in handy!
 

easiii

Well-known member
Hello Xon,
I have this add-on and the Warning Improvements add-on and when I issue a warning I get this error:

Code:
RuntimeException: Report: Please enter a valid message. in src/addons/SV/ReportImprovements/Service/WarningLog/Creator.php at line 210
SV\ReportImprovements\Service\WarningLog\Creator->SV\ReportImprovements\Service\WarningLog\{closure}() in src/addons/SV/ReportImprovements/Service/WarningLog/Creator.php at line 239
SV\ReportImprovements\Service\WarningLog\Creator->_validate() in src/XF/Service/ValidateAndSavableTrait.php at line 17
SV\ReportImprovements\Service\WarningLog\Creator->validate() in src/addons/SV/ReportImprovements/XF/Repository/Warning.php at line 83
SV\ReportImprovements\XF\Repository\Warning->SV\ReportImprovements\XF\Repository\{closure}() in src/XF.php at line 397
XF::asVisitor() in src/addons/SV/ReportImprovements/XF/Repository/Warning.php at line 92
SV\ReportImprovements\XF\Repository\Warning->logOperation() in src/addons/SV/ReportImprovements/XF/Entity/Warning.php at line 64
SV\ReportImprovements\XF\Entity\Warning->_postSave() in src/XF/Mvc/Entity/Entity.php at line 1165
XF\Mvc\Entity\Entity->save() in src/XF/Service/User/Warn.php at line 172
XF\Service\User\Warn->_save() in src/addons/SV/WarningImprovements/XF/Service/User/Warn.php at line 76
SV\WarningImprovements\XF\Service\User\Warn->_save() in src/addons/SV/ReportImprovements/XF/Service/User/Warn.php at line 84
SV\ReportImprovements\XF\Service\User\Warn->_save() in src/XF/Service/ValidateAndSavableTrait.php at line 40
XF\Service\User\Warn->save() in src/XF/ControllerPlugin/Warn.php at line 41
XF\ControllerPlugin\Warn->actionWarn() in src/addons/SV/WarningImprovements/XF/ControllerPlugin/Warn.php at line 46
SV\WarningImprovements\XF\ControllerPlugin\Warn->actionWarn() in src/addons/SV/ReportImprovements/XF/ControllerPlugin/Warn.php at line 109
SV\ReportImprovements\XF\ControllerPlugin\Warn->actionWarn() in src/XF/Pub/Controller/Post.php at line 384
XF\Pub\Controller\Post->actionWarn() in src/XF/Mvc/Dispatcher.php at line 249
XF\Mvc\Dispatcher->dispatchClass() in src/XF/Mvc/Dispatcher.php at line 88
XF\Mvc\Dispatcher->dispatchLoop() in src/XF/Mvc/Dispatcher.php at line 41
XF\Mvc\Dispatcher->run() in src/XF/App.php at line 1934
XF\App->run() in src/XF.php at line 333
XF::runApp() in index.php at line 13
 

graham_w

Active member
Got an error when upgrading




Server error log
  • RuntimeException: Report: Please enter a valid message.
  • src/addons/SV/ReportImprovements/Service/WarningLog/Creator.php:241
  • Jan 27, 2019 at 3:54 PM
Stack trace
#0 src/addons/SV/ReportImprovements/Service/WarningLog/Creator.php(270): SV\ReportImprovements\Service\WarningLog\Creator->SV\ReportImprovements\Service\WarningLog\{closure}('Report', Array)
#1 src/XF/Service/ValidateAndSavableTrait.php(17): SV\ReportImprovements\Service\WarningLog\Creator->_validate()
#2 src/addons/SV/ReportImprovements/Job/WarningLogMigration.php(71): SV\ReportImprovements\Service\WarningLog\Creator->validate(NULL)
#3 src/XF.php(478): SV\ReportImprovements\Job\WarningLogMigration->SV\ReportImprovements\Job\{closure}()
#4 src/addons/SV/ReportImprovements/Job/WarningLogMigration.php(81): XF::asVisitor(Object(SV\ReportImprovements\XF\Entity\User), Object(Closure))
#5 src/XF/Job/AbstractRebuildJob.php(47): SV\ReportImprovements\Job\WarningLogMigration->rebuildById(89)
#6 src/XF/Job/Manager.php(253): XF\Job\AbstractRebuildJob->run(G)
#7 src/XF/Job/Manager.php(195): XF\Job\Manager->runJobInternal(Array, G)
#8 src/XF/Job/Manager.php(111): XF\Job\Manager->runJobEntry(Array, G)
#9 src/XF/Admin/Controller/Tools.php(120): XF\Job\Manager->runByIds(Array, 8)
#10 src/XF/Mvc/Dispatcher.php(321): XF\Admin\Controller\Tools->actionRunJob(Object(XF\Mvc\ParameterBag))
#11 src/XF/Mvc/Dispatcher.php(248): XF\Mvc\Dispatcher->dispatchClass('XF:Tools', 'RunJob', Object(XF\Mvc\RouteMatch), Object(SV\UserMentionsImprovements\XF\Admin\Controller\Tools), NULL)
#12 src/XF/Mvc/Dispatcher.php(100): XF\Mvc\Dispatcher->dispatchFromMatch(Object(XF\Mvc\RouteMatch), Object(SV\UserMentionsImprovements\XF\Admin\Controller\Tools), NULL)
#13 src/XF/Mvc/Dispatcher.php(50): XF\Mvc\Dispatcher->dispatchLoop(Object(XF\Mvc\RouteMatch))
#14 src/XF/App.php(2177): XF\Mvc\Dispatcher->run()
#15 src/XF.php(390): XF\App->run()
#16 admin.php(13): XF::runApp('XF\\Admin\\App')
#17 {main}
 

Xon

Well-known member
@graham_w can you open a ticket on my site? and post a screenshot of your Report Improvements options (and Report Centre Essentials if installed). I may require access to your admincp to inspect what options yo have configured.
 

Sunka

Well-known member
Got an error when upgrading




Server error log
  • RuntimeException: Report: Please enter a valid message.
  • src/addons/SV/ReportImprovements/Service/WarningLog/Creator.php:241
  • Jan 27, 2019 at 3:54 PM
Stack trace
#0 src/addons/SV/ReportImprovements/Service/WarningLog/Creator.php(270): SV\ReportImprovements\Service\WarningLog\Creator->SV\ReportImprovements\Service\WarningLog\{closure}('Report', Array)
#1 src/XF/Service/ValidateAndSavableTrait.php(17): SV\ReportImprovements\Service\WarningLog\Creator->_validate()
#2 src/addons/SV/ReportImprovements/Job/WarningLogMigration.php(71): SV\ReportImprovements\Service\WarningLog\Creator->validate(NULL)
#3 src/XF.php(478): SV\ReportImprovements\Job\WarningLogMigration->SV\ReportImprovements\Job\{closure}()
#4 src/addons/SV/ReportImprovements/Job/WarningLogMigration.php(81): XF::asVisitor(Object(SV\ReportImprovements\XF\Entity\User), Object(Closure))
#5 src/XF/Job/AbstractRebuildJob.php(47): SV\ReportImprovements\Job\WarningLogMigration->rebuildById(89)
#6 src/XF/Job/Manager.php(253): XF\Job\AbstractRebuildJob->run(G)
#7 src/XF/Job/Manager.php(195): XF\Job\Manager->runJobInternal(Array, G)
#8 src/XF/Job/Manager.php(111): XF\Job\Manager->runJobEntry(Array, G)
#9 src/XF/Admin/Controller/Tools.php(120): XF\Job\Manager->runByIds(Array, 8)
#10 src/XF/Mvc/Dispatcher.php(321): XF\Admin\Controller\Tools->actionRunJob(Object(XF\Mvc\ParameterBag))
#11 src/XF/Mvc/Dispatcher.php(248): XF\Mvc\Dispatcher->dispatchClass('XF:Tools', 'RunJob', Object(XF\Mvc\RouteMatch), Object(SV\UserMentionsImprovements\XF\Admin\Controller\Tools), NULL)
#12 src/XF/Mvc/Dispatcher.php(100): XF\Mvc\Dispatcher->dispatchFromMatch(Object(XF\Mvc\RouteMatch), Object(SV\UserMentionsImprovements\XF\Admin\Controller\Tools), NULL)
#13 src/XF/Mvc/Dispatcher.php(50): XF\Mvc\Dispatcher->dispatchLoop(Object(XF\Mvc\RouteMatch))
#14 src/XF/App.php(2177): XF\Mvc\Dispatcher->run()
#15 src/XF.php(390): XF\App->run()
#16 admin.php(13): XF::runApp('XF\\Admin\\App')
#17 {main}


@graham_w can you open a ticket on my site? and post a screenshot of your Report Improvements options (and Report Centre Essentials if installed). I may require access to your admincp to inspect what options yo have configured.

Same error here

Code:
Server error log
RuntimeException: Warning log: Please enter a valid title. src/addons/SV/ReportImprovements/Service/WarningLog/Creator.php:241
Generated by: Sunka 27.01.2019. at 18:07
Stack trace
#0 src/addons/SV/ReportImprovements/Service/WarningLog/Creator.php(269): SV\ReportImprovements\Service\WarningLog\Creator->SV\ReportImprovements\Service\WarningLog\{closure}('Warning log', Array)
#1 src/XF/Service/ValidateAndSavableTrait.php(17): SV\ReportImprovements\Service\WarningLog\Creator->_validate()
#2 src/addons/SV/ReportImprovements/Job/WarningLogMigration.php(71): SV\ReportImprovements\Service\WarningLog\Creator->validate(NULL)
#3 src/XF.php(397): SV\ReportImprovements\Job\WarningLogMigration->SV\ReportImprovements\Job\{closure}()
#4 src/addons/SV/ReportImprovements/Job/WarningLogMigration.php(81): XF::asVisitor(Object(SV\ReportImprovements\XF\Entity\User), Object(Closure))
#5 src/XF/Job/AbstractRebuildJob.php(47): SV\ReportImprovements\Job\WarningLogMigration->rebuildById(14)
#6 src/XF/Job/Manager.php(241): XF\Job\AbstractRebuildJob->run(G)
#7 src/XF/Job/Manager.php(187): XF\Job\Manager->runJobInternal(Array, G)
#8 src/XF/Job/Manager.php(103): XF\Job\Manager->runJobEntry(Array, G)
#9 src/XF/Admin/Controller/Tools.php(120): XF\Job\Manager->runByIds(Array, 8)
#10 src/XF/Mvc/Dispatcher.php(249): XF\Admin\Controller\Tools->actionRunJob(Object(XF\Mvc\ParameterBag))
#11 src/XF/Mvc/Dispatcher.php(88): XF\Mvc\Dispatcher->dispatchClass('XF:Tools', 'RunJob', 'html', Object(XF\Mvc\ParameterBag), 'tools', Object(SV\UserMentionsImprovements\XF\Admin\Controller\Tools), NULL)
#12 src/XF/Mvc/Dispatcher.php(41): XF\Mvc\Dispatcher->dispatchLoop(Object(XF\Mvc\RouteMatch))
#13 src/XF/App.php(1934): XF\Mvc\Dispatcher->run()
#14 src/XF.php(333): XF\App->run()
#15 admin.php(13): XF::runApp('XF\\Admin\\App')
#16 {main}
Request state
array(4) {
  ["url"] => string(24) "/admin.php?tools/run-job"
  ["referrer"] => string(135) "https://www.pijanitvor.com/admin.php?tools/run-job&only_ids=27497&_xfRedirect=https%3A%2F%2Fwww.pijanitvor.com%2Fadmin.php%3Fadd-ons%2F"
  ["_GET"] => array(1) {
    ["tools/run-job"] => string(0) ""
  }
  ["_POST"] => array(3) {
    ["_xfRedirect"] => string(45) "https://www.pijanitvor.com/admin.php?add-ons/"
    ["_xfToken"] => string(8) "********"
    ["only_ids"] => string(5) "27497"
  }
}

Report Centre Essentials is not installed

193727

@Xon
if you require access to my admincp to inspect what options I have configured, drop me PM here, or to open ticket on your web page?
 

Xon

Well-known member
Got an error when upgrading




Server error log
  • RuntimeException: Report: Please enter a valid message.
  • src/addons/SV/ReportImprovements/Service/WarningLog/Creator.php:241
  • Jan 27, 2019 at 3:54 PM
Stack trace
#0 src/addons/SV/ReportImprovements/Service/WarningLog/Creator.php(270): SV\ReportImprovements\Service\WarningLog\Creator->SV\ReportImprovements\Service\WarningLog\{closure}('Report', Array)
#1 src/XF/Service/ValidateAndSavableTrait.php(17): SV\ReportImprovements\Service\WarningLog\Creator->_validate()
#2 src/addons/SV/ReportImprovements/Job/WarningLogMigration.php(71): SV\ReportImprovements\Service\WarningLog\Creator->validate(NULL)
#3 src/XF.php(478): SV\ReportImprovements\Job\WarningLogMigration->SV\ReportImprovements\Job\{closure}()
#4 src/addons/SV/ReportImprovements/Job/WarningLogMigration.php(81): XF::asVisitor(Object(SV\ReportImprovements\XF\Entity\User), Object(Closure))
#5 src/XF/Job/AbstractRebuildJob.php(47): SV\ReportImprovements\Job\WarningLogMigration->rebuildById(89)
#6 src/XF/Job/Manager.php(253): XF\Job\AbstractRebuildJob->run(G)
#7 src/XF/Job/Manager.php(195): XF\Job\Manager->runJobInternal(Array, G)
#8 src/XF/Job/Manager.php(111): XF\Job\Manager->runJobEntry(Array, G)
#9 src/XF/Admin/Controller/Tools.php(120): XF\Job\Manager->runByIds(Array, 8)
#10 src/XF/Mvc/Dispatcher.php(321): XF\Admin\Controller\Tools->actionRunJob(Object(XF\Mvc\ParameterBag))
#11 src/XF/Mvc/Dispatcher.php(248): XF\Mvc\Dispatcher->dispatchClass('XF:Tools', 'RunJob', Object(XF\Mvc\RouteMatch), Object(SV\UserMentionsImprovements\XF\Admin\Controller\Tools), NULL)
#12 src/XF/Mvc/Dispatcher.php(100): XF\Mvc\Dispatcher->dispatchFromMatch(Object(XF\Mvc\RouteMatch), Object(SV\UserMentionsImprovements\XF\Admin\Controller\Tools), NULL)
#13 src/XF/Mvc/Dispatcher.php(50): XF\Mvc\Dispatcher->dispatchLoop(Object(XF\Mvc\RouteMatch))
#14 src/XF/App.php(2177): XF\Mvc\Dispatcher->run()
#15 src/XF.php(390): XF\App->run()
#16 admin.php(13): XF::runApp('XF\\Admin\\App')
#17 {main}
Same error here

Code:
Server error log
RuntimeException: Warning log: Please enter a valid title. src/addons/SV/ReportImprovements/Service/WarningLog/Creator.php:241
Generated by: Sunka 27.01.2019. at 18:07
Stack trace
#0 src/addons/SV/ReportImprovements/Service/WarningLog/Creator.php(269): SV\ReportImprovements\Service\WarningLog\Creator->SV\ReportImprovements\Service\WarningLog\{closure}('Warning log', Array)
#1 src/XF/Service/ValidateAndSavableTrait.php(17): SV\ReportImprovements\Service\WarningLog\Creator->_validate()
#2 src/addons/SV/ReportImprovements/Job/WarningLogMigration.php(71): SV\ReportImprovements\Service\WarningLog\Creator->validate(NULL)
#3 src/XF.php(397): SV\ReportImprovements\Job\WarningLogMigration->SV\ReportImprovements\Job\{closure}()
#4 src/addons/SV/ReportImprovements/Job/WarningLogMigration.php(81): XF::asVisitor(Object(SV\ReportImprovements\XF\Entity\User), Object(Closure))
#5 src/XF/Job/AbstractRebuildJob.php(47): SV\ReportImprovements\Job\WarningLogMigration->rebuildById(14)
#6 src/XF/Job/Manager.php(241): XF\Job\AbstractRebuildJob->run(G)
#7 src/XF/Job/Manager.php(187): XF\Job\Manager->runJobInternal(Array, G)
#8 src/XF/Job/Manager.php(103): XF\Job\Manager->runJobEntry(Array, G)
#9 src/XF/Admin/Controller/Tools.php(120): XF\Job\Manager->runByIds(Array, 8)
#10 src/XF/Mvc/Dispatcher.php(249): XF\Admin\Controller\Tools->actionRunJob(Object(XF\Mvc\ParameterBag))
#11 src/XF/Mvc/Dispatcher.php(88): XF\Mvc\Dispatcher->dispatchClass('XF:Tools', 'RunJob', 'html', Object(XF\Mvc\ParameterBag), 'tools', Object(SV\UserMentionsImprovements\XF\Admin\Controller\Tools), NULL)
#12 src/XF/Mvc/Dispatcher.php(41): XF\Mvc\Dispatcher->dispatchLoop(Object(XF\Mvc\RouteMatch))
#13 src/XF/App.php(1934): XF\Mvc\Dispatcher->run()
#14 src/XF.php(333): XF\App->run()
#15 admin.php(13): XF::runApp('XF\\Admin\\App')
#16 {main}
Request state
array(4) {
  ["url"] => string(24) "/admin.php?tools/run-job"
  ["referrer"] => string(135) "https://www.pijanitvor.com/admin.php?tools/run-job&only_ids=27497&_xfRedirect=https%3A%2F%2Fwww.pijanitvor.com%2Fadmin.php%3Fadd-ons%2F"
  ["_GET"] => array(1) {
    ["tools/run-job"] => string(0) ""
  }
  ["_POST"] => array(3) {
    ["_xfRedirect"] => string(45) "https://www.pijanitvor.com/admin.php?add-ons/"
    ["_xfToken"] => string(8) "********"
    ["only_ids"] => string(5) "27497"
  }
}

Report Centre Essentials is not installed

View attachment 193727

@Xon
if you require access to my admincp to inspect what options I have configured, drop me PM here, or to open ticket on your web page?
I get the same error on install
RuntimeException: Warning log: Please enter a valid title. in src/addons/SV/ReportImprovements/Service/WarningLog/Creator.php at line 241
I'm looking into the above error, but it does not block the add-on from working. Just prevents logging legacy warnings into the report system.
 

dethfire

Well-known member
  • InvalidArgumentException: Job SV\ReportImprovements:ResolveInactiveReport: Attempted to convert NULL to string/binary [username]
  • src/XF/Mvc/Entity/Entity.php:740

Stack trace

#0 src/XF/Mvc/Entity/Entity.php(618): XF\Mvc\Entity\Entity->_castValueToType(NULL, 'username', 5, Array)
#1 src/XF/Mvc/Entity/Entity.php(548): XF\Mvc\Entity\Entity->set('username', NULL)
#2 src/XF/Service/Report/CommentPreparer.php(35): XF\Mvc\Entity\Entity->__set('username', NULL)
#3 src/XF/Service/Report/Commenter.php(60): XF\Service\Report\CommentPreparer->setUser(Object(SV\ReportImprovements\XF\Entity\User))
#4 src/addons/SV/ReportImprovements/XF/Service/Report/Commenter.php(23): XF\Service\Report\Commenter->setCommentDefaults()
#5 src/XF/Service/Report/Commenter.php(38): SV\ReportImprovements\XF\Service\Report\Commenter->setCommentDefaults()
#6 src/XF/Container.php(274): XF\Service\Report\Commenter->__construct(Object(XF\Pub\App), Object(SV\ReportImprovements\XF\Entity\Report))
#7 src/XF/App.php(1563): XF\Container->createObject('SV\\ReportImprov...', Array)
#8 src/XF/Container.php(228): XF\App->XF\{closure}('XF:Report\\Comme...', Array, Object(XF\Container))
#9 src/XF/App.php(2769): XF\Container->create('service', 'XF:Report\\Comme...', Array)
#10 src/addons/SV/ReportImprovements/Job/ResolveInactiveReport.php(52): XF\App->service('XF:Report\\Comme...', Object(SV\ReportImprovements\XF\Entity\Report))
#11 src/XF/Job/AbstractRebuildJob.php(47): SV\ReportImprovements\Job\ResolveInactiveReport->rebuildById(13493)
#12 src/XF/Job/Manager.php(253): XF\Job\AbstractRebuildJob->run(G)
#13 src/XF/Job/Manager.php(195): XF\Job\Manager->runJobInternal(Array, G)
#14 src/XF/Job/Manager.php(79): XF\Job\Manager->runJobEntry(Array, G)
#15 job.php(42): XF\Job\Manager->runQueue(false, 8)
#16 {main}
 
Top