Editor & BB Code Manager 2.0.1 Patch Level 1

[Lukas W.]

@katsulynx ,How can I change [HIDETHANKS] to [HIDE-THANKS]?

You can't. The XenForo2 BB code parser is not able to process dashes and XenForo1 already actively tried you to prevent dashes in custom BB codes.

 

[Emre]

@katsulynx , Is mySQL modified?

 

[Lukas W.]

@katsulynx , Is mySQL modified?

If you've used the hide-hack back in XF1, then that's the problem. The XF1-parser was technically able to parse BB codes containing dashes, even though it was not recommended or encouraged.

 

[Emre]

thank's so much @katsulynx

 

[Lukas W.]

Depending on the number of posts you have, you could potentially run a SQL query to rectify that and remove all the dashes. If you have too many however, that would probably not be feasible.

 

[Mr Lucky]

Any idea what this error is about?

    GuzzleHttp\Exception\ClientException: Twitch API connection error: Client error response [url] https://www.googleapis.com/webfonts/v1/webfonts?key= [status code] 400 [reason phrase] Bad Request src/vendor/guzzlehttp/guzzle/src/Exception/RequestException.php:89

    Generated by: Unknown account Apr 15, 2018 at 1:00 AM

Stack trace

#0 src/vendor/guzzlehttp/guzzle/src/Subscriber/HttpError.php(32): GuzzleHttp\Exception\RequestException::create(Object(GuzzleHttp\Message\Request), Object(GuzzleHttp\Message\Response))
#1 src/vendor/guzzlehttp/guzzle/src/Event/Emitter.php(108): GuzzleHttp\Subscriber\HttpError->onComplete(Object(GuzzleHttp\Event\CompleteEvent), 'complete')
#2 src/vendor/guzzlehttp/guzzle/src/RequestFsm.php(91): GuzzleHttp\Event\Emitter->emit('complete', Object(GuzzleHttp\Event\CompleteEvent))
#3 src/vendor/guzzlehttp/guzzle/src/RequestFsm.php(132): GuzzleHttp\RequestFsm->__invoke(Object(GuzzleHttp\Transaction))
#4 src/vendor/react/promise/src/FulfilledPromise.php(25): GuzzleHttp\RequestFsm->GuzzleHttp\{closure}(Array)
#5 src/vendor/guzzlehttp/ringphp/src/Future/CompletedFutureValue.php(55): React\Promise\FulfilledPromise->then(Object(Closure), NULL, NULL)
#6 src/vendor/guzzlehttp/guzzle/src/Message/FutureResponse.php(43): GuzzleHttp\Ring\Future\CompletedFutureValue->then(Object(Closure), NULL, NULL)
#7 src/vendor/guzzlehttp/guzzle/src/RequestFsm.php(134): GuzzleHttp\Message\FutureResponse::proxy(Object(GuzzleHttp\Ring\Future\CompletedFutureArray), Object(Closure))
#8 src/vendor/guzzlehttp/guzzle/src/Client.php(165): GuzzleHttp\RequestFsm->__invoke(Object(GuzzleHttp\Transaction))
#9 src/vendor/guzzlehttp/guzzle/src/Client.php(125): GuzzleHttp\Client->send(Object(GuzzleHttp\Message\Request))
#10 src/addons/KL/EditorManager/Repository/GoogleFonts.php(25): GuzzleHttp\Client->get('https://www.goo...')
#11 src/addons/KL/EditorManager/Cron/GoogleFonts.php(13): KL\EditorManager\Repository\GoogleFonts->updateFontList()
#12 [internal function]: KL\EditorManager\Cron\GoogleFonts::run(Object(XF\Entity\CronEntry))
#13 src/XF/Job/Cron.php(35): call_user_func(Array, Object(XF\Entity\CronEntry))
#14 src/XF/Job/Manager.php(241): XF\Job\Cron->run(8)
#15 src/XF/Job/Manager.php(187): XF\Job\Manager->runJobInternal(Array, 8)
#16 src/XF/Job/Manager.php(76): XF\Job\Manager->runJobEntry(Array, 8)
#17 job.php(15): XF\Job\Manager->runQueue(false, 8)
#18 {main}

Request state

array(4) {
  ["url"] => string(8) "/job.php"
  ["referrer"] => string(77) "https://cafesaxophone.com/threads/problems-with-high-g-and-low-register.6015/"
  ["_GET"] => array(0) {
  }
  ["_POST"] => array(0) {
  }
}

 

[Lukas W.]

Twitch API connection error

That's a bad leftover from a copy-pasted passage in the code. It actually means to say there's been a Google API connection error, when the add-on tried to grab the google fonts list from the Google Fonts API. If you haven't enabled external font polling or have not entered an API key, that might be an error on my end, if you have however, it could be a malconfigured API key - you might have set up the wrong or no API key restrictions.

 

[Mr Lucky]

All I have done is add one font via External web




One thing seems odd: the thread referenced in the error is actually six years old, started and finished before I even had xenforo, let alone your addon

???

Plus (FYI), I am unable to invoke the error again by using the Dosis font in text editor

 

[Lukas W.]

One thing seems odd: the thread referenced in the error is actually six years old, started and finished before I even had xenforo, let alone your addon

That's a misinterpretation of the error message. See, the actual caller is "/job.php", the thread mentioned is only the referer. In other words, someone (likely a crawler or similar) opened the thread which started the XenForo Job system, which then in turn started the Cron Job system, which then again in turn started the Google Fonts API cron job and that then threw the error. TL;DR: it could have been any other page as well.

I've just checked the code and it seems I forgot to actually check if you've set an API key in the ACP options, so I've built that in for the next update. The error is safe to ignore for you and will appear again soonest next week on sunday around 1 AM. I'll probably have uploaded the patch until then.

 

[Mr Lucky]

Ah, so should I have set a Google API key? (I didn't)

 

[Lukas W.]

Ah, so should I have set a Google API key? (I didn't)

No. Setting the google API key is optional, and only necessary if you want to have the google fonts button in your editor toolbar to allow your users to use all google fonts without you adding all them manually to your font list, and if you want the auto-complete feature to work in the popup.

 

[Nirjonadda]

@katsulynx How to enable can not hide in 1st post, thread creating? Also un-hide 1st post automatically?

What does About Permissions Postcount for hides? Does its used Postcount required can use HIDE tag or can view Hide tag content?

Default hide version > hide until reply or liked but Why hide messages are not updated?

Its show You need to reply to this in order to see this content. but Its should be show You need to reply or like to this post in order to see this content.

 

[mkucuksari]

Again many thanks for this great addon and updates. I have a bug report and a question.

1- "Hex Color Input" settings at AP does not seem to be work. Although this setting is unselected, the user can insert Hex colour code from editor.


2- Could you please give some more info how "Remove format on paste" option is working. I have tested it and found it is also not working or I don't understand how it really works ?

 

[V3NTUS]

Unfortunately this great add-on seems to interfere with Siropu Chat. In particular, it removes the possibility to use the custom bbcodes defined by Siropu in its add-on, as they get overridden by your Add-On instead.

Hopefully you'll come up with a solution, @katsulynx .

Thank you for your time.

 

[The Grand Potentate]

@katsulynx this addon is fantastic! I was FINALLY able to get my mobile toolbar down to one line. long has that been a pet peeve of mine.

wanted to let you know about a possible bug, browser interaction - in google chrome desktop the tooltips are showing up and then not disappearing in the editor:

 

[The Grand Potentate]

@katsulynx trying out the dropdown option, I can't seem to get any other font awesome icon to show up other than the little flag. is there some special formatting of the code to put in other than fa fa-...?

also, why can't we add text color, font family, and font size to a drop down?

lastly, is there a way to change which icon is used for the individual buttons? i'd like to change the spoiler from the flag. used to be able to do that under the old bbcode manager.

 

[V3NTUS]

Why on Earth would you want to add Font Family or Font Size in a dropdown if they are already dropdowns themselves man?

Try not to make the author of this add-on get crazy for ridiculous requests please.

 

[The Grand Potentate]

Why on Earth would you want to add Font Family or Font Size in a dropdown if they are already dropdowns themselves man?

Try not to make the author of this add-on get crazy for ridiculous requests please.

jesus christ, man, i just wanted to know if it was possible. i'm not demanding that he do this immediately. take it down a notch.

 

[Lukas W.]

@katsulynx trying out the dropdown option, I can't seem to get any other font awesome icon to show up other than the little flag. is there some special formatting of the code to put in other than fa fa-...?

Leave the "fa" away. If you want the eye for example, typing eye should suffice.

also, why can't we add text color, font family, and font size to a drop down?

Putting them there is unfortunately not possible.

lastly, is there a way to change which icon is used for the individual buttons? i'd like to change the spoiler from the flag. used to be able to do that under the old bbcode manager.

Defining icons in Froala is an utterly complex process, and I haven't found out/tried yet, if it would even be possible to override existing definitions.

 

[Lukas W.]

wanted to let you know about a possible bug, browser interaction - in google chrome desktop the tooltips are showing up and then not disappearing in the editor:

I've noticed that one as well, but I've considering it unimportant/annoying at most for the moment, and as it's only happening in the ACP. I've gone ahead and added it to the known bugs section for now.