XF 2.0 Conflicts with uninstalled addons

[Mr Lucky]

I have uninstalled addons (in xf 1.5. before upgrading) but after uploading xf2 files and attempt to upgrade I get this warning:

Known conflicts with the following third-party add-ons have been detected:

• [TH] Custom Fields
• [bd] Widget Framework

Conflicts will be resolved during the upgrade process by renaming affected database tables and columns. If you do not intend to use the add-ons after upgrading, you may prefer to restore the XenForo files from your previous version and uninstall the conflicting add-ons. The add-on authors may have more specific recommendations for resolving these conflicts.

Why would there be conflicts if I have uninstalled the addons in xf1?

(I noted that after uninstalling, the tables from those addons were no longer in the database)

 

[Chris D]

Because the add-on developers have forgotten to remove all of their database tables and/or schema changes during uninstallation.

This doesn't block the upgrade (anymore) though so should be safe to proceed. Let us know how you get on

 

[Mr Lucky]

Because the add-on developers have forgotten to remove all of their database tables and/or schema changes during uninstallation.

This doesn't block the upgrade (anymore) though so should be safe to proceed. Let us know how you get on

Yes the upgrade went OK, but three pages of server error logs

 

[Mike]

I presume with conflict warnings? Can you provide a list of them?

 

[Jake B.]

I just did a test uninstall and upgrade to xf2 with Custom Fields and it seems to remove all of the fields correctly from what I can tell, what fields were left when you uninstalled?

 

[Chris D]

What about the tables?

I've just had a peek inside the installer and I can't see anything that removes things from the tables listed in the _getTables method, which includes xf_thread_field amongst others.

 

[Jake B.]

What about the tables?

I've just had a peek inside the installer and I can't see anything that removes things from the tables listed in the _getTables method, which includes xf_thread_field amongst others.

Tables created through _getTables are automatically removed on uninstall as well in the Waindigo/ThemeHouse_Install::_uninstall method

 

[Jake B.]

Also, FWIW I've uninstalled and did a test upgrade on boards with Widget Framework installed as well without issue

 

[Mr Lucky]

I presume with conflict warnings? Can you provide a list of them?

There are 63, what's the best way to get a list of them?

 

[Mr Lucky]

I just did a test uninstall and upgrade to xf2 with Custom Fields and it seems to remove all of the fields correctly from what I can tell, what fields were left when you uninstalled?

I don't know, all I know is I disabled, then uninstalled addons, then did the upgrade.

 

[Mike]

There are 63, what's the best way to get a list of them?

I likely just need the message itself, not any of the stack trace, so screenshots may be simplest. (Otherwise copy and paste would work.)

I mostly just want to confirm that they're from elements that add-ons likely created. These logs are expected if conflicts arise (so you/the add-on dev can be aware of them).

 

[Chris D]

Also, FWIW I've uninstalled and did a test upgrade on boards with Widget Framework installed as well without issue

That definitely doesn't remove the xf_widget table, at least not the version released here.

 

[Jake B.]

That definitely doesn't remove the xf_widget table, at least not the version released here.

Are you sure? I just did a test upgrade yesterday after uninstalling it (not 100% sure of the version, so it may have been a newer one from his GitHub) and I don't think I had to manually remove any tables, looks like it has the code in Installer.php to remove it in 2.5.9 (latest version released here)

/* Start auto-generated lines of code. Change made will be overwriten... */

    protected static $_tables = array(
...
        'xf_widget' => array(
            'createQuery' => '...',
            'dropQuery' => 'DROP TABLE IF EXISTS `xf_widget`',
        ),
    );

and inside the uninstall function:

foreach (self::$_tables as $table) {
        $db->query($table['dropQuery']);
}

 

[Mr Lucky]

Ah well the whole thing went pear shaped anyway when I subsequently uploaded the wrong for a different site by mistake, so started the whole process again and this time it was fine. So I don't know...

 

[Chris D]

So you don't have any of the error logs now?

 

[Mr Lucky]

So you don't have any of the error logs now?

No sorry, I had thought it would just do the same thing but it just went OK.

I'll do another one in the morning to see if I can reproduce any issues.