Chat by Siropu [Paid] 1.25.1

[Siropu]

Seems to be a JS problem. Will look into it.

 

[oza2012]

Security bug ?

Open \library\Siropu\Chat\ControllerPublic\Chat.php

and find:

protected function _getRoomID($validate = true)

and find:

 if ($validate)

Replace with:

if ($validate && $roomId)

Sorry for my English !

 

[Siropu]

It's not a security bug. Your change won't validate because the general chat room has ID 0.
If you do find security bugs, please send me a PM or a support ticket instead.

 

[Enguerran A]

I'm trying to use put chat into a new template. Which code can I copy to get everything working?

 

[overifist]

Bug:

If you say a keyword inside the brackets when your whispering someone the bot response shows.

 

[oza2012]

It's not a security bug. Your change won't validate because the general chat room has ID 0.
If you do find security bugs, please send me a PM or a support ticket instead.

See:

To view this content we will need your consent to set third party cookies.
For more detailed information, see our cookies page.

Accept third party cookies

 

[Siropu]

@Enguerran A,

<xen:callback class="Siropu_Chat_Callback" method="getChat" params="{xen:array 'room_id=0'}"></xen:callback>

This will work with embed mode only.

You can also use the iframe:

<iframe src="http://www.your-domain.com/chat/fullpage" width="600" height="400" frameborder="0"></iframe>

@overifist, will look into it.

 

[oza2012]

Bug this code (\library\Siropu\Chat\ControllerPublic\Chat.php):

<removed at request of code author>

$validate = true

and:

if ($validate)
{
*****
}

True always.

 

[Siropu]

@oza2012, it's supposed to return true by default. In some instances the function is called with "false" to get the value from get/post instead of cookie/session.
The problem is with cookies and I will change that.

 

[Siropu]

Siropu updated Chat by Siropu with a new update entry:

Bug Fixes

Bugs Fixed

1. Altering browser chat cookie could bypass rooms.
2. Using kick command when not enabled causing permanent bans.
3. Whispering not working with users that have numbers as their username.
4. Triggering bot responses on whispers and other commands.

Read the rest of this update entry...

 

[iraqiboy90]

Bug

On the All pages view mode:
- Use the website on a small screen, i.e. Samsung phone
- Open the chat. Works normal.
- Write something and submit = works normal*
- Close the chat and reopen it = problem. Parts of the content becomes below the editor.

*Not always. On my actual mobile, when the keyboard shows up, the issue happens.

 

[SoeHoe]

Bug

On the All pages view mode:
- Use the website on a small screen, i.e. Samsung phone
- Open the chat. Works normal.
- Write something and submit = works normal*
- Close the chat and reopen it = problem. Parts of the content becomes below the editor.

*Not always. On my actual mobile, when the keyboard shows up, the issue happens.


View attachment 124015 View attachment 124016

@Siropu Please check this bug

 

[iraqiboy90]

@Siropu Please check this bug

He is already on it
He made a fix that works on the phone emulator on PC browsers, but he needs to test it on an actual phone, because a 480x800 on a Samsung Galaxy S2 is not the same size on the emulator. They have different ppi
Also a phone browser has other factors that makes this issue even worse; the header while scrolling up and the keyboard

 

[SoeHoe]

@Siropu, Time limit Bot response works great, thanks

Need some options please:
1. @ sign at Bot response, please remove it or add an option to exclude it.
2. No avatar in front of username when tagging. can you please add an option for it?

Thanks

 

[Blast]

Is it possible for the username styles show up in the chat archive as well? It's so hard to read everything with no formatting.

 

[naia]

@Siropu

Chat ignore no longer works. They get added to the ignore list in user preferences, but ultimately messages are not ignored in chat.

 

[Siropu]

@SoeHoe, the avatar in user tagging is not a default XF option. You can use css to hide it if you know the class used.
@Blast, the method used is rich usernames but for some reason has stopped working. Will investigate.
@Shiro, found the problem, will be fixed in the next release.

 

[Lemminator]

@Siropu

i have some error after uploading files ... i can't use the xml because i become this error :

Parse error: syntax error, unexpected '>' in /www/htdocs/w01263e7/elnino-onlinegaming.de/library/Siropu/Chat/Model/Extend/Cron.php on line 24

 

[Siropu]

Try re-uploading the latest files.

 

[Lemminator]

you mean version 1.21.4