Joe Link
Well-known member
Works great, thank you!
I'm running into another issue now. When I enable the Hide affiliate URL option it opens two tabs (instead of just one). It works correctly without that option enabled.
Ads Manager 2 by Siropu [Paid] 2.4.22
- Thread starter Siropu
- Start date
I'm running into another issue now. When I enable the Hide affiliate URL option it opens two tabs (instead of just one). It works correctly without that option enabled.
Siropu
Well-known member
I have tested it using Chrome, Firefox, Opera and Vivaldi and it is working fine. What browser are you using?
taqib
Member
Siropu
Well-known member
Siropu updated Ads Manager 2 by Siropu with a new update entry:
Bug Fixes
Read the rest of this update entry...
Bug Fixes
Read the rest of this update entry...
@Siropu ,
I would like to make you aware of a problem with the AdManager, sending strong negative signals to the Google algorythm. Goole has introduced the CLS (cumulative layout shift) factor in 2019, which meanwhile has become a strong signal for their algorythms and the ranking of websites, primarly since with a layout shift they assume it could be related to click fraud or fraud itself. Read more about it here: https://web.dev/cls/ .
With the activation of lazyload on my website I had to notice, that Google sanctioned and downranked all of my pages from good to a bold bad. Lazyload is a legit and helpful tool, to reduce loading times and bandwith. And even the implementation you´ve done, is appealing. But since Google is misinterpreting lazyload, at this moment AdManager users will be forced to deactivate the lazyload option, else they will see an impact in their rankings. Of course noone wants that - wether the impact, nor the loss of lazyload.
A suggestion:
As far as it was possible to investigate, Google meassures the CLS in the viewport. And there only. The AdManager fires lazyload at exact that point, when the lazyload triggerpoint becomes availabe in the viewport, leading to the layout shift - again - in the viewport.
That in mind it seems feasable, to avoid the layout shift in the viewport without beeing forced to ditch the use of lazyload. Google wouldn´t mind when there would be a lazyload trigger in the viewport, which - when reached - fires the lazyload below (or above) the viewport. That way scrolling down a page would first make the trigger available in the VP, firing the script to load the upcoming ad outside of it and would prevent a layout shift inside the viewport, counting as a CLS-error. Since visitors can jump to the last answer and then, checking for previous posts in a thread, scroll the opposite direction upwards, it would need one trigger for each scroll direction (in total 2 for each lazyload ad).
Is there any chance you could adress the CLS problem with an implemantation like this?
I would like to make you aware of a problem with the AdManager, sending strong negative signals to the Google algorythm. Goole has introduced the CLS (cumulative layout shift) factor in 2019, which meanwhile has become a strong signal for their algorythms and the ranking of websites, primarly since with a layout shift they assume it could be related to click fraud or fraud itself. Read more about it here: https://web.dev/cls/ .
With the activation of lazyload on my website I had to notice, that Google sanctioned and downranked all of my pages from good to a bold bad. Lazyload is a legit and helpful tool, to reduce loading times and bandwith. And even the implementation you´ve done, is appealing. But since Google is misinterpreting lazyload, at this moment AdManager users will be forced to deactivate the lazyload option, else they will see an impact in their rankings. Of course noone wants that - wether the impact, nor the loss of lazyload.
A suggestion:
As far as it was possible to investigate, Google meassures the CLS in the viewport. And there only. The AdManager fires lazyload at exact that point, when the lazyload triggerpoint becomes availabe in the viewport, leading to the layout shift - again - in the viewport.
That in mind it seems feasable, to avoid the layout shift in the viewport without beeing forced to ditch the use of lazyload. Google wouldn´t mind when there would be a lazyload trigger in the viewport, which - when reached - fires the lazyload below (or above) the viewport. That way scrolling down a page would first make the trigger available in the VP, firing the script to load the upcoming ad outside of it and would prevent a layout shift inside the viewport, counting as a CLS-error. Since visitors can jump to the last answer and then, checking for previous posts in a thread, scroll the opposite direction upwards, it would need one trigger for each scroll direction (in total 2 for each lazyload ad).
Is there any chance you could adress the CLS problem with an implemantation like this?
Thanks, mate.
teletubbi
Well-known member
Yes I am using the carousel feature.
And no it don't happen during the update.
Was working like before. This came suddenly without any change to the forum.
The carousel I use in desktop mode for the header.
In mobile mode the carousel is used for all the banners to rotate on top of the page.
And no it don't happen during the update.
Was working like before. This came suddenly without any change to the forum.
The carousel I use in desktop mode for the header.
In mobile mode the carousel is used for all the banners to rotate on top of the page.
Siropu
Well-known member
There was an issue with the carousel on the previous version where the CDN for the carousel script worked intermittently but it should work now.
Make sure that there are no outdated templates and the carousel device options are checked accordingly.
As for the errors, I don't understand how they can happen over night. Those errors suggest that the template functions added by the add-on simply stopped working which doesn't make any sense.
Make sure that there are no outdated templates and the carousel device options are checked accordingly.
As for the errors, I don't understand how they can happen over night. Those errors suggest that the template functions added by the add-on simply stopped working which doesn't make any sense.
teletubbi
Well-known member
There are no outdated templates.
I also don't change any settings with this Addon.
Was working before with the same version.
Had to switch it of because it fills my log with this 2 errors and mess up the forum as in the picture
Try already to rebuild the Addon. No change in behavior.
First error:
Second error:
I also don't change any settings with this Addon.
Was working before with the same version.
Had to switch it of because it fills my log with this 2 errors and mess up the forum as in the picture
Try already to rebuild the Addon. No change in behavior.
First error:
Second error:
Siropu
Well-known member
I have checked your site and you have an issue with jquery which might cause the carousel not to function.. You are loading two version of jquery, one older 1.5 and the one that comes with XF.
Remove this:
As for the errors, template filers and functions are applied by XF so I have no idea why you get those errors, unless the code event listener for templater_setup has been disabled.
Remove this:
Code:
<script type="text/javascript" src="http://ajax.googleapis.com/ajax/libs/jquery/1.5.0/jquery.min.js"></script>As for the errors, template filers and functions are applied by XF so I have no idea why you get those errors, unless the code event listener for templater_setup has been disabled.
teletubbi
Well-known member
I changed now the source from Google to local.
Removed also the line of code. Was in a widget.
Did not change anything.
Same error and same behavior for the banner.
I did not disable something like this since I don't even know this.
Removed also the line of code. Was in a widget.
Did not change anything.
Same error and same behavior for the banner.
Where can I check this?
I did not disable something like this since I don't even know this.
Last edited:
Siropu
Well-known member
What I'm trying to say is that you are using 2 jquery versions at the same time.
