Ads Manager 2 by Siropu [Paid] 2.4.22

[Siropu]

can you add support Mobile Experience to use responsive ads for mobile.

What do you mean?

 

[Nirjonadda]

What do you mean?

Ads are out of the style and not responsive ads for mobile. Ads code banner size (728x90 Leaderboard)

 

[Nirjonadda]

CSS in extra.less are not fixing.

.ad-responsive {
max-width: 100%;
height: auto;
}

 

[Siropu]

It depends on what kind of ads you are using. Some ads are not responsive.

 

[briansol]

Hi, just installed.... got a few ads up without issue so it's working good.

I am not, however, able to see the links to the ad manager from a user perspective to purchase. I've played with all the settings to have the link to purchase a package show on the nav bar, but i never get the option.

I am using the s3 cache mod: (https://xenforo.com/community/threa...n-s3-for-file-storage-in-xf-2-x.156282/page-9)
any chance there's an issue with using that external cache?

I have a local, non-s3, navigation_cache.php in my internal_data/code_cache/ folder that if i delete, things break. i haven't been able to determine if it's because of the s3 cache or otherwise.

I've rebuilt templates, and added a new style without parent to test, and it's not fixed.
rebuilding updated that file as well, so i don't think it's related afterall.

any ideas?

 

[Siropu]

You have to enable "Enable user Ads Manager" in admin options for advertisers and set the user group permission to create ads.

 

[clackey]

I am getting some errors in the server error log since upgrading to the latest version today...

• TypeError: Argument 3 passed to Siropu\AdsManager\Listener::Siropu\AdsManager\{closure}() must be an instance of XF\Entity\User, null given
• src/addons/Siropu/AdsManager/Listener.php:425
• Generated by: Funsmith1
• Apr 15, 2020 at 3:51 PM

 

[briansol]

missed the user group permissions. thanks, that fixed it.

 

[briansol]

also, feature request,

can the source of the geo data file be changed to data/ instead of:
src/addons/Siropu/AdsManager/Vendor/MaxMind

so that it can also be offloaded to s3 with that data mod? it's a large file that i'd rather have off in s3 land.

 

[nocte]

I am getting some errors in the server error log since upgrading to the latest version today...

me too.

 

[Siropu]

Siropu updated Ads Manager 2 by Siropu with a new update entry:

Bug Fixes

Fixed an issue where email ads are displayed in both positions when you set it to only one.
Fixed an issue where you get an error if the user entity is not available in the email container.

Read the rest of this update entry...

 

[clackey]

Thanks. New version seems to fix the email above/below issue. Is there any way to get the ads to center in the emails? The center "unit alignment" doesn't seem to work and I assume CSS won't work in email either.

 

[Siropu]

You can try the inline style setting. margin: 0 auto; or text-align: center;

 

[clackey]

You can try the inline style setting. margin: 0 auto; or text-align: center;

No luck on those. Which template does this code exist? I'll try and add something there to center it.

 

[Siropu]

Try adding width: 100%; as well.
If that doesn't work, try to edit the siropu_ads_manager_ad_macros Email template.

 

[clackey]

Try adding width: 100%; as well.
If that doesn't work, try to edit the siropu_ads_manager_ad_macros Email template.

Got it. Had to add <center></center> to the proper line in siropu_ads_manager_ad_macros template.
Thanks again!

 

[briansol]

anyone get epn rewrites working? not sure on the syntax to get rover. subdomain in there. did you set up a custom callback?

 

[clackey]

I noticed that the new email option doesn't take into consideration the user group permissions. I have premium (paid) members who don't see ads but they still get them in the emails. I can probably change some code in the templates but thought you might want to add it at some point.

 

[Siropu]

I don't know how I missed that but if you re-download the latest version and rebuild add-on data, it should be ok.

 

[duderuud]

Upgraded to latest version a few days ago.

I think that is causing the following problem, ads are over the normal layout in the mobile view.
Header:


Footer:


In our custom style we have the same problem.
Any idea what is causing this?