Ads Manager 2 by Siropu [Paid] 2.4.19

Michael Bergheim · Dec 10, 2021

I have error, when i try to update

Code:

ParseError: syntax error, unexpected identifier "interval" src/addons/Siropu/AdsManager/Setup.php:61
Generiert von: admin10. Dezember 2021 um 15:16
Stack-Trace
#0 src/vendor/composer/ClassLoader.php(428): Composer\Autoload\includeFile('sr...')
#1 src/XF/AddOn/AddOn.php(455): Composer\Autoload\ClassLoader->loadClass('Siropu\\AdsManag...')
#2 src/XF/Job/AddOnInstallBatch.php(236): XF\AddOn\AddOn->checkRequirements(Array, Array)
#3 src/XF/Job/AddOnInstallBatch.php(87): XF\Job\AddOnInstallBatch->stepPreAction(Object(XF\Timer))
#4 src/XF/Job/Manager.php(260): XF\Job\AddOnInstallBatch->run(8)
#5 src/XF/Job/Manager.php(202): XF\Job\Manager->runJobInternal(Array, 8)
#6 src/XF/Job/Manager.php(118): XF\Job\Manager->runJobEntry(Array, 8)
#7 src/XF/Admin/Controller/Tools.php(122): XF\Job\Manager->runByIds(Array, 8)
#8 src/XF/Mvc/Dispatcher.php(352): XF\Admin\Controller\Tools->actionRunJob(Object(XF\Mvc\ParameterBag))
#9 src/XF/Mvc/Dispatcher.php(259): XF\Mvc\Dispatcher->dispatchClass('XF:Tools', 'RunJob', Object(XF\Mvc\RouteMatch), Object(XF\Admin\Controller\Tools), NULL)
#10 src/XF/Mvc/Dispatcher.php(115): XF\Mvc\Dispatcher->dispatchFromMatch(Object(XF\Mvc\RouteMatch), Object(XF\Admin\Controller\Tools), NULL)
#11 src/XF/Mvc/Dispatcher.php(57): XF\Mvc\Dispatcher->dispatchLoop(Object(XF\Mvc\RouteMatch))
#12 src/XF/App.php(2351): XF\Mvc\Dispatcher->run()
#13 src/XF.php(517): XF\App->run()
#14 admin.php(13): XF::runApp('XF\\Admin\\App')
#15 {main}

Marcel Broekema · Dec 10, 2021

Only errors when updating from 2.4.6 to 2.4.7:

ParseError: syntax error, unexpected 'interval' (T_STRING) in src/addons/Siropu/AdsManager/Setup.php at line 61

Composer\Autoload\includeFile() in src/vendor/composer/ClassLoader.php at line 428
Composer\Autoload\ClassLoader->loadClass()
spl_autoload_call() in src/XF/AddOn/AddOn.php at line 455
XF\AddOn\AddOn->checkRequirements() in src/XF/Job/AddOnInstallBatch.php at line 236
XF\Job\AddOnInstallBatch->stepPreAction() in src/XF/Job/AddOnInstallBatch.php at line 87
XF\Job\AddOnInstallBatch->run() in src/XF/Job/Manager.php at line 260
XF\Job\Manager->runJobInternal() in src/XF/Job/Manager.php at line 202
XF\Job\Manager->runJobEntry() in src/XF/Job/Manager.php at line 118
XF\Job\Manager->runByIds() in src/XF/Admin/Controller/Tools.php at line 122
XF\Admin\Controller\Tools->actionRunJob() in src/XF/Mvc/Dispatcher.php at line 352
XF\Mvc\Dispatcher->dispatchClass() in src/XF/Mvc/Dispatcher.php at line 259
XF\Mvc\Dispatcher->dispatchFromMatch() in src/XF/Mvc/Dispatcher.php at line 115
XF\Mvc\Dispatcher->dispatchLoop() in src/XF/Mvc/Dispatcher.php at line 57
XF\Mvc\Dispatcher->run() in src/XF/App.php at line 2351
XF\App->run() in src/XF.php at line 517
XF::runApp() in admin.php at line 13

Nirjonadda · Dec 10, 2021

@Siropu Getting error from 2.4.7 update.

Siropu · Dec 10, 2021

Somehow, some unwanted data (text) ended up in the setup file when I updated it. I have re-uploaded the file and should be ok now if you re-download it.

Marcel Broekema · Dec 10, 2021

Great, works ok now!

interforo · Dec 10, 2021

Why what do you recommend to avoid slowness caused by adv? My forum interfans.org/forum has terrible google rating https://pagespeed.web.dev/report?url=https://Interfans.org/forum&hl=en

Siropu · Dec 10, 2021

interforo said:
Why what do you recommend to avoid slowness caused by adv?

If you have ads that load very slow, then you can use the "Enable lazy loading" feature in code ads.

interforo · Dec 10, 2021

Siropu said:
If you have ads that load very slow, then you can use the "Enable lazy loading" feature in code ads.

I did but nothing changed

Siropu · Dec 11, 2021

interforo said:
I did but nothing changed

So you have checked the code ad setting "Enable lazy loading" and page still loads slow? That cannot be because of the ads since with that setting, ads are loaded after the page is loaded.

interforo · Dec 11, 2021

Siropu said:
So you have checked the code ad setting "Enable lazy loading" and page still loads slow? That cannot be because of the ads since with that setting, ads are loaded after the page is loaded.

yes option is enabled but forum is still slow because of the ads

Check please

forum: https://interfans.org/forum/
Report: link

bzcomputers · Dec 11, 2021

interforo said:
Check please

As I mentioned before...https://xenforo.com/community/threads/forum-slow-and-crashes.200606/post-1549383

It is not the actual ads that are slowing your site, it is the multiple ad services and their scripts loading on every page along with other issues I mentioned.

interforo · Dec 11, 2021

bzcomputers said:
As I mentioned before...https://xenforo.com/community/threads/forum-slow-and-crashes.200606/post-1549383

It is not the actual ads that are slowing your site, it is the multiple ad services and their scripts loading on every page along with other issues I mentioned.

What should I do then? I am a beginner and don't know much...I need specific help (are you available for a zoom session?)

bzcomputers · Dec 11, 2021

interforo said:
What should I do then? I am a beginner and don't know much...I need specific help (are you available for a zoom session?)

I can't help right now, but someone with decent server administration knowledge/experience should be able to help you.

Check out @MattW - https://xenforo.com/community/threa...k-server-configuration-hosting-support.61392/

Siropu · Dec 11, 2021

interforo said:
yes option is enabled but forum is still slow because of the ads

It is not. And some JS scripts are already in the page source.

interforo · Dec 11, 2021

Siropu said:
It is not. And some JS scripts are already in the page source.

Well have a look at the ss please

Siropu · Dec 11, 2021

interforo said:
Well have a look at the ss please

That's the admin option for banner images. I'm talking about the code ad setting when you create/edit a code ad. If you don't have it, you are using an older version.

interforo · Dec 11, 2021

Siropu said:
That's the admin option for banner images. I'm talking about the code ad setting when you create/edit a code ad. If you don't have it, you are using an older version.

So you mean for every ad position I should add the lazy loading feature?

Siropu · Dec 11, 2021

Enable it for each ad. It looks like this:

interforo · Dec 11, 2021

Siropu said:
Enable it for each ad. It looks like this:

View attachment 261770

I have enabled it now for all the ad position.
However banners after 1st post, second and third now are NOT showing anymore

Storie, Anti-storie, Fanta-storie.

Un thread per discutere di Storia con la S, ma al plurale, perché in realtà sono tante, innumerevoli. Seriamente o scherzandoci sopra, non fa differenza. Ma anche di Storia Alternativa "Cosa sarebbe successo se...?" Ma anche di Storia nella fiction, tipo "Strategie in The Lord of the Rings o A...

interfans.org

I think I have just found out a bug!
Lazy loading if enable don't work for ad position in between posts

Siropu · Dec 11, 2021

interforo said:
However banners after 1st post, second and third now are NOT showing anymore

The ad content is loaded into the page but you have a global JS script in the head of the page that executes before that. You can try loading both the script and the ad element in the same ad, using lazy loading.

Ads Manager 2 by Siropu [Paid] 2.4.19

Member

Member

Well-known member

Well-known member

Member

Active member

Well-known member

Active member

Well-known member

Active member

Well-known member

Active member

Well-known member

Well-known member

Active member

Attachments

Well-known member

Active member

Well-known member

Active member

Well-known member

Similar threads

We value your privacy