s9e Media Sites 2.15.5

[JoshyPHP]

Yeah, not much we can do about Medium really. There are 3 things that make this screenshot suck:

• There are two logos in the top left. Looking at the markup, one of them has a hide CSS class but there's no corresponding CSS declaration to actually hide it.
• Black logo and white text over a dark background with white text. That one's partly on the author for choosing a bad "hero" image.
• There's a white band at the bottom. That's because the iframe's size is fixed whereas the content is never exactly the same height. There are ways to make the iframe's size dynamic so it's an exact fit and I might just do that. It won't help with readability though.

 

[JoyFreak]

I found this happening on mobile in thread_view, particularly in this thread (not sure if there's more) but I also looked on desktop with the console. Here's a screenshot and a link to the thread.

Wild Terra Online 2: New Lands - An Indie MMORPG in Development

Who knows about Wild Terra Online 2: New lands? This is a new game in alpha stage of development recently released. I've been keeping track of this game and being part of development. I wanted to share it because I think people who like this kind of games (as I do) will find it interesting, the...

www.joyfreak.com

Make sure to refresh so the spacing occurs. Thanks!

It seems to only be happening on threads with steam links? When I hide the steam embeds, the problem goes away after a tiny bit.

 

[JoshyPHP]

What's the issue? I can't tell based on that screenshot.

 

[JoyFreak]

What's the issue? I can't tell based on that screenshot.

Space on the right side on mobile.

See the bottom scroller? It shouldn't be like that. It should all fit on screen. Its related to steam embeds.

 

[JoshyPHP]

I've looked at this layout and I can reproduce it through Chromium's mobile simulator but I don't know what would cause the page to become wider. I don't think the Steam embed can. Imgur would be a more likely candidate but I suspect it requires a specific interaction with the style's CSS.

Try switching to XenForo's default style to see if it behaves the same way. If it doesn't, report the issue to the style's authors and tag me so I can follow the discussion.

 

[JoyFreak]

I've looked at this layout and I can reproduce it through Chromium's mobile simulator but I don't know what would cause the page to become wider. I don't think the Steam embed can. Imgur would be a more likely candidate but I suspect it requires a specific interaction with the style's CSS.

Try switching to XenForo's default style to see if it behaves the same way. If it doesn't, report the issue to the style's authors and tag me so I can follow the discussion.

It behaves the same way on XenForo’s default style too. Just checked.

 

[JoyFreak]

I’m using an iPhone and it’s happening on Safari.

 

[JoshyPHP]

I can't reproduce it on a clean XenForo install. I tried a Steam embed and one of the Imgur video with the same result.

If you want to pinpoint the cause of the layout change, you can create a new thread and incrementally add various embeds and images until the scrollbar appears.

 

[JoshyPHP]

@JoyFreak If you edit your extra.less template to add this, it may fix the layout until a better workaround is available:

[data-s9e-mediaembed="imgur"] {
    max-width: 100% !important;
}

 

[JoyFreak]

@JoyFreak If you edit your extra.less template to add this, it may fix the layout until a better workaround is available:

[data-s9e-mediaembed="imgur"] {
    max-width: 100% !important;
}

Hey, that fixed it for now. Thank you!

 

[slothly]

Occasionally someone will post a reddit embed and it will come with this reaaaally broken code snippet below the headline:




Usually only happens with posts involving twitter media:

To view this content we will need your consent to set third party cookies.
For more detailed information, see our cookies page.

Accept third party cookies

 

[JoshyPHP]

It's a Reddit thing, they just fumbled their Twitter embed.

 

[slothly]

It's a Reddit thing, they just fumbled their Twitter embed.

Is there any way to hide the code? It's a bit distracting and happens frequently on my forum since my users post a lot from reddit.

 

[JoshyPHP]

No, it needs to be fixed on Reddit's side.

 

[kella]

Any chance you could add getyarn.io? Like a real playable embed.

- God damn it! - I knew it was you all along Richard Nixon!

South Park (1997) - S02E03 Comedy clip with quote - ******** it! - I knew it was you all along Richard Nixon! Yarn is the best search for video clips by quote. Find the exact moment in a TV show, movie, or music video you want to share. Easily move forward or backward to get to the...

getyarn.io

 

[JoshyPHP]

No, I've looked them up before and based on their Alexa ranking they don't seem to be particularly popular or growing so I don't have any plans to add support for the sites in the foreseeable future unless someone wants to sponsor its development. If that's your case, you can start a conversation and I'll look into it.

 

[Chromaniac]

so this is regarding the youtube thingy. just a thought. if it would not take much of your time...

would it be possible for s9e to log a hit in the oembed log whenever it fetches the youtube title from the database? basically, the oembed log has become a good place for me to locate dead youtube videos on my board. populated hits column would make it easier to locate dead videos in popular threads as i can use the sort function and go through the logs whenever i have some time to kill. cheers!

 

[JoshyPHP]

I should mention that s9e is only the name of the namespace I use for the add-on. Technically the add-on is named s9e/MediaSites although I rarely use it in posts.

I intentionally do not keep the oEmbed log up to date, purely for performance reasons. XenForo's oEmbed service updates entries separately so a page with a dozen videos would cause a dozen database updates. Even if I were to batch those updates to have a single write per page, I believe the traffic from bots alone would be enough to have a measurable impact on the table's performance.

I do see the value in keeping track of dead videos (or popular videos for that matter) so if I were to change the way I use oEmbed that's something I would take into consideration.

 

[Chromaniac]

That makes sense thanks!

 

[JoshyPHP]

Come to think of it, as per the yet-unreleased version 2.6.3 of the add-on you should be able to find which YouTube videos have reached the maximum amount of retries (which is set to 10) with something like that:

SELECT * FROM xf_oembed WHERE media_site_id = 'youtube' AND title IS NULL AND fail_count >= 10