s9e Media Sites 2.15.5

[JoshyPHP]

They're not working and apparently they removed their player, probably in their May 22 update.

I don't think there will be an upgrade path from there, which means the media site will be removed and the one that comes with XenForo 2.x will be restored. The issue is the implementations differ and it may not be possible to display old embeds.

 

[JoshyPHP]

On second thought, as I recall XenForo has a good upgrade procedure so I should be able to fix old embeds during the upgrade. It's going to take some time to research the relevant XenForo API though.

 

[hibiskus]

I don't see anything served over HTTP. If you get the "not secure" warning, check out your browser's developer tools and look for anything served over HTTP rather than HTTPS. I'm fairly certain it will not be an embed from this add-on, though.

I am really confused i am not able to reproduce it fully like before but nearly, here you can see "thumbnail" from article preview is in http: but also in https: ? oO

Screenshot

Captured with Lightshot

prntscr.com

Then what i can reproduce good and noticed first today, but i am not sure if it is caused by your add-on or XenForo core, Youtube gets embedded with http:? oO

Screenshot

Captured with Lightshot

prntscr.com

 

[JoshyPHP]

The box that shows that thumbnail is not part of this add-on, it's from XenForo's "Unfurl" feature.

The link from the second screenshot is inside a <noscript> element so it shouldn't be displayed. I don't think it will trigger the mixed-content warning but I don't know for sure. Either way, that's something that only the YouTube people can change. The embed itself, as well as the background image from YouTube are served via HTTPS, so that part is fine.

 

[Gossipy]

@JoshyPHP - great job with this; just sent a donation! I have a question, it relates to Imgur embeds in an IMG tag. I posted it in detail in another thread:

We recently upgraded and I'm seeing the following behavior.

When a user wishes to insert an image into a post that they had uploaded to Imgur, they typically would (on the Imgur page for the image) click "Get Share Links", then "BBCode (Forums)" and copy/paste that BBCode - this is what we've taught them to do.

But lately it seems Imgur is not providing BBCode that directly links to the image. They chop off the filename extension and link to an Imgur html page, so they'll give:

[img]https://imgur.com/yRIJwh8[/img]

instead of

[img]https://imgur.com/yRIJwh8.jpg[/img]

Our 1.5 install was overcoming this somehow and showing the image inline. I'm not sure if it was one of our plug-ins or if it was native.

But now, with 2.1, if a user pastes:

[img]https://imgur.com/yRIJwh8[/img]

The image doesn't load. It makes perfect sense why it doesn't load and I suppose we'll have to re-train our users on this. But if anyone has any ideas I'm all ears. I can't think of an easy way to fix this (unless Imgur changes their code) because you'd have to have a way to tell (via plug-in or a BBCode Media sites setting) if it's a PNG, GIF, JPG, etc. before rewriting the BBCode.

Thoughts?

But in a nutshell Imgur isn't giving people the full image path anymore when they provide the "Forum BBCode" sharing link (they remove the file extension). Is there any way to fix that issue with your plug-in?

Keep up the great work!

 

[Chromaniac]

imgur still provide bbcode... they just make it annoying to access.

one way is to get your members to stop using the IMG bbcode for imgur links. s9e would embed them automatically. i have faced the same issue on my forum and i have to clean up messy bbcode with imgur page links regularly.

i can also recommend vgy.me as an alternative image hosting service which provide clear access to bbcode but sites like these do not last for long.

 

[Gossipy]

imgur still provide bbcode... they just make it annoying to access.

No, that's not correct. Have you actually tried it? If you paste the given BBCode into a Xenforo post, you will get a broken image (red x). That's because it's giving an IMG code but within it is an HTML page.

Imgur now provides this to users:

 [img]https://imgur.com/yRIJwh8[/img]

Which gives a broken image:

It should actually be:

 [img]https://imgur.com/yRIJwh8.jpg[/img]

Which results in expected behavior:

 

[JoshyPHP]

@JoshyPHP - great job with this; just sent a donation! I have a question, it relates to Imgur embeds in an IMG tag. I posted it in detail in another thread

Thanks for the donation, it is greatly appreciated. About Imgur, that's an interesting case. I don't remember doing anything in the 1.5 add-on that would have allowed generic Imgur links to be used in an IMG tag. It's theoretically possible that Imgur used to detect that the page was requested as an image (by inspecting the Accept header) but to be honest that doesn't sound like Imgur.

There is a silver lining however. You don't have to know an image's extension to link to it because it appears that Imgur provides its own content negotation. For instance, the following will produce the same result:

[img]https://imgur.com/yRIJwh8.png[/img]
[img]https://imgur.com/yRIJwh8.jpg[/img]

That means you could fix old posts using the Post Content Find / Replace add-on with the following settings:

Quick find:         [IMG]https://imgur.com/
Regular expression: (\[IMG\]https://imgur\.com/(\w+)\[/IMG\])
Replacement string: [IMG]https://i.imgur.com/$1.jpg[/IMG]

imgur still provide bbcode... they just make it annoying to access.

Now that sounds more like the Imgur I know. Maybe it's worth creating a small add-on just to automatically fix bad copy/paste from Imgur.

 

[Chromaniac]

without image extension, bbcode would break everywhere. i am seeing correct bbcode on their website!

 

[Chromaniac]

are you sure you copied this code [img]https://imgur.com/yRIJwh8[/img] from imgur website?

it is very likely that your users are copying the url imgur provides https://imgur.com/yRIJwh8 and they press the image button in the editor toolbar and try to post it like an image. i have seen this happen on my forum. though this should also not work because xenforo tries to load the image before inserting it in post content so there's that would generate an error like this:

 

[Gossipy]

Thanks for the donation, it is greatly appreciated. About Imgur, that's an interesting case. I don't remember doing anything in the 1.5 add-on that would have allowed generic Imgur links to be used in an IMG tag. It's theoretically possible that Imgur used to detect that the page was requested as an image (by inspecting the Accept header) but to be honest that doesn't sound like Imgur.

There is a silver lining however. You don't have to know an image's extension to link to it because it appears that Imgur provides its own content negotation. For instance, the following will produce the same result:

[img]https://imgur.com/yRIJwh8.png[/img]
[img]https://imgur.com/yRIJwh8.jpg[/img]

That means you could fix old posts using the Post Content Find / Replace add-on with the following settings:

Quick find:         [IMG]https://imgur.com/
Regular expression: (\[IMG\]https://imgur\.com/(\w+)\[/IMG\])
Replacement string: [IMG]https://i.imgur.com/$1.jpg[/IMG]

Now that sounds more like the Imgur I know. Maybe it's worth creating a small add-on just to automatically fix bad copy/paste from Imgur.

Oh that is helpful. I wonder is it possible in your add-on to replace Imgur BBCode "if no extension", add extension (jpg or png)?

without image extension, bbcode would break everywhere. i am seeing correct bbcode on their website!

This is so weird. I am not being given the extension.

I just went there, uploaded a random picture. I clicked "get share links"



And this is what I was given:



Bizarre........

 

[Gossipy]

are you sure you copied this code [img]https://imgur.com/yRIJwh8[/img] from imgur website?

it is very likely that your users are copying the url imgur provides https://imgur.com/yRIJwh8 and they press the image button in the editor toolbar and try to post it like an image. i have seen this happen on my forum. though this should also not work because xenforo tries to load the image before inserting it in post content so there's that would generate an error like this:

View attachment 203907

I'm 1000% sure. I've tried it myself several times. Also, see what just posted a minute ago. Strange.

 

[Chromaniac]

yeah. your screenshot is pretty interesting.

 

[Gossipy]

yeah. your screenshot is pretty interesting.

I believe it's resulting from using their "beta" uploader.

To re-create:

• Visit https://imgur.com
• Click the green "New Post" button in upper-left
• It launches their new uploader (imgur dot com/upload?beta)
• Upload image
• Click "get share links"
• Get broken BBCode

 

[Chromaniac]

ok. can confirm. https://imgur.com/upload?beta is generating broken bbcodes.

i have filed a bug report here: https://help.imgur.com/hc/en-us/requests/new. i am not sure if these are taken seriously though.

 

[rootsxrocks]

Thank you for the work on this add on, I just installed it and have been testing the sites by pasting the samples into post.
Some may not be working as expected now if they did before.
the A's did fine Particularly the Amazon affiliates are awesome, have not tried them with an ad blocker.
when I got to the B's
bleacherreport just unfurled, no biggy Not a media site that is important to our comunity.
break Not sure the sample URL "https://www.break.com/video/video-game-playing-frog-wants-more-2278131" is no longer avalible and a short search found most of the content on Break is youtube embeds.
Now I get to the C's and the first real problem
cbsnews Auto plays , I don't want any auto-play content with sound (gifs, webm and OGV are acceptable )
cnbc seems to make a placeholder but its blank
CNN same blank placeholders but I think I saw it embed the first time I posted it, just on refresh it don't show.
CNNMoney



collegehumor shows a blank black box no link
Comedy central one unfurled others just linked
coub worked fine, just caught in the screen cap.
the D's worked as expected
ESPN unfurled no embed

continuing on to check F's ~ will update with others that were included and are not working. I do have FFMPEG installed on the server if that matters, I used it so I can host Webm and Ogg video and it works

Fox News auto plays
fox sports Not found
funny or die sample video not found, I looked for another that was not a YT embed on F or D but didn't find one to test it

 

[rootsxrocks]

Gamespot made a notification request pop up from the embedded media
Google Plus is discontinued
healthguru.com appears to be no longer
IMDB.com Auto plays
Hulu not sure if any content is embedable now
humortv.vara.n huge cookie notice embedded does not work, redirected to new URL
Note, after I had visited the site and accepted the cookie notice in 3 languages it now works
Indie GOGo

izlesene.com

 

[JoshyPHP]

@rootsxrocks That's a long list so I'll address it generally and I'll have to circle back later for specifics, where applicable.

The truth about embeddable content is that it often stops functioning. Sometimes temporarily, sometimes permanently. Apart from the unit test suite I run as part of the library that generates them, I rarely check them proactively and only fix them after somebody notices that it doesn't work anymore. Many websites rot as fewer and fewer people use them.

I've checked the first few sites from your list. I presume that you can't see some of them because they use a Flash player. I've updated a couple of them and looked into CNNMoney to find out about the Content Security Policy error, which specifically prevent their content from being embedded in a third-party website. Either they misconfigured their application or they decided to make their content un-embeddable and forgot to tell their front-end people. I left them a message but I don't expect a reply.

I'll take a look at the others as time allows.

PS: embeds are configured to not autoplay but the setting is not always respected or their implementation is buggy. CBSNews for example, has code to determine whether it should autoplay but the result is never used, that's why it always autoplays. It's blocked by my browsers though.

 

[rootsxrocks]

livecap DNS error
metacafe blank placeholder
mrctv not embedding
msnbc embeded but doesn't load
natgeochannel loads video then changes to other content

The Oinion emmbeded as above Blocked by Content Security Policy
TMZ and Tiny Pic placehold but blank, will try alt content as some others like this were just privacy changes and content deletion
vocaroo.com Flash perrmission
VOX


Everything else on the list appears to work as expected I see A reply since I started composing this

 

[rootsxrocks]

@rootsxrocks That's a long list so I'll address it generally and I'll have to circle back later for specifics, where applicable.

The truth about embeddable content is that it often stops functioning. Sometimes temporarily, sometimes permanently. Apart from the unit test suite I run as part of the library that generates them, I rarely check them proactively and only fix them after somebody notices that it doesn't work anymore. Many websites rot as fewer and fewer people use them.

I've checked the first few sites from your list. I presume that you can't see some of them because they use a Flash player. I've updated a couple of them and looked into CNNMoney to find out about the Content Security Policy error, which specifically prevent their content from being embedded in a third-party website. Either they misconfigured their application or they decided to make their content un-embeddable and forgot to tell their front-end people. I left them a message but I don't expect a reply.

I'll take a look at the others as time allows.

PS: embeds are configured to not autoplay but the setting is not always respected or their implementation is buggy. CBSNews for example, has code to determine whether it should autoplay but the result is never used, that's why it always autoplays. It's blocked by my browsers though.

LOL it was getting longer as I was doing part 2 whan you replied , I'm not complaining or even asking you fix them Just sharing what I found when I tested The install with all the sites you have listed in the txt file.
the auto play is the only one I really care about I will just delete those that are dead sites or behind a paywall now.