I've just pushed a tiny bugfix commit to that PR.
Yup. Signatures disable tags in their own snowflake way which isn't used elsewhere in the code base.
Yes. As Chromaniac said, IMDb probably gives you a German title because your server's IP is associated with a location in Germany. The way to fix it is to ask the IMDb server to return content in English using a
Accept-language: en-us, en header. However, the box you see when posting links is not from this add-on, this is a default XenForo feature called "unfurl." Armed with this information, your best course of action is to head to the feature request forum and ask for a way to set a Accept-language header when unfurl'ing, if there isn't already an option for that. In our age of distributed, geographically-diverse cloud servers, this should be useful.
vi-control.net
Unfortunately that's on Apple's side. There's an uncaught
DOMException caused by Apple's code that interrupts the player's loading. Basically, if your browser denies access to session storage, an error occurs and it stops loading. Session storage is usually tied to cookie preferences in browsers, so if you allow third-party cookies it should load properly. The player works fine for me in Chrome on a new profile with the default preferences, but fails to load in Incognito mode because it blocks third-party cookies.
Sorry for not handling it sooner. I looked into it and ended up with a slightly different fix than yours but I think it should effectively work the same. The overloaded
URL tags are always active and the add-on's option only affects the way URLs are converted, that's why those tags are always counted as MEDIA tags. I could add a secondary option to toggle that behaviour, but I'd like to keep the number of options to a minimum unless there's a practical use case for it. As long as the overloaded tags are identified as media embeds, there shouldn't be a need for it but of course I'll reconsider if I'm wrong.That looks like a better approach I ended up implementing, which was done fairly quickly.
You're right, looks like whatever computes the height of the quote has some issues with those embeds. For reference, there's a template modification
s9e_MediaSites_EmbedsInQuotes that shrinks default-sized embeds such as YouTube down to 270 × 151 inside of expandable quotes..is-expandable:not(.is-expanded) [data-s9e-mediaembed]
{
width: 270px;
transition: none;
}
gdpr.eu
