s9e Media BBCodes pack

s9e Media BBCodes pack 20231102

No permission to download
It's interesting, Imgur may be detecting that their ad script didn't load. It's not necessarily meant to annoy adblocking users, it may simply be a side-effect of the code that determines whether a given image exists.

Try completely disabling any adblocker, not just whitelisting the site. Or if you whitelist a site you may need to whitelist https://s9e.github.io (which executes Imgur's code) rather than your own.
 
Narrowing it down a little, one issue is the CLICK TO EXPAND for mobile users isn't displaying so they just see the top of the IG image.
 
I can see it (albeit inconsistently) on Google Chrome 70.0.3528.4, but not Chromium 69.0.3497.57. Apparently the album is embedded correctly at first using this URL. Then for some reason Imgur's script changes the iframe to that URL and there's a JavaScript error "Uncaught ReferenceError: _widgetFactory is not defined"

I don't know what to make of that. Wait, actually it may be something I control and be related to a workaround in place to make old embeds work in the new Imgur. I need to look into it.

@TXKeith I have updated the Imgur iframe and the "Zoinks" issue shouldn't happen anymore. On the other hand, some old embeds (from 2017 or earlier) may stop working. I'll work on a better fix asap.
 
Last edited:
In general, a screenshot of something that isn't there contains no usable information. Instead, I recommend posting actionable information such as the original URL, a link to a public page that displays the issue, the versions of browsers affected, any JavaScript error that appears in the browser's console, etc...

I receive a bunch of reports of issues related to Imgur and half the time it's because their site is unavailable or they misconfigured a server. Imgur embeds work for me on Firefox 61 with no extensions.
 
Last edited:
  • Like
Reactions: Xon
I still cant get this to work for any media :/

For example I tried to embed this just now:
http://www.cbc.ca/player/play/1318010435883/
specified url could not be embedded as media

then I tried another one:
https://abc7ny.com/video/embed/?pid=4219985

same result, can't be embedded.

I've only managed so far to embed 1 video from a media site out of 100s I've tried.

Please help
That's because neither of those sites are supported by this add-on.

The list of 120 supported sites is shown on the overview page for this resource and there is a link within the description to the complete list of URLs with examples that are supported.
 
The player does load in any of my browsers but it doesn't look like they provide embeds anyway, so I guess not.

I still cant get this to work for any media :/

As Martok mentioned, the list of sites is on the add-on's description page. There's a more detailed list of supported URLs at https://s9etextformatter.readthedocs.io/Plugins/MediaEmbed/Sites/
 
Any chance of supporting Vibby.com (or showing me how to add it as a custom entry)? It's fairly popular for video breakdowns and we use it on our site often for football.

Here's an example of a video we have: https://www.vibby.com/v/X1GvUYjzI

Thanks!
Ray

P.S. Loved your last FAQ line ; )
 
@JoshyPHP


Over the last couple of weeks, Instagram embeds have gone completely pear shaped.

The issue is the iframe is not auto adjusting for the correct height (see screen grab below).

Members are reporting the issue across all browsers across all devices and I'm able to replicate on Firefox, Chrome & Edge (desktop) as well as Safari on iOS.

A hard refresh sometimes resolves the issue - but not always.

If a page has many embeds - some may load to correct height whilst others will load to incomplete heights.

The issue remains even if I turn off the lazy-load option.

My se9 Media Pack add-on was a couple of minor versions behind when the issue was reported and have I updated to the latest version of your Media Pack - but the issue remains with no improvement.

The issue is also occasionally appearing with Twitter embeds but less consistently.

My Xenforo is v 1.5.22 with Themehouse UI.X theme (also v 1.5.22)

(note: when issue was first reported by members I was on XF 1.5.19 & UI.X 1.5.19 which had been stable for months with no new add-ons or other code changes).

View test thread here


181010 insta-fail.webp
 
As an aside, I note that your static array of all the sites has well over half with older 'http://' protocol

(eg. Instagram).

Code:
'instagram'=>array('Instagram','http://instagram.com/',array('social'=>1)

I did a quick straw test and every site I tested in the array now auto-redirects to https (TLS) protocol.

With Chrome 70 getting released within the next few weeks and all the browsers going completely nazi on insecure connections - having code with old obsolete protocols feels like code-bugs waiting to happen - irrespective of the fact that they auto-redirect at the moment just fine, why not update appropriately and save any potential future problems with Strict Transport Security issues?

imho, any site that is not offering secure embeds in 2018 should not be in the Media Pack at all.

thoughts ?
 
Over the last couple of weeks, Instagram embeds have gone completely pear shaped.

I spent some time inspecting your test page and I can confirm that the Instagram embeds behave unreliably with regarding to their dimensions.

The way the Instagram and similar embeds (e.g. Twitter) work goes like this:
  1. The embed loads in an iframe of fixed dimensions.
  2. Once the iframe is loaded, the host (the forum page) sends a message to the iframe to indicate it should report its height.
  3. The iframe sends a message back to the host to keep it updated with the correct height.
When you see an Instagram embed that is cut off, it means the host didn't receive a message with the proper height. In your case, I don't know exactly what interferes with communication. A good starting point would be to disable this add-on's lazy loading, disable the Lazy Load add-on and try the same page with XenForo's default theme. If it works, try the same page with UI.X, then try with the Lazy Load add-on re-enabled.

Wrt http:// URLs, I infrequently update old URLs to point to their https:// equivalent where available but it's generally low on my priority list because I have to do it manually and since most sites that support HTTPS automatically upgrade requests from clients that support it. I haven't done that in a while so I'll review the list of sites sometime soon.
 
The issue remains even if I turn off the lazy-load option.

I think you meant the Lazy Load add-on; This add-on has a lazy load option but I don't think they interfere with each other. I can replicate the same issue on my local board with UI.X and with the default theme. I still don't know exactly what's wrong but I believe it will work better if you disable the deferred loading in this add-on (not the Lazy Load add-on.) Go to your admin panel, go to Options > s9e Media Pack, scroll down and choose "Load embedded content immediately."
 
Top Bottom