Floyd R Turbo
Well-known member
I didn't know you could do this either, that's pretty slick. I've been thinking about installing this addon and I think this just pushed it over the edge!
s9e Media BBCodes pack 20231102
- Thread starter JoshyPHP
- Start date
JoshyPHP
Well-known member
It works for me so I guess you have an extension that blocks Flash videos or a browser that doesn't suppor them.
Ye its FF protection, not sure how to stop it tho.
JoshyPHP
Well-known member
JoshyPHP updated s9e Media BBCodes pack with a new update entry:
Added support for private tracks in SoundCloud
Read the rest of this update entry...
Added support for private tracks in SoundCloud
Read the rest of this update entry...
JackieChun
Well-known member
Thank you for a great addon. However, the Imgur integration is implemented incorrectly. Imgur provides several kinds of links, 3 of which are usable on forums: Share link, Direct, and BBCode (Forums).
I agree that when a Share link is used in a post, then the image should be embedded, including a link to the Imgur page, with an Imgur logo, etc.
However, when a user uses a "direct" link, the addon should either turn it into a BBCode/Forums link or just leave it alone as a URL. Instead, the addon turns it into the same as a "Share" link, which adds the unnecessary Imgur logo, etc, but the worst of all is that it uses javascript to display a plain image, which slows down performance on mobile browsers and unnecessarily wastes battery for mobile users.
Another unfortunate side effect is that if the forum owner turns off the add-on in the future, all image links will be ruined.
I hope you make an adjustment to address this issue.
I agree that when a Share link is used in a post, then the image should be embedded, including a link to the Imgur page, with an Imgur logo, etc.
However, when a user uses a "direct" link, the addon should either turn it into a BBCode/Forums link or just leave it alone as a URL. Instead, the addon turns it into the same as a "Share" link, which adds the unnecessary Imgur logo, etc, but the worst of all is that it uses javascript to display a plain image, which slows down performance on mobile browsers and unnecessarily wastes battery for mobile users.
Another unfortunate side effect is that if the forum owner turns off the add-on in the future, all image links will be ruined.
I hope you make an adjustment to address this issue.
JoshyPHP
Well-known member
@JackieChun If you post an example of those links (those that should be embedded and those that should not) I will definitely consider it.
JackieChun
Well-known member
Definitely slows down on the iOS version of Chrome (tested on an iPhone 6). Whenever you browse a thread with an embedded Reddit or Imgur post, things come to a screeching halt.
Edit: @JoshyPHP sent you a PM. Thanks!
JoshyPHP
Well-known member
Do you have an URL for such a thread? I'd like to see it in action to determine whether I can do anything about it.
That said, if you embed many videos or third party content on the same page, it will be slower than if the page had only text.
JackieChun
Well-known member
The Grand Potentate
Well-known member
@JoshyPHP I think the Daily Show code might need updating now that the show name has changed. This URL doesn't function:
http://www.cc.com/video-clips/2ybqd8/the-daily-show-with-trevor-noah-ben-carson-blames-the-victims
http://www.cc.com/video-clips/2ybqd8/the-daily-show-with-trevor-noah-ben-carson-blames-the-victims
JoshyPHP
Well-known member
JoshyPHP updated s9e Media BBCodes pack with a new update entry:
Fixed Comedy Central and GameTrailers
Read the rest of this update entry...
Fixed Comedy Central and GameTrailers
Read the rest of this update entry...
JoshyPHP
Well-known member
Actually it was a regression bug on my part. XenForo encodes ":" when used in video IDs and Comedy Central servers don't like it. I used to have a workaround for that issue until recently when I accidentally removed it. It's now fixed.
The Grand Potentate
Well-known member
JoshyPHP
Well-known member
JoshyPHP updated s9e Media BBCodes pack with a new update entry:
Updated Comedy Central and Imgur
Read the rest of this update entry...
Updated Comedy Central and Imgur
Read the rest of this update entry...
JoshyPHP
Well-known member
I have updated the iframes used to embed Reddit comments and Imgur content. It may help in your case but I don't have a Chrome/iOS combo to test it on so it's basically a stab in the dark.
I have updated the add-on to ignore links to static images. (links that end in ".jpg" or ".png")
That's a different issue. I have added support for embedding full episodes as well as video clips in the latest update.
The Grand Potentate
Well-known member
Works great as always. Thanks Joshy.
JackieChun
Well-known member
Thank you very much for responding to the feedback. I will test and report back.
I didn't mean to suggest that the add-on should ignore static images. The add-on can still automate embedding them, but at least in the case of Imgur, it makes more sense to minimize resource usage (by avoiding iframes and javascript) and simply add the img BBcode around static links.
