[Andrew] Moderator Panel

[Andrew] Moderator Panel 1.9.4

No permission to download
Overview FAQ Updates (37) Reviews (35) History Discussion
AndrewSimm said:
Is it slow when viewing banned users or any other page of the moderator panel?
Click to expand...
I did small modifications to sql queries here's my revision:
it works much faster now.
(still discouraged users panel slow cuz of COUNT query.) couldn't find a way to improve this.

gist.github.com

Build software better, together

GitHub is where people build software. More than 100 million people use GitHub to discover, fork, and contribute to over 420 million projects.
gist.github.com gist.github.com
 
leftspace89 said:
I did small modifications to sql queries here's my revision:
it works much faster now.
(still discouraged users panel slow cuz of COUNT query.) couldn't find a way to improve this.

gist.github.com

Build software better, together

GitHub is where people build software. More than 100 million people use GitHub to discover, fork, and contribute to over 420 million projects.
gist.github.com gist.github.com
Click to expand...
Thanks for doing this.

I do get this error on my local
Code: 
TypeError: Return value of Andrew\ModeratorPanel\Pub\Controller\ModeratorPanel::Andrew\ModeratorPanel\Pub\Controller\{closure}() must be an instance of XF\Entity\User, null returned in src/addons/Andrew/ModeratorPanel/Pub/Controller/ModeratorPanel.php at line 54
Andrew\ModeratorPanel\Pub\Controller\ModeratorPanel->Andrew\ModeratorPanel\Pub\Controller\{closure}()
array_map() in src/addons/Andrew/ModeratorPanel/Pub/Controller/ModeratorPanel.php at line 53
Andrew\ModeratorPanel\Pub\Controller\ModeratorPanel->actionIndex() in src/XF/Mvc/Dispatcher.php at line 352
XF\Mvc\Dispatcher->dispatchClass() in src/XF/Mvc/Dispatcher.php at line 259
XF\Mvc\Dispatcher->dispatchFromMatch() in src/XF/Mvc/Dispatcher.php at line 115
XF\Mvc\Dispatcher->dispatchLoop() in src/XF/Mvc/Dispatcher.php at line 57
XF\Mvc\Dispatcher->run() in src/XF/App.php at line 2351
XF\App->run() in src/XF.php at line 517
XF::runApp() in index.php at line 20

Looks like it doesn't like:
PHP: 
            //leftfix
            $finder = \XF::finder('XF:UserBan');
            $bannedusers_xfban = $finder
                ->with('User')
                ->order('ban_date', 'DESC')
                ->limit(10)
                ->fetch()->toArray();

            $bannedusers = array_map(function(\XF\Entity\UserBan $value): \XF\Entity\User {
                return $value->User;
            },$bannedusers_xfban);
 
AndrewSimm said:
Thanks for doing this.

I do get this error on my local
Code: 
TypeError: Return value of Andrew\ModeratorPanel\Pub\Controller\ModeratorPanel::Andrew\ModeratorPanel\Pub\Controller\{closure}() must be an instance of XF\Entity\User, null returned in src/addons/Andrew/ModeratorPanel/Pub/Controller/ModeratorPanel.php at line 54
Andrew\ModeratorPanel\Pub\Controller\ModeratorPanel->Andrew\ModeratorPanel\Pub\Controller\{closure}()
array_map() in src/addons/Andrew/ModeratorPanel/Pub/Controller/ModeratorPanel.php at line 53
Andrew\ModeratorPanel\Pub\Controller\ModeratorPanel->actionIndex() in src/XF/Mvc/Dispatcher.php at line 352
XF\Mvc\Dispatcher->dispatchClass() in src/XF/Mvc/Dispatcher.php at line 259
XF\Mvc\Dispatcher->dispatchFromMatch() in src/XF/Mvc/Dispatcher.php at line 115
XF\Mvc\Dispatcher->dispatchLoop() in src/XF/Mvc/Dispatcher.php at line 57
XF\Mvc\Dispatcher->run() in src/XF/App.php at line 2351
XF\App->run() in src/XF.php at line 517
XF::runApp() in index.php at line 20

Looks like it doesn't like:
PHP: 
            //leftfix
            $finder = \XF::finder('XF:UserBan');
            $bannedusers_xfban = $finder
                ->with('User')
                ->order('ban_date', 'DESC')
                ->limit(10)
                ->fetch()->toArray();

            $bannedusers = array_map(function(\XF\Entity\UserBan $value): \XF\Entity\User {
                return $value->User;
            },$bannedusers_xfban);
Click to expand...

here's quick and dirty fix.
this bugfix reduces sql query time 4 seconds to 0.4 ms with 13k users banned.
gist.github.com

Build software better, together

GitHub is where people build software. More than 100 million people use GitHub to discover, fork, and contribute to over 420 million projects.
gist.github.com gist.github.com
it will most likely do this when you have invalid user_id on xf_user_ban table
 
Last edited:
leftspace89 said:
here's quick and dirty fix.
this bugfix reduces sql query time 4 seconds to 0.4 ms with 13k users banned.
gist.github.com

Build software better, together

GitHub is where people build software. More than 100 million people use GitHub to discover, fork, and contribute to over 420 million projects.
gist.github.com gist.github.com
it will most likely do this when you have invalid user_id on xf_user_ban table
Click to expand...
Awesome, that worked. Now I noticed you only did it when showing spam users is true. I assume I should do this with the other queries as well?
 
AndrewSimm said:
Awesome, that worked. Now I noticed you only did it when showing spam users is true. I assume I should do this with the other queries as well?
Click to expand...
yes that else condition should be changed aswell. as a owner of code you would understand better and do better fixes.
right now Im using 1.6 version of this and I'll wait this fixes to applied on 1.7.5 for upgrade.
 
leftspace89 said:
yes that else condition should be changed aswell. as a owner of code you would understand better and do better fixes.
right now Im using 1.6 version of this and I'll wait this fixes to applied on 1.7.5 for upgrade.
Click to expand...
Got it, I appreciate the help. I will probably deploy these fixes and and a few others to my life site tonight for testing and then release sometime this week.
 
wakon5544 said:
View attachment 281123

site/moderatorpanel/
Takes 6 seconds to load. why its slow? is there any way to fix or improve the load times. (it makes moderation panel unusable and pain to use honestly) I have 2m members in my xf_user table.
Click to expand...
That finder query has been fixed thanks to @leftspace89. Please let me know if you come across something else. I run this add-on on two boards that have over 6.5M posts but their user counts top out at 17K.
 
FYI - one of my moderators reported that banned users and discouraged user lists are repeating across pages. I have fixed the issue and will lease a fix later tonight. I am going to peak at a few other things and see if I can include them in 1.7.7.
 
Hey there,

For one of our websites, we noticed that anytime a moderator remove's moderating from a user, the page just gets refreshed but doesn't remove the moderation. It doesn't seem like this issue is affecting my other sites, any idea where I should look or what may be causing this issue?

No errors were logged, and there was nothing in the console.
 
Malcolm M said:
Hey there,

For one of our websites, we noticed that anytime a moderator remove's moderating from a user, the page just gets refreshed but doesn't remove the moderation. It doesn't seem like this issue is affecting my other sites, any idea where I should look or what may be causing this issue?

No errors were logged, and there was nothing in the console.
Click to expand...
What version are you running?
 
AndrewSimm said:
Can you walk me through how you know they are still being moderated?
Click to expand...
Yeah, sure!

So when you click on the gear and click "remove moderation" it will refresh, and when you check again, instead of saying "Moderate" it says "remove moderation" still.

After doing that, I checked the Admincp and noticed the group was still under the assigned user groups.
 
Malcolm M said:
Yeah, sure!

So when you click on the gear and click "remove moderation" it will refresh, and when you check again, instead of saying "Moderate" it says "remove moderation" still.

After doing that, I checked the Admincp and noticed the group was still under the assigned user groups.
Click to expand...
Can you check the admin panel and see if they are still in the "Moderator Queue" user group?
 
You must log in or register to reply here.

Similar threads

Foxtrek_64
  • Suggestion Suggestion
Native Moderator Control Panel
Replies
8
Views
283
KSA
KSA
Spartan
  • Question Question
XF 2.0 Moderator Tools/Control Panel
Replies
2
Views
2K
SyTry
SyTry
RobinHood
  • Suggestion Suggestion
Lack of interest Show checkmark for usergroups a user is in when in edit Moderator/Admin panel
Replies
0
Views
767
RobinHood
RobinHood
Jonathan Carl
  • Suggestion Suggestion
Not planned Moderator Control Panel
Replies
4
Views
2K
Yogesh Sarkar
Y
Top Bottom