Ads Manager 2 by Siropu

Ads Manager 2 by Siropu [Paid] 2.4.22

No permission to buy (€49.99)
Siropu updated Ads Manager 2 by Siropu with a new update entry:

Improvements & Bug Fixes

Added a workaround for boards who are using page caching. The admin option is called "Bypass page cache" in Ads Manager [General] and it works with the "lazy loading" feature only.

If a size is selected under "Allowed ad sizes" in package "Advertising" tab, it will be displayed in the package list for advertisers and also under the upload button in ad creation page.

Can now use html in text ad description.

Bugs Fixed
MaxMind Geo criteria admin log error for unknown IPs.
404...

Read the rest of this update entry...
 
Looking for some advice please; we recently created a code advert with a custom size (specifically a height of 250 pixels), but when the advert is called and rendered on the page the container has "auto" for height which then shrinks down to 90px.

Is there any way to turn this off and force the specific dimensions of the custom ad size for the container?
 
The container of the ad unit or the container of the ad you are using? Can you show me the code, please?

Custom size: 970 x 250

Ad code:
Code:
<ins class="adsbygoogle"
     style="display:block; clear:both; width:100%;"
     data-ad-client="***"
     data-ad-slot="***"
     data-ad-format="horizontal"
     data-full-width-responsive="false"></ins>
<script>
     (adsbygoogle = window.adsbygoogle || []).push({});
</script>

Page HTML (where ad rendered):
Code:
<div class="p-body-inner" style="height: auto !important;">
    <div class="samCodeUnit samAlignCenter samCustomSize" style="width: 970px;height: auto !important;" data-position="container_breadcrumb_top_above">
        <div class="samItem" style="height: auto !important;">

extra.less:
Code:
/* Remove top banner padding */
.samCodeUnit,
{
    &[data-position="container_breadcrumb_top_above"]
    {
        margin: 0px 0px 10px 0px !important;
    }
    &[data-position="container_breadcrumb_bottom_below"]
    {
        margin: 20px 0px 0px 0px !important;
    }
    &[data-position="below_thread_navigation"]
    {
        margin: 0px 0px 0px 0px !important; line-height: 10px;
    }
}

So having set a custom size we had expected it to display the ad in a container matching the custom size (viewed on PC desktop), but as you can see auto is being applied to the container height.

We're just not sure where/how so wondered if this has come up before?

Of course there is every chance it is a customisation we've made elsewhere, but we just haven't managed to find where the height is being set?

Thanks.
 
Last edited:
The code is added by Adsense for some reason, don't think it is a setting. Try adding height: 250px; to the adsense code directly.

Unfortunately that didn't work, but when we switched the advert settings back to "auto" size the height CSS disappeared from the rendered HTML; it definitely seems to be introduced when selecting a custom ad size in the ad settings.

However, we think we've found the culprit ... and it is part of the Adsense code - data-ad-format="horizontal" - take this out (or change the value to auto) and the ads start coming in at 250px height!! (y)

Thanks for your help @Siropu :)
 
Hello @Siropu :-)
We're experimenting with another type of popup ad-
one that seems similar to a notice.

I basically just copied the HTML code of a notice,
and pasted it as a code ad:

HTML:
<div style="position: relative;">
    <ul class="notices notices--floating js-notices" style="position: fixed; left: 0; bottom: 0;" data-xf-init="notices" data-type="floating" data-scroll-interval="6">       
        <li class="notice js-notice notice--primary"
        style="box-shadow: none; background: transparent !important; border: none;"
        data-notice-id="ads-01" data-delay-duration="0" data-display-duration="15000" data-auto-dismiss="" data-visibility="5" style="opacity: 0; display: none;">
            <div class="notice-content">
                <a href="/account/dismiss-notice?notice_id=ads-01" class="notice-dismiss js-noticeDismiss" data-xf-init="tooltip" data-original-title="close" id="js-XFUniqueId850"></a>       
                <p>
                    <a href="https://www.***.com">
                        <img src="https://www.***.com/123.png" alt="">
                    </a>
                </p>
            </div>
        </li>
    </ul>
</div>

The problems we have are:
1) clicking the close button results in a click count...
2) The notice appears only once every page load
3) I may be mistaken but it seems as though I viewed the ad a couple of times but only one impression was counted.


Is there a way to get round those problems?
Thanks!
 
This was somewhat addressed but I could not find my specific question.

If an advertiser sends me a banner that is 1600px, and the largest ads we serve are 1160px wide, will his banner be automatically resized?
Unit size: Auto.

Correct?
 
clicking the close button results in a click count
Since it is considered an ad, it will track clicks inside the container.
The notice appears only once every page load
That's normal.
I may be mistaken but it seems as though I viewed the ad a couple of times but only one impression was counted.
What value have you set for admin option "View count condition"?

will his banner be automatically resized?
It will not be resized.
 
It will not be resized.

Oh? That's interesting.

On our site right now, this advertiser provides his banners at 1600 X 145px, but our package is 1160 X 105px. No modifications are done on our end. His banner renders at 1170 X 106 for that spot. (I'm using Google Chrome).

banner-1.jpg


And for the bottom, the package states 855 X 100px, and his banner renders at 866 X 78px.

47edd0b2a44ce172837e3c0734b6ea2a.png

So it does look like it's resizing? But the ratio seems a bit off?
 
So it does look like it's resizing? But the ratio seems a bit off?
If you set a custom size in package settings, that size will be applied to the banner with width and height but the banner itself won't be resized when you upload it.

Would this addon show in Bobs addons, such as articles and blogs?
Has custom positions for AMS and Showcase.
 
Hi
Since it is considered an ad, it will track clicks inside the container.
Thank you!
We were thinking of it would be possible to achieve it by using the popup close button (which doesn't target clicks)

The question is if there is a way to allow scrolling in the background of the popup? (instead of locking the contents of the screen)
 
@Siropu

Members trying to purchase promo threads are getting a A server error occurred. Please try again later. error when trying to pay.

Odd ACP error, the prefix set for promo threads is different than the prefix used for paid sticky threads.

Code:
Server error log

    LogicException: Cannot save with validation errors. Use validate() to ensure there are no errors. (First error: This prefix is reserved for paid sticky threads.) src/XF/Service/ValidateAndSavableTrait.php:36

    Generated by: member1 Jun 29, 2023 at 9:18 AM

Stack trace

#0 src/addons/Siropu/AdsManager/Service/Ad/PromoThreadManager.php(68): XF\Service\Thread\Creator->save()
#1 src/XF.php(625): Siropu\AdsManager\Service\Ad\PromoThreadManager->Siropu\AdsManager\Service\Ad\{closure}()
#2 src/addons/Siropu/AdsManager/Service/Ad/PromoThreadManager.php(95): XF::asVisitor(Object(SV\DailyStatistics\XF\Entity\User), Object(Closure))
#3 src/addons/Siropu/AdsManager/Entity/AdExtra.php(177): Siropu\AdsManager\Service\Ad\PromoThreadManager->save()
#4 src/XF/Mvc/Entity/Entity.php(1277): Siropu\AdsManager\Entity\AdExtra->_postSave()
#5 src/XF/Mvc/Entity/Entity.php(1323): XF\Mvc\Entity\Entity->save(false, true)
#6 src/addons/Siropu/AdsManager/Service/AdExtra/Manager.php(104): XF\Mvc\Entity\Entity->saveIfChanged(true, false)
#7 src/addons/Siropu/AdsManager/Behavior/ExtraUpdatable.php(51): Siropu\AdsManager\Service\AdExtra\Manager->save()
#8 src/XF/Mvc/Entity/Entity.php(1280): Siropu\AdsManager\Behavior\ExtraUpdatable->postSave()
#9 src/addons/Siropu/AdsManager/Entity/Ad.php(1289): XF\Mvc\Entity\Entity->save()
#10 src/addons/Siropu/AdsManager/Entity/Invoice.php(167): Siropu\AdsManager\Entity\Ad->activate()
#11 src/XF/Mvc/Entity/Entity.php(1277): Siropu\AdsManager\Entity\Invoice->_postSave()
#12 src/addons/Siropu/AdsManager/Purchasable/Advertising.php(127): XF\Mvc\Entity\Entity->save()
#13 src/XF/Payment/AbstractProvider.php(181): Siropu\AdsManager\Purchasable\Advertising->completePurchase(Object(XF\Payment\CallbackState))
#14 src/addons/OzzModz/PaymentProviderTest/Payment/Test.php(51): XF\Payment\AbstractProvider->completeTransaction(Object(XF\Payment\CallbackState))
#15 src/XF/Pub/Controller/Purchase.php(60): OzzModz\PaymentProviderTest\Payment\Test->processPayment(Object(AddonFlare\PaidRegistrations\XF\Pub\Controller\Purchase), Object(AddonFlare\PaidRegistrations\XF\Entity\PurchaseRequest), Object(PB\PaymentProfileOrder\XF\Entity\PaymentProfile), Object(XF\Purchasable\Purchase))
#16 src/addons/AddonFlare/PaidRegistrations/XF/Pub/Controller/Purchase.php(78): XF\Pub\Controller\Purchase->actionProcess()
#17 src/XF/Mvc/Dispatcher.php(352): AddonFlare\PaidRegistrations\XF\Pub\Controller\Purchase->actionProcess(Object(XF\Mvc\ParameterBag))
#18 src/XF/Mvc/Dispatcher.php(259): XF\Mvc\Dispatcher->dispatchClass('XF:Purchase', 'Process', Object(XF\Mvc\RouteMatch), Object(AddonFlare\PaidRegistrations\XF\Pub\Controller\Purchase), NULL)
#19 src/XF/Mvc/Dispatcher.php(115): XF\Mvc\Dispatcher->dispatchFromMatch(Object(XF\Mvc\RouteMatch), Object(AddonFlare\PaidRegistrations\XF\Pub\Controller\Purchase), NULL)
#20 src/XF/Mvc/Dispatcher.php(57): XF\Mvc\Dispatcher->dispatchLoop(Object(XF\Mvc\RouteMatch))
#21 src/XF/App.php(2487): XF\Mvc\Dispatcher->run()
#22 src/XF.php(524): XF\App->run()
#23 index.php(20): XF::runApp('XF\\Pub\\App')
#24 {main}

Request state

array(4) {
  ["url"] => string(67) "/xenforo/purchase/process?request_key=WqurIxgIDUyyIugmRvYp1Yo1avYiFAPG"
  ["referrer"] => string(62) "https://domain.com/xenforo/advertising/invoices/127/pay"
  ["_GET"] => array(2) {
    ["q"] => string(22) "/xenforo/purchase/process"
    ["request_key"] => string(32) "WqurIxgIDUyyIugmRvYp1Yo1avYiFAPG"
  }
  ["_POST"] => array(0) {
  }
}
 
We were thinking of it would be possible to achieve it by using the popup close button (which doesn't target clicks)

The question is if there is a way to allow scrolling in the background of the popup? (instead of locking the contents of the screen)
Not possible unfortunately.

Odd ACP error, the prefix set for promo threads is different than the prefix used for paid sticky threads.
Will look into it.

Can this addon serve different ad sizes depending on the width of the display window?
Yes, by using the device criteria.
 
Request:

Change the event names used by the GA tagging function from "View" and "Click" to "ad_impression" and "ad_click" - so it can properly line up with the new GA4 events, it's a little confusing at the moment (Click and click for example).

 
Top Bottom