Ads Manager 2 by Siropu [Paid] 2.4.22

[Siropu]

Try editing the ads and see if you still get that after save.

 

[Mr Lucky]

Try editing the ads and see if you still get that after save.

Edit them in what way?

 

[Siropu]

Just save them without making any changes.

 

[Siropu]

Siropu updated Ads Manager 2 by Siropu with a new update entry:

Bug Fixes

Import/Export causign an error due to a new table field that hasn't been updated.

Incorrect getter name in new ad email notification, causing an error.

Other code issues.

Read the rest of this update entry...

 

[Yawn]

Just purchased and getting errors, wasn't sure if support is handled here but I submitted a ticket on the website.

 

[Siropu]

The JS error reported was fixed and repackaged. It is related to the click fraud protection due to a recent change. Re-downloading the latest version will fix the issue (you might need to clear the browser cache).

 

[Nirjonadda]

@Siropu one more issue, why setting icon showing when page loading? also why navigation dots are showing when only one ads?

See here: https://giant.gfycat.com/FormalSpotlessIrrawaddydolphin.webm

 

[Siropu]

why setting icon showing when page loading?

Action icons show up because you have enabled admin option "Enable ad actions" in Ads Manager [Admin].

also why navigation dots are showing when only one ads?

Will be fixed in the next release.

 

[Nirjonadda]

Action icons show up because you have enabled admin option "Enable ad actions" in Ads Manager [Admin].

OK but where this icon show up after the image load?

 

[Nirjonadda]

one more bug, ads are not show up in thread view. just taking space are blank.

 

[Nirjonadda]

@Siropu Server error log.

ErrorException: [E_NOTICE] Undefined index: css_class src/addons/Siropu/AdsManager/Entity/Ad.php:200

Generated by: Nirjonmela Jun 14, 2018 at 7:34 PM

Stack trace

#0 src/addons/Siropu/AdsManager/Entity/Ad.php(200): XF::handlePhpError(8, '[E_NOTICE] Unde...', '/home/nadda/pub...', 200, Array)
#1 src/addons/Siropu/AdsManager/Repository/Package.php(64): Siropu\AdsManager\Entity\Ad->inheritPackage()
#2 src/addons/Siropu/AdsManager/Admin/Controller/Package.php(495): Siropu\AdsManager\Repository\Package->inheritPackage(1, false)
#3 src/XF/Mvc/FormAction.php(169): Siropu\AdsManager\Admin\Controller\Package->Siropu\AdsManager\Admin\Controller\{closure}(Object(XF\Mvc\FormAction))
#4 src/addons/Siropu/AdsManager/Admin/Controller/Package.php(65): XF\Mvc\FormAction->run()
#5 src/XF/Mvc/Dispatcher.php(249): Siropu\AdsManager\Admin\Controller\Package->actionSave(Object(XF\Mvc\ParameterBag))
#6 src/XF/Mvc/Dispatcher.php(88): XF\Mvc\Dispatcher->dispatchClass('Siropu\\AdsManag...', 'Save', 'json', Object(XF\Mvc\ParameterBag), 'adsManager', Object(Siropu\AdsManager\Admin\Controller\Package), NULL)
#7 src/XF/Mvc/Dispatcher.php(41): XF\Mvc\Dispatcher->dispatchLoop(Object(XF\Mvc\RouteMatch))
#8 src/XF/App.php(1931): XF\Mvc\Dispatcher->run()
#9 src/XF.php(328): XF\App->run()
#10 admin.php(13): XF::runApp('XF\\Admin\\App')
#11 {main}

Request state

array(4) {
  ["url"] => string(38) "/admin.php?ads-manager/packages/1/save"
  ["referrer"] => string(60) "/admin.php?ads-manager/packages/1/edit"
  ["_GET"] => array(1) {
    ["ads-manager/packages/1/save"] => string(0) ""
  }
  ["_POST"] => array(22) {
    ["title"] => string(25) "Bangladesh holiday banner"
    ["position"] => array(1) {
      [0] => string(30) "container_breadcrumb_top_above"
    }
    ["search"] => string(0) ""
    ["settings"] => array(14) {
      ["unit_alignment"] => string(6) "center"
      ["unit_size"] => string(0) ""
      ["unit_style"] => string(28) "width: 600px; height: 222px;"
      ["css_class"] => string(0) ""
      ["carousel"] => string(1) "1"
      ["slick"] => array(6) {
        ["arrows"] => string(1) "1"
        ["slidesToShow"] => string(1) "1"
        ["slidesToScroll"] => string(1) "1"
        ["slidesPerRow"] => string(1) "1"
        ["rows"] => string(1) "1"
        ["autoplaySpeed"] => string(4) "3000"
      }
      ["count_views"] => string(1) "1"
      ["count_clicks"] => string(1) "1"
      ["daily_stats"] => string(1) "1"
      ["click_stats"] => string(1) "1"
      ["ga_stats"] => string(1) "1"
      ["nofollow"] => string(1) "1"
      ["target_blank"] => string(1) "1"
      ["hide_from_robots"] => string(1) "1"
    }
    ["ad_display_order"] => string(6) "random"
    ["ad_display_limit"] => string(1) "5"
    ["position_criteria"] => array(2) {
      ["item_id"] => array(2) {
        ["rule"] => string(7) "item_id"
        ["data"] => array(1) {
          ["id"] => string(0) ""
        }
      }
      ["minimum_results"] => array(2) {
        ["rule"] => string(15) "minimum_results"
        ["data"] => array(1) {
          ["minimum"] => string(1) "1"
        }
      }
    }
    ["device_criteria"] => array(1) {
      ["desktop"] => array(1) {
        ["rule"] => string(7) "desktop"
      }
    }
    ["ad_allowed_limit"] => string(1) "1"
    ["cost_amount"] => string(4) "0.00"
    ["cost_currency"] => string(3) "USD"
    ["cost_per"] => string(5) "month"
    ["min_purchase"] => string(1) "1"
    ["max_purchase"] => string(1) "1"
    ["discount"] => array(2) {
      ["purchase"] => array(1) {
        [0] => string(0) ""
      }
      ["discount"] => array(1) {
        [0] => string(0) ""
      }
    }
    ["description"] => string(0) ""
    ["guidelines"] => string(0) ""
    ["display_order"] => string(1) "0"
    ["_xfToken"] => string(8) "********"
    ["_xfRequestUri"] => string(38) "/admin.php?ads-manager/packages/1/edit"
    ["_xfWithData"] => string(1) "1"
    ["_xfResponseType"] => string(4) "json"
  }
}

 

[Siropu]

OK but where this icon show up after the image load?

It seems because of the set size it is hidden below the ad. Will look into that.

one more bug, ads are not show up in thread view. just taking space are blank.

AdSense? Take a look in the browser console, see if you see any messages. If you don't that means that AdSense won't serve ads because the unit is new, due to lack of content or other reason. I don't see anything in my add-on that can prevent AdSense ads from loading.

Server error log.

Edit the ad/package by simply saving it to update the settings.

 

[Nirjonadda]

AdSense?

No, Its image.

 

[Siropu]

Internal banner image? A live demo would be useful.

 

[Nirjonadda]

Internal banner image?

Yes.

A live demo would be useful.

Check your PM

 

[Jumuro]

2Checkout does not work.
Most likely because of the form ajax.

 

[Siropu]

Do you get an error or something? 2Checkout is part of the XenForo payment system. It is not handled by Ads Manager.

 

[Jumuro]

Do you get an error or something? 2Checkout is part of the XenForo payment system. It is not handled by Ads Manager.

There are no errors. But the form does not redirect to the 2checkout site. This is due to ajax true.

 

[Siropu]

This is due to ajax true.

The form used is the same used by XenForo user upgrades. Do you have issues with that too?

 

[Jumuro]

The form used is the same used by XenForo user upgrades. Do you have issues with that too?

No, the problem is only with Your plugin.
Try to test it yourself on a 2checkout, for example.