Report Improvements by Xon

Report Improvements by Xon 2.12.7

No permission to download
  • Fix report comment alert would miss-classify warning operation types as new warnings
  • Fix "Call to undefined method XF\Entity\User::canReportSearch()" that can occur during upgrading
  • When a post is being reported; inject 'user has been warned for this post' notice, and a 'has been reply-banned' notice if SV/ThreadReplyBanTeeth add-on is installed
  • On making non-closing report comments; do not record a comment as sent if the 'send alert' checkbox is set, despite not actually sending the alert
  • Force global namespace for functions which are known to be optimizable to bytecode in php
  • Implement php 7 type hinting
  • Add option "Resolve report - Alerts" configure alerting default when rejecting/resolving reports
  • Add "Send resolution alert" checkbox when issuing/deleting/expiring warnings and issuing thread reply bans
  • In search, allow grouping report comments by report. Only really useful for upcoming ElasticSearch Essentials update.
  • Ensure report comment alerts respect the "view reporter username" permission
  • Fix double-encoding of cache values, which is surprisingly expensive
  • Fix N+1 queries when loading post reports.
    Do a direct node permission check rather than per-forum canView php call if the option "Reports respect view-node permission" is set
  • Fix N+1 query behaviour from loading report titles
  • Fix error when trying to issue a reply-ban with a warning without an expiry
  • Improvements for 'non-moderators who can have reports assigned' feature
    • Run basic permission cleanup after upgrades/installs
    • Another attempt at reducing performance impact, focusing on older MySQL versions