What's New Digest 5.3.0
- Thread starter Sim
- Start date
ichpen
Well-known member
You'll see errors in your log with error code 454 I think - SES will throttle you and emails won't get sent. If you don't see them then likely you're good. Each provider will have their own policy around rate limits etc.
MaximilianKohler
Well-known member
Hmm, I did apply for a higher SES send rate soon after I created my forum, but I think a lot of people are using SES and I've never heard of them having that error. I did see that there was a xenforo 1.x addon that handled queueing and throttling, but it was no longer needed in XF 2.x.
My understanding is that XF will simply send out emails as fast as your SMTP will allow. All emails should be queued and sent.
If you're getting XF errors, and even worse, dropped emails, that you think are related to SES's rate limits you should report it to the XF bug section, since that should apply for all emails (not just from this addon).
My understanding is that XF will simply send out emails as fast as your SMTP will allow. All emails should be queued and sent.
If you're getting XF errors, and even worse, dropped emails, that you think are related to SES's rate limits you should report it to the XF bug section, since that should apply for all emails (not just from this addon).
Stuart Wright
Well-known member
Sim
Well-known member
Yeah that would probably be useful on ZooChat as well.
I don't have time to build this functionality right now (focus is on getting ZooChat upgraded to XF 2.3!) - I'll put it on the todo list though.
Stuart Wright
Well-known member
Stuart Wright
Well-known member
Sim
Well-known member
Motivation isn't the issue right now - time is. Things are completely insane at the moment.
Need to get on top of a few things and then my runway will clear a bit and I'll be able to take a look at this and other addons I want to build or improve.
MaximilianKohler
Well-known member
Simon, I've been trying to add the forum logo to all emails per: https://xenforo.com/community/threads/logo-on-emails-really-simple-way.157687/
When I send a test email to the admin, per
I looked at this addon's templates, but I'm not too sure what to change. I used this code for one of the default/main email templates. Do you think the current behavior should remain the default?
When I send a test email to the admin, per
/admin.php?tools/whatsnewdigest-test, it shows the logo at the top. But when the actual digest gets sent out, it uses the text of the forum title instead of the logo.I looked at this addon's templates, but I'm not too sure what to change. I used this code for one of the default/main email templates. Do you think the current behavior should remain the default?
Sim
Well-known member
What is the actual URL that is being rendered in the emails in both cases?
The only difference in the mail sending code between the test routine and the actual digest emails is that the digest emails are sent via a Job which in turn enqueues the emails - whereas the test code sends the emails directly.
In any case, the digest emails are sent using the MAIL_CONTAINER template, which is a core template - if your edits to that template aren't working, it's likely not because of anything with my addon, but rather something more fundamental.
Two things that need to happen to make this work:
The only difference in the mail sending code between the test routine and the actual digest emails is that the digest emails are sent via a Job which in turn enqueues the emails - whereas the test code sends the emails directly.
In any case, the digest emails are sent using the MAIL_CONTAINER template, which is a core template - if your edits to that template aren't working, it's likely not because of anything with my addon, but rather something more fundamental.
Two things that need to happen to make this work:
- the URL being generated by your template edit needs to be valid
- the image needs to be publicly accessible by guests (ie if you can't see the image when you paste the URL into a browser running in incognito mode, then it won't work in an email)
MaximilianKohler
Well-known member
The home page of the forum. There's no problem with the URL. The logo image is public -- the code uses
publicLogoUrl.I think this code in the
whatsnewdigest_email template is the culprit?
Code:
'board': '<a href="' . link('canonical:index') . '">' . $xf.options.boardTitle . '</a>'But I'm not entirely sure what to change it to, because of that
'board': part. For MAIL_CONTAINER I changed:
Code:
<td class="header" align="center" valign="top">
<a href="{{ link('canonical:index') }}">{$xf.options.boardTitle}</a>
</td>
Code:
<td class="summaryHeaderBar" align="center" valign="top">
<xf:if is="property('emailPublicLogoUrl')">
<a href="{{ link('canonical:index') }}"><img src="{{ base_url(property('emailPublicLogoUrl'), true) }}" alt="{$xf.options.boardTitle}" /></a>
<xf:elseif is="property('publicLogoUrl')" />
<a href="{{ link('canonical:index') }}"><img src="{{ base_url(property('publicLogoUrl'), true) }}" alt="{$xf.options.boardTitle}" width="{{ property('publicLogoWidth') ?: '' }}" height="{{ property('publicLogoHeight') ?: '' }}" class="{{ property('publicLogoUrl')|to_lower|substr(-4) == '.svg' ? 'logo-svg' : '' }}" /></a>
<xf:else />
<a href="{{ link('canonical:index') }}">{$xf.options.boardTitle}</a>
</xf:if>
</td>Per the instructions I referenced. And that did enable the logo for emails other than What's New Digest.
Sim
Well-known member
That's just generating the phrase that shows at the top of the email.
I just tested this on my dev server - used a template modification to change the MAIL_CONTAINER to add the emailPublicLogoUrl or publicLogoUrl and then manually ran the cron task to generate the digest email. The logo showed up on the emails as expected - showed the public logo and then I added an email logo to my style and it showed on the next test.
MaximilianKohler
Well-known member
Sim
Well-known member
Like I said I simply did a template modification on the MAIL_CONTAINER to match what the activity summary emails use and it worked - logo appears on all emails including the digest emails
When I get a chance I will release a new version of the addon which does this without a template modification but for now a template modification is very easy.
When I get a chance I will release a new version of the addon which does this without a template modification but for now a template modification is very easy.
Sim
Well-known member
Stuart Wright
Well-known member
Sim
Well-known member
Sim updated What's New Digest with a new update entry:
v5.3.0 - Bugfixes and updated test tool
Read the rest of this update entry...
v5.3.0 - Bugfixes and updated test tool
Read the rest of this update entry...
Sim
Well-known member
Thanks for bringing this to my attention Stuart - there was indeed a bug with the unsubscribe handling - it broke due to a change in behaviour introduced in XF 2.3 that I didn't pick up. Partially because I use SparkPost which over-writes the unsubscribe headers created by XenForo with their own - and so my unsubscribes coming in via SparkPost were still working, but the core XF unsubscribes were not.
I've fixed this in What's New Digest v5.3.0 - please install this updated version and please send my apologies to your user for the bug in my addon causing their frustration (or at least feel free to blame me in your response to them!!).
FWIW, I've also made some changes to my testing tool which allows you to send a digest email test to a specific user. I used this with a test user account to validate that unsubscribes are now working as expected. Hint: you need to send a POST request to the URL in the unsubscribe header to trigger the unsubscribe process.
Similar threads
- Question
