Fixed Signature is too long error when inserting an image

[M@rc]

Affected version

2.1

When you use IMG bb code here..



I can't reproduce this because I don't know what settings are here but I guess it doesn't allow images. Still, that text is a bit misleading since it's not what's going on.

 

[Max Taxable]

It scans how tall the image is and knows it's more than your allowance in settings?

 

[M@rc]

It scans how tall the image is and knows it's more than your allowance in settings?

5 lines. I thought the XF logo was small enough to fit but I guess I was wrong. A small 16 pixel height icon works.

Guess this can be trashed.

 

[Max Taxable]

5 lines. I thought the XF logo was small enough to fit but I guess I was wrong. A small 16 pixel height icon works.

Guess this can be trashed.

Of course I was just speculating, but have seen enough really slick things with 2.1 I thought it might be in the realm of possibility. Should be a setting there though, x number of lines excluding images? I really haven't looked into it at all.

Seems kind of silly you can't hotlink a small image like the xf logo, in the sig all by itself.

 

[Chris D]

FWIW, we just simply do not allow images in signatures here (that is demonstrated by the Insert image button being missing from the editor).

That means there's a couple of things we need to look into here. Firstly, you seem to be getting the wrong error message - it should be telling you images are not allowed, rather than saying stuff about the number of lines. Secondly, you seem to indicate that a small 16px image works. It shouldn't; images aren't allowed (can you double check you were allowed to set a small image in your signature @M@rc?)

 

[Mike]

One potential guess is that the image tags are being stripped (which is what we generally do in signatures with disallowed tags). That then turns it into a URL that gets autolinked. I guess that URL then gets turned into an attempted unfurl (which fails), but it counts as extra lines in the output.

There's a separate bug about not unfurling in signatures, so if we change that, it would probably resolve this anyway.

 

[M@rc]

One potential guess is that the image tags are being stripped (which is what we generally do in signatures with disallowed tags). That then turns it into a URL that gets autolinked.

Yup, this is what happens. I used IMGUR to upload this icon instead of the xenForo logo URL.

 

[XF Bug Bot]

Thank you for reporting this issue. It has now been resolved and we are aiming to include it in a future XF release (2.1.1).

Change log:

When counting line limits in signatures, ensure that URLs are not unfurled as this will give an incorrect line count.

Any changes made as a result of this issue being resolved may not be rolled out here until later.