Search Improvements 2.13.1

Xon · Apr 9, 2023

woody said:
Reindexing search is always a good time.... one hour in, still not done with Conversation Messages (3m indexed thus far)...

<upsell>
ElasticSearch Essentials has a multi-threaded re-indexer CLI command, it does SpaceBattles entire 53 million odd documents in 25-30 minutes.
</upsell>

This obviously requires a fairly beefy server setup, as it requires +20 php workers throwing data at a multi-node elasticsearch cluster

MentaL · Apr 9, 2023

Xon said:
<upsell>
ElasticSearch Essentials has a multi-threaded re-indexer CLI command, it does SpaceBattles entire 53 million odd documents in 25-30 minutes.
</upsell>

This obviously requires a fairly beefy server setup, as it requires +20 php workers throwing data at a multi-node elasticsearch cluster

--proc x ?

woody · Apr 9, 2023

Xon said:
<upsell>
ElasticSearch Essentials has a multi-threaded re-indexer CLI command, it does SpaceBattles entire 53 million odd documents in 25-30 minutes.
</upsell>

This obviously requires a fairly beefy server setup, as it requires +20 php workers throwing data at a multi-node elasticsearch cluster

Next time...

Code:

1 x AMD EPYC 7502P (32/64)
---> 32 cores @ 2.5 GHz (64 Hyper-Threaded)
2 x 240 GB SSD (480GB Total - Used Mainly OS and MySQL Local Backup)
2 x 3.8 TB NVMe (7.6TB Total)
256 GB RAM
2 x 25 Gbps Network Connection

Xon · Apr 9, 2023

MentaL said:
--proc x ?

Well the argument is --workers but that CLI command automatically scales based on the number of CPU cores on the machine it runs on

Mark7783 · Apr 9, 2023

Xon said:
Do you have your site in debug or developer mode?

Remove the src/addons/SV/SearchImprovements/_output folder, and upload the add-on files, and then re-install Search Improvements.

No it's not in debug or developer mode and I don't have an output folder. I tried manually uploading files and reinstall but same problem

Xon · Apr 9, 2023

Mark7783 said:
No it's not in debug or developer mode and I don't have an output folder. I tried manually uploading files and reinstall but same problem

Do you have "[AL] Core Package" installed? Make sure it is updated and the "Legacy Class Extension Hack" option is disabled.

Mark7783 · Apr 9, 2023

Xon said:
Do you have "[AL] Core Package" installed? Make sure it is updated and the "Legacy Class Extension Hack" option is disabled.

Yes that was it. Thank you!

FloV · Apr 10, 2023

Another error in the protocol.

LogicException: Template public:svSearchImprov_search_results error: Could not find repository 'NF\Tickets\Repository\Category' for 'NF\Tickets:Category'
src/XF/Mvc/Entity/Manager.php:260
Generiert von: Unbekanntes Konto
10 April 2023 um 01:45

Stack-Trace

#0 src/XF/App.php(2908): XF\Mvc\Entity\Manager->getRepository('NF\\Tickets:Cate...')
#1 src/XF.php(890): XF\App->repository('NF\\Tickets:Cate...')
#2 src/addons/SV/ReportImprovements/XF/Entity/Search.php(115): XF::repository('NF\\Tickets:Cate...')
#3 src/addons/SV/SearchImprovements/XF/Entity/Search.php(273): SV\ReportImprovements\XF\Entity\Search->expandStructuredSearchConstraint(Array, 'categories', Array)
#4 src/addons/SV/SearchImprovements/XF/Entity/Search.php(382): SV\SearchImprovements\XF\Entity\Search->extractStructuredSearchConstraint(Array, Array, '')
#5 src/XF/Mvc/Entity/Entity.php(167): SV\SearchImprovements\XF\Entity\Search->getSvStructuredQuery()
#6 src/XF/Mvc/Entity/Entity.php(125): XF\Mvc\Entity\Entity->get('sv_structured_q...')
#7 internal_data/code_cache/templates/l2/s14/public/svSearchImprov_search_results.php(13): XF\Mvc\Entity\Entity->offsetGet('sv_structured_q...')
#8 src/XF/Template/Templater.php(1652): XF\Template\Templater->{closure}(Object(SV\AdvancedBbCodesPack\XF\Template\Templater), Array, NULL)
#9 src/XF/Template/Templater.php(1681): XF\Template\Templater->renderTemplate('svSearchImprov_...', Array)
#10 internal_data/code_cache/templates/l2/s14/public/search_results.php(27): XF\Template\Templater->includeTemplate('public:svSearch...', Array)
#11 src/XF/Template/Templater.php(1652): XF\Template\Templater->{closure}(Object(SV\AdvancedBbCodesPack\XF\Template\Templater), Array, NULL)
#12 src/XF/Template/Template.php(24): XF\Template\Templater->renderTemplate('search_results', Array)
#13 src/XF/Mvc/Renderer/Html.php(50): XF\Template\Template->render()
#14 src/XF/Mvc/Dispatcher.php(460): XF\Mvc\Renderer\Html->renderView('XF:Search\\Resul...', 'public:search_r...', Array)
#15 src/XF/Mvc/Dispatcher.php(442): XF\Mvc\Dispatcher->renderView(Object(XF\Mvc\Renderer\Html), Object(XF\Mvc\Reply\View))
#16 src/XF/Mvc/Dispatcher.php(402): XF\Mvc\Dispatcher->renderReply(Object(XF\Mvc\Renderer\Html), Object(XF\Mvc\Reply\View))
#17 src/XF/Mvc/Dispatcher.php(60): XF\Mvc\Dispatcher->render(Object(XF\Mvc\Reply\View), 'html')
#18 src/XF/App.php(2483): XF\Mvc\Dispatcher->run()
#19 src/XF.php(524): XF\App->run()
#20 index.php(20): XF::runApp('XF\\Pub\\App')
#21 {main}

Xon · Apr 10, 2023

I'll need to coordinate with @NixFifty to pick a search argument name which is unique and not shared across multiple add-ons when trying to display the search term on the search results page.

I don't have much time until after this Easter weekend to actually do code fixes & releases.

FloV said:
Another error in the protocol.

LogicException: Template public:svSearchImprov_search_results error: Could not find repository 'NF\Tickets\Repository\Category' for 'NF\Tickets:Category'

src/XF/Mvc/Entity/Manager.php:260

Generiert von: Unbekanntes Konto

10 April 2023 um 01:45

This is a bug in Report Improvements with it's Tickets support being overly enthusiastic

Xon · Apr 10, 2023

@FloV please update Report Improvements, that will fix the error you are experiencing.

Xon · Apr 11, 2023

Xon updated Search Improvements with a new update entry:

2.9.5 - Bugfix & maintaince update

Workaround XF bug where a search type parameter was not validated as being allowed for a search handler

Workaround XF bug where a search could be constructed which targeted the parent (ie thread) content type and not the child (ie post) content type resulting in potentially degraded search results

Replace search/member search with a redirect to a standard search with the appropriate parameters entered. Stock XF member searches are slightly specialized and the...

Read the rest of this update entry...

MentaL · Apr 11, 2023

Your update schedule is impeccable.

Xon · Apr 12, 2023

Xon updated Search Improvements with a new update entry:

2.9.6 - Bugfix update

Fix error "Object of class XF\Mvc\Reply\View could not be converted to string" when a user is denied search tries to use search

Read the rest of this update entry...

Xon · Apr 12, 2023

Xon updated Search Improvements with a new update entry:

2.9.7 - Bugfix update

Fix "Push "View X by others" option being disabled would cause some user information to not be indexed, which had the implicit "rebuild search index" if this setting was then enabled.

This fixed conversation search when using Conversation Improvements v2.4.x+

Requires a re-index of at least conversations/conversation messages to re-add the missing information.

For most sites, disabling the "Push "View X by others" check into XFES" option is not recommended

...

Read the rest of this update entry...

lifo · Apr 14, 2023

We’re experiencing a problem after the last update. When you search for anything or would like to check a user’s threads and click to do that, a warning that says “Your changes have been saved.” pops up. What is this? We didnt like this.

Xon · Apr 15, 2023

lifo said:
We’re experiencing a problem after the last update. When you search for anything or would like to check a user’s threads and click to do that, a warning that says “Your changes have been saved.” pops up. What is this? We didnt like this.

I'm going to need a more in-depth description of how you are triggering this. What UI elements in what sequence are you using?

There are multiple ways to trigger various searches

lifo · Apr 15, 2023

Xon said:
I'm going to need a more in-depth description of how you are triggering this. What UI elements in what sequence are you using?

We use the “Find” menu on the user’s profile.

Xon · Apr 15, 2023

Will be fixed in the next update. This doesn't happen with the default style, but it was an easy fix.

Xon · Apr 17, 2023

Xon updated Search Improvements with a new update entry:

2.9.8 - Bugfix update

Cleanup add-on description & readme file

Update XFES dependent option descriptions to include if they require XFES

Improve styling of 'no results' search result in an overlay

Fix search result terms do not display when search results are in an overlay

Fix custom styling triggering "Your changes have been saved." when clicking a member search link

Read the rest of this update entry...

Xon · May 2, 2023

Xon updated Search Improvements with a new update entry:

2.10.1 - Feature update

Thanks for @NamePros for funding this update.

Improve how thread/tickets by others in a category without view-other permission are filtered out of search results when using XFES without ElasticSearch Essentials

Add PermissionConstraint helper class, designed to simplify implementing XF Search handler's getTypePermissionConstraints function

Add "Collect search DSL & debug statistics" option...

Read the rest of this update entry...

Search Improvements 2.13.1

Well-known member

Well-known member

Well-known member

Well-known member

Member

Well-known member

Member

Well-known member

Stack-Trace​

Well-known member

Well-known member

Well-known member

Well-known member

Well-known member

Well-known member

Member

Well-known member

Member

Well-known member

Well-known member

Well-known member

Similar threads

We value your privacy

Stack-Trace