Report Improvements by Xon

Report Improvements by Xon 2.18.3

No permission to download
@djbaxter , we have the same issue on our site. We've been working to setup an equal and similar staging area to our live and it is taking longer than expected.

If you have an easy test site with same errors, would you help @Xon above?
It's a live site and that's the only error I get.
I've managed to reproduce this locally, I had some another add-on doing something with URL generation that I didn't notice. Working on fixing now.
 
Previous warning editing only allowed adjusting the expiry date. The full form in an overlay has a number of UX issues and it was just easier to make it show up on a new page.
OK, but after editing the warning I'm not being sent back to the thread which makes it really frustrating.
 
This add-on doesn't actually touch the 'can report' button. It extends the dialog which pops-up, but it doesn't interact with the permission check on if a user can report stuff
 
Found a small issue. When this template modification is enabled, an empty form row is added above the report box field.

1634660098563.webp

1634660123154.webp
 

Attachments

  • 1634660357174.webp
    1634660357174.webp
    18.3 KB · Views: 2
@Xon just saw these two errors pop up in the ACP error log, same time, same user. Not sure if it's a you thing or an Ozzy thing :)

Code:
Server error log

    InvalidArgumentException: Entity does not have an ID or does not have a simple key src/XF/Service/Report/Creator.php:55

    Generated by: Member Feb 3, 2022 at 4:54 PM

Stack trace

#0 src/addons/SV/ReportImprovements/XF/Service/Report/CreatorPatch.php(22): XF\Service\Report\Creator->createReport('ozzmodz_cl_repo...', Object(OzzModz\CountryLogin\Entity\LogReport))
#1 src/addons/SV/ReportCentreEssentials/XF/Service/Report/Creator.php(24): SV\ReportImprovements\XF\Service\Report\CreatorPatch->createReport('ozzmodz_cl_repo...', Object(OzzModz\CountryLogin\Entity\LogReport))
#2 src/XF/Service/Report/Creator.php(45): SV\ReportCentreEssentials\XF\Service\Report\Creator->createReport('ozzmodz_cl_repo...', Object(OzzModz\CountryLogin\Entity\LogReport))
#3 src/XF/Container.php(276): XF\Service\Report\Creator->__construct(Object(XF\Pub\App), 'ozzmodz_cl_repo...', Object(OzzModz\CountryLogin\Entity\LogReport))
#4 src/XF/App.php(1708): XF\Container->createObject('SV\\ReportCentre...', Array)
#5 src/XF/Container.php(234): XF\App->XF\{closure}('SV\\ReportCentre...', Array, Object(XF\Container))
#6 src/XF/App.php(3021): XF\Container->create('service', 'XF:Report\\Creat...', Array)
#7 src/addons/OzzModz/CountryLogin/Service/Logger.php(208): XF\App->service('XF:Report\\Creat...', 'ozzmodz_cl_repo...', Object(OzzModz\CountryLogin\Entity\LogReport))
#8 src/addons/OzzModz/CountryLogin/Service/Logger.php(161): OzzModz\CountryLogin\Service\Logger->setupReportCreate(Object(OzzModz\CountryLogin\Entity\LogReport))
#9 src/XF/Service/ValidateAndSavableTrait.php(42): OzzModz\CountryLogin\Service\Logger->_save()
#10 src/addons/OzzModz/CountryLogin/Listener.php(34): OzzModz\CountryLogin\Service\Logger->save()
#11 src/XF.php(370): OzzModz\CountryLogin\Listener::OzzModz\CountryLogin\{closure}()
#12 src/XF/Mvc/Dispatcher.php(158): XF::triggerRunOnce(true)
#13 src/XF/Mvc/Dispatcher.php(57): XF\Mvc\Dispatcher->dispatchLoop(Object(XF\Mvc\RouteMatch))
#14 src/XF/App.php(2351): XF\Mvc\Dispatcher->run()
#15 src/XF.php(517): XF\App->run()
#16 index.php(20): XF::runApp('XF\\Pub\\App')
#17 {main}

Request state

array(4) {
  ["url"] => string(11) "/getalerts/"
  ["referrer"] => string(70) "https://www.domain.com/conversations/convo.1402341/"
  ["_GET"] => array(1) {
    ["/getalerts/"] => string(0) ""
  }
  ["_POST"] => array(2) {
    ["_xfToken"] => string(8) "********"
    ["global"] => string(5) "false"
  }
}


Code:
Server error log

    InvalidArgumentException: Entity does not have an ID or does not have a simple key src/XF/Service/Report/Creator.php:55

    Generated by: Member Feb 3, 2022 at 4:54 PM

Stack trace

#0 src/addons/SV/ReportImprovements/XF/Service/Report/CreatorPatch.php(22): XF\Service\Report\Creator->createReport('ozzmodz_cl_repo...', Object(OzzModz\CountryLogin\Entity\LogReport))
#1 src/addons/SV/ReportCentreEssentials/XF/Service/Report/Creator.php(24): SV\ReportImprovements\XF\Service\Report\CreatorPatch->createReport('ozzmodz_cl_repo...', Object(OzzModz\CountryLogin\Entity\LogReport))
#2 src/XF/Service/Report/Creator.php(45): SV\ReportCentreEssentials\XF\Service\Report\Creator->createReport('ozzmodz_cl_repo...', Object(OzzModz\CountryLogin\Entity\LogReport))
#3 src/XF/Container.php(276): XF\Service\Report\Creator->__construct(Object(XF\Pub\App), 'ozzmodz_cl_repo...', Object(OzzModz\CountryLogin\Entity\LogReport))
#4 src/XF/App.php(1708): XF\Container->createObject('SV\\ReportCentre...', Array)
#5 src/XF/Container.php(234): XF\App->XF\{closure}('SV\\ReportCentre...', Array, Object(XF\Container))
#6 src/XF/App.php(3021): XF\Container->create('service', 'XF:Report\\Creat...', Array)
#7 src/addons/OzzModz/CountryLogin/Service/Logger.php(208): XF\App->service('XF:Report\\Creat...', 'ozzmodz_cl_repo...', Object(OzzModz\CountryLogin\Entity\LogReport))
#8 src/addons/OzzModz/CountryLogin/Service/Logger.php(161): OzzModz\CountryLogin\Service\Logger->setupReportCreate(Object(OzzModz\CountryLogin\Entity\LogReport))
#9 src/XF/Service/ValidateAndSavableTrait.php(42): OzzModz\CountryLogin\Service\Logger->_save()
#10 src/addons/OzzModz/CountryLogin/Listener.php(34): OzzModz\CountryLogin\Service\Logger->save()
#11 src/XF.php(370): OzzModz\CountryLogin\Listener::OzzModz\CountryLogin\{closure}()
#12 src/XF/Mvc/Dispatcher.php(158): XF::triggerRunOnce(true)
#13 src/XF/Mvc/Dispatcher.php(57): XF\Mvc\Dispatcher->dispatchLoop(Object(XF\Mvc\RouteMatch))
#14 src/XF/App.php(2351): XF\Mvc\Dispatcher->run()
#15 src/XF.php(517): XF\App->run()
#16 index.php(20): XF::runApp('XF\\Pub\\App')
#17 {main}

Request state

array(4) {
  ["url"] => string(11) "/getalerts/"
  ["referrer"] => string(80) "https://www.domain.com/threads/thread.405181/page-4"
  ["_GET"] => array(1) {
    ["/getalerts/"] => string(0) ""
  }
  ["_POST"] => array(2) {
    ["_xfToken"] => string(8) "********"
    ["global"] => string(5) "false"
  }
}
 
I feel like an idiot, but I just installed this and Warning improvements and for the life of me I cannot find where the Reports center is.
 
I feel like an idiot, but I just installed this and Warning improvements and for the life of me I cannot find where the Reports center is.
Make sure you user has the relevant permissions or is part of the default "moderating" usergroup which should have been granted the permissions by default.
 
Back
Top Bottom