[rellect] Favicon for Links 2.1.0

[refael]

rellect updated [rellect] Favicon for Links with a new update entry:

v1.0.4

Fixed
- Minor css issue that showed the favicon repeatedly in some browsers. Thanks @CRDeveloper

Read the rest of this update entry...

 

[motowebmaster]

Does this addon work with XF 1.3 ?

 

[refael]

Does this addon work with XF 1.3 ?

Yes, it is working on 1.3.

 

[Kerby]

Bug
When installed 1.0.4 or 1.0.3:

With Windows 7 and IE 9.0, the XF WYSIWYG editor doesn't show up in threads, but in conversations it does. This doesn't happen on IE 11.0 actual Firefox/Safari/Chrome.

• When Addon downgraded to 1.0.2 it's working
• When Addon disabled it's working
• Tested when all addons are disabled, but activated Favicon for Links
  
• Tested on XF 1.2.2 and XF 1.2.4
  
• javascript in test IE 9.0 is activated

Can you please fix this?

 

[refael]

Bug
When installed 1.0.4 or 1.0.3:

With Windows 7 and IE 9.0, the XF WYSIWYG editor doesn't show up in threads, but in conversations it does. This doesn't happen on IE 11.0 actual Firefox/Safari/Chrome. Example on screenshot.

View attachment 69799
("Entwurf gespeichert" is german and means "Draft saved". Button "Antworten" means "Post Reply")

• When Addon downgraded to 1.0.2 it's working
• When Addon disabled it's working
• Tested when all addons are disabled, but activated Favicon for Links
  
• Tested on XF 1.2.2 and XF 1.2.4
  
• javascript in test IE 9.0 is activated

Can you please fix this?

Something was missing in the javascript to escape the code properly. Seems like only IE9 and older were bothered by this.
Fixed, thanks.

 

[refael]

rellect updated [rellect] Favicon for Links with a new update entry:

v1.0.5 - critical

Something was missing in the javascript to properly escape the code.
It caused to a few issues in IE9 and lower. Other browsers were not affected (as far as I know).

Please update as soon as possible.

Read the rest of this update entry...

 

[DRE]

Won't install for me.

 

[refael]

Won't install for me.

More specifically? Is there an issue during the installation?

 

[DRE]

More specifically? Is there an issue during the installation?

The files associated with this add-on could not be found. Please upload them and try again.

 

[refael]

The files associated with this add-on could not be found. Please upload them and try again.

You're right, originally there was a file but I removed it in this version. I forgot to update the xml file to remove the call from there.

Thanks.

 

[refael]

rellect updated [rellect] Favicon for Links with a new update entry:

v1.0.5 - reupload

A file was removed in this version, and I forgot to remove the call from the xml. Sorry.

Read the rest of this update entry...

 

[Null]

@rellect, if a website is running a secure site (over HTTPS), this add-on causes insecure content warnings because you're pulling the favicon from a insecure source, despite Google supporting the HTTPS protocol for this API.

Please can you update this add-on to determine what protocol websites are using to avoid the insecure content warnings.

HTTPS is supported: https://www.google.com/s2/favicons?domain=http://xenforo.com/community

XenForo.setFavicons = function(to)
    {
        $(to).each(function(){
            if($(this).has('img').length)
            {
                // skip if the link is an image
                return true;
            }
            $(this).addClass('setFavicon').css(
                "background-image", "url(http://www.google.com/s2/favicons?domain=" + this.href + ")"
            );
        });
    }

 

[refael]

@rellect, if a website is running a secure site (over HTTPS), this add-on causes insecure content warnings because you're pulling the favicon from a insecure source, despite Google supporting the HTTPS protocol for this API.

Please can you update this add-on to determine what protocol websites are using to avoid the insecure content warnings.

HTTPS is supported: https://www.google.com/s2/favicons?domain=http://xenforo.com/community

Thanks, I'll fix that.

For now edit rellect_favicon_js, change

"background-image", "url(http://www.google.com/s2/favicons?domain=" + this.href + ")"

To

"background-image", "url('//www.google.com/s2/favicons?domain=" + this.href + "')"

Let me know if that helps.

 

[refael]

rellect updated [rellect] Favicon for Links with a new update entry:

v1.0.6

Maintain update.

[FIXED] Auto http/https protocol detection applied, for those who use SSL in their site.
[CHANGED] A trivial js change to improve the function that sets favicons new (quick) replies.

Read the rest of this update entry...

 

[rdn]

Really nice to have

 

[Kerby]

1.0.6 is fast loading favicons, thanks

Bug 1.0.6
After update, the Links on my forum with same domain like my forum are only default favicon grey globe icon. 1.0.5 was working fine.

You can find many examples on my forum in following post:

 

[refael]

1.0.6 is fast loading favicons, thanks

Bug 1.0.6
After update, the Links on my forum with same domain like my forum are only default favicon grey globe icon. 1.0.5 was working fine.

You can find many examples on my forum in following post: http://swisssmp.ch/threads/neuigkeiten.5160/#post-80036

I don't think it has something to do with the update, it seems google can't find your favicon. Not really sure why.
http://www.google.com/s2/favicons?domain=http://swisssmp.ch

 

[Kerby]

When I open your link, it shows me my red favicon. and i've nothing changed others before and after update on my webserver/xenforo/addons. minutes before update it was working fine. i could revert back to 1.0.5 to show it.

 

[rdn]

When I open your link, it shows me my red favicon. and i've nothing changed others before and after update on my webserver/xenforo/addons. minutes before update it was working fine. i could revert back to 1.0.5 to show it.

Works fine on my end:

 

[refael]

Yea I can see now the correct favicon in the google link, and in the linked thread.
Possibly it was just temporary issue.