Ads Manager 2 by Siropu [Paid] 2.8.1

[beerForo]

That's because it was meant to work with rgb not hsl.

Okay so will wait for next version because now rgb doesn't work at all, error msg., like you said, fix coming, thanks. Right now, can't use any placeholders.

Cannot reproduce this.

I see the issue. No matter what radio button you click, it shows the greatest discount even if that one is not selected.
Reproduce:
1 month 25%
6 months 50%
Select one month but use the + sign to go up to 6 months. Now select the 6 month discount. The amount stays the same. Because they are both at 50% for six months. This could be very confusing to users as I toggled between the two and noticed no difference and assumed it was not discounting to 50% since I clicked that one second.

Perhaps you can address this so it is a bit more clear? I don't even need the radio buttons they can manually add what they need and see the amounts change, really as long as the discounts are just stated, it works, without clicking one. If I had 5 discounts, they would all reflect the greatest one, which would be very confusing, and with no need for the radio buttons.

Maybe have each discount reflect the actual discount clicked. So 6 months only shows 25% if the 25% radio button is clicked. I think maybe you do the greatest one to avoid the error of the user not clicking the best discount, but it is also confusing that they don't reflect the actual discount.

So, to get the 6 months they have to click it.

Also, when you first enter the page, nothing is selected, this can also create confusion since a discount has been calculated. They are calculated without clicking any radio buttons. I'd suggest if the discount is available without changing and parameters (duration, etc.), have that discount already selected since the total cost is stating it already as the price.

Thanks

 

[beerForo]

Bug:
There's a bug in calculation of user group discounts. Example:

= 1 Month (25% Discount)
= 4 Months (50% Discount)

If I enter 1, 2, 3 months it is 25%, correct. 4 months is 50%, correct.
5 months is 50%, not correct, it should be 25% until they get to 8, which is the 4 month discount x2. Otherwise it is the single monthly of 25% (5, 6, 7 = 25%, 8 = 50%), and so on...

It's not 4 months at least, it's a 4 month block that is discounted. Every 1 month 25%, every 4 months, 50%...

 

[beerForo]

First off, a suggestion. Can you please have the View Discounts link appear if only a group discount is enabled? That would be really helpful. For me it does not appear unless there is a package discount (but it will show the group discount, odd).

Thanks for the fix.

As far as the override, this does not make sense. If a banner costs $100/month, but $250 for 6 months, and a group gets 50% off, that group should be able to get 50% off the $250. It should not override it. They should get both discounts. What happens if the group discount is less than the package discount? They pay more? Anyway, that should not matter, they should get both so I am suggesting this, otherwise, I am not going to add any package discounts because it won't make much sense and may upset some advertisers.

To address this, I repeated the "Purchase length" discounts for the group and gave them a better discount on those instead of an overall. A workaround that works well, I suppose. The above fix now shows the proper discount link as well.

Bug in post above is different.

PS. Is there an approximate date for the next release? Looking to use placeholders, thanks!

 

[Siropu]

Is there an approximate date for the next release?

Next week hopefully. I'm working on adding 3 more ad types and it takes time.

 

[Siropu]

Siropu updated Ads Manager 2 by Siropu with a new update entry:

New Features, Improvements & Bug Fixes

Added 3 new a types:

1. Interstitial - An ad that displays in a standalone page where you can add a banner or custom code from the ad itsef and from the package unit content.

2. Featured Thread - Create/sell a featured thread using an ad.

2. Featured Media - Create/sell a featured media using an ad.

Added discount list as description under the purchase input instead of radio buttons.

Fixed an issue with some ad types where the Settings tab was visible but not...

Read the rest of this update entry...

 

[beerForo]

Getting this error in new version:

ErrorException: [E_WARNING] Undefined array key 1 in src/XF/Util/Color.php at line 320
XF::handlePhpError() in src/XF/Util/Color.php at line 320
XF\Util\Color::hslToHex() in src/addons/Siropu/AdsManager/Service/Package/Placeholder.php at line 100
Siropu\AdsManager\Service\Package\Placeholder->hslToHex() in src/addons/Siropu/AdsManager/Service/Package/Placeholder.php at line 57
Siropu\AdsManager\Service\Package\Placeholder->generate() in src/addons/Siropu/AdsManager/Entity/Package.php at line 307
Siropu\AdsManager\Entity\Package->enablePlaceholder() in src/addons/Siropu/AdsManager/Admin/Controller/Package.php at line 589
Siropu\AdsManager\Admin\Controller\Package->Siropu\AdsManager\Admin\Controller\{closure}() in src/XF/Mvc/FormAction.php at line 200
XF\Mvc\FormAction->run() in src/addons/Siropu/AdsManager/Admin/Controller/Package.php at line 88
Siropu\AdsManager\Admin\Controller\Package->actionSave() in src/XF/Mvc/Dispatcher.php at line 364
XF\Mvc\Dispatcher->dispatchClass() in src/XF/Mvc/Dispatcher.php at line 266
XF\Mvc\Dispatcher->dispatchFromMatch() in src/XF/Mvc/Dispatcher.php at line 121
XF\Mvc\Dispatcher->dispatchLoop() in src/XF/Mvc/Dispatcher.php at line 63
XF\Mvc\Dispatcher->run() in src/XF/App.php at line 2840
XF\App->run() in src/XF.php at line 844
XF::runApp() in admin.php at line 15

I went to the settings and changed the colors and saved, and tried to save the package again, still, error.

 

[beerForo]

With the new Featured Thread function, it is not clear if users can feature an existing thread or if they have to create a new thread. Perhaps you could explain it in the acp so we don't have to create a new package to see.

If it's both, great. Similar to sticking a current thread and creating a promo thread with sticky.

 

[Siropu]

I went to the settings and changed the colors and saved, and tried to save the package again, still, error.

What values are you using in admin options for placeholder colors?

With the new Featured Thread function, it is not clear if users can feature an existing thread or if they have to create a new thread.

An existing thread.

 

[beerForo]

None work at all. Example:



Now, go to the package, enable placeholder, save (and it does not save it):

ErrorException: [E_WARNING] Undefined array key 1 in src/XF/Util/Color.php at line 320
XF::handlePhpError() in src/XF/Util/Color.php at line 320
XF\Util\Color::hslToHex() in src/addons/Siropu/AdsManager/Service/Package/Placeholder.php at line 100
Siropu\AdsManager\Service\Package\Placeholder->hslToHex() in src/addons/Siropu/AdsManager/Service/Package/Placeholder.php at line 45
Siropu\AdsManager\Service\Package\Placeholder->generate() in src/addons/Siropu/AdsManager/Entity/Package.php at line 307
Siropu\AdsManager\Entity\Package->enablePlaceholder() in src/addons/Siropu/AdsManager/Admin/Controller/Package.php at line 589
Siropu\AdsManager\Admin\Controller\Package->Siropu\AdsManager\Admin\Controller\{closure}() in src/XF/Mvc/FormAction.php at line 200
XF\Mvc\FormAction->run() in src/addons/Siropu/AdsManager/Admin/Controller/Package.php at line 88
Siropu\AdsManager\Admin\Controller\Package->actionSave() in src/XF/Mvc/Dispatcher.php at line 364
XF\Mvc\Dispatcher->dispatchClass() in src/XF/Mvc/Dispatcher.php at line 266
XF\Mvc\Dispatcher->dispatchFromMatch() in src/XF/Mvc/Dispatcher.php at line 121
XF\Mvc\Dispatcher->dispatchLoop() in src/XF/Mvc/Dispatcher.php at line 63
XF\Mvc\Dispatcher->run() in src/XF/App.php at line 2840
XF\App->run() in src/XF.php at line 844
XF::runApp() in admin.php at line 15

No colors will work, HSL, RGB, using words like white, black, or any XF variables like @xf-textColor.

Rebuild add-on did not work either.

 

[Siropu]

None work at all. Example:

That's not a HSL value. Use the color picker from the right side of the input.

 

[beerForo]

No colors will work, HSL, RGB, using words like white, black, or any XF variables like @xf-textColor.

Rebuild add-on did not work either.

 

[beerForo]

Maybe the new version has an old file?

 

[beerForo]

@Siropu can you offer a fix or patch? I have had placeholders disabled a few weeks now they won't even enable with this error. Thank you.

 

[Mr Lucky]

Is it possible to include custom thread fields when buying a promo thread?

 

[Siropu]

can you offer a fix or patch?

I've DM you a a version for testing.

s it possible to include custom thread fields when buying a promo thread?

Yes, there is an option to enable this.

 

[Mr Lucky]

Is it possible to include custom thread fields when buying a promo thread?

Yes, there is an option to enable this.

I have that enabled but is not visible in create ad, only once the tread is created so the user has to edit the thread. So I wonder if it's possible to have the fields visible when buying the promo thread.

As it is if I have a required field they cannot create the thread because it isn't there in when creating the ad.

 

[Siropu]

I have that enabled but is not visible in create ad, only once the tread is created so the user has to edit the thread.

When you select a forum from the list, the custom fields associated with that forum will display afer "Thread content":

 

[Siropu]

There is a bug with creating promo threads and custom fields from ACP but it works from front-end.

 

[Mr Lucky]

When you select a forum from the list, the custom fields associated with that forum will display afer "Thread content":

I’m not seeing them

 

[Siropu]

Which version are you using?