Ads Manager 2 by Siropu [Paid] 2.8.1

[beerForo]

I had to define top and bottom margins independently (0), setting all to 0 messed up the alignment (right/left/center) of an ad.

 

[beerForo]

In positions when there is a X, where is X defined?
Example:
Node list below category x container

 

[beerForo]

Bug when saving placeholder again, this time:

ErrorException: [E_WARNING] Undefined array key 1 in src/XF/Util/Color.php at line 253
XF::handlePhpError() in src/XF/Util/Color.php at line 253
XF\Util\Color::rgbToHex() in src/addons/Siropu/AdsManager/Service/Package/Placeholder.php at line 75
Siropu\AdsManager\Service\Package\Placeholder->rgbToHex() in src/addons/Siropu/AdsManager/Service/Package/Placeholder.php at line 32
Siropu\AdsManager\Service\Package\Placeholder->generate() in src/addons/Siropu/AdsManager/Entity/Package.php at line 307
Siropu\AdsManager\Entity\Package->enablePlaceholder() in src/addons/Siropu/AdsManager/Admin/Controller/Package.php at line 572
Siropu\AdsManager\Admin\Controller\Package->Siropu\AdsManager\Admin\Controller\{closure}() in src/XF/Mvc/FormAction.php at line 200
XF\Mvc\FormAction->run() in src/addons/Siropu/AdsManager/Admin/Controller/Package.php at line 88
Siropu\AdsManager\Admin\Controller\Package->actionSave() in src/XF/Mvc/Dispatcher.php at line 364
XF\Mvc\Dispatcher->dispatchClass() in src/XF/Mvc/Dispatcher.php at line 266
XF\Mvc\Dispatcher->dispatchFromMatch() in src/XF/Mvc/Dispatcher.php at line 121
XF\Mvc\Dispatcher->dispatchLoop() in src/XF/Mvc/Dispatcher.php at line 63
XF\Mvc\Dispatcher->run() in src/XF/App.php at line 2840
XF\App->run() in src/XF.php at line 844
XF::runApp() in admin.php at line 15

What I did was change my placeholder color and text color, now they won't save at the package level.

Also, why is the color chooser based on XF default style colors when we use our own styles? None of the palettes are correct.

 

[briansol]

In positions when there is a X, where is X defined?
Example:
Node list below category x container

defined in the position criteria like X10

 

[beerForo]

 

[beerForo]

Text ads with ad size (banner size) set in "Allowed ad sizes" should allow "2x banner file" uploads. By default text ads do not allow 2x uploads since images are sized using css, but once we determine a set size, the 2x should appear for uploads. Thanks

 

[beerForo]

Bug when saving placeholder again, this time:

ErrorException: [E_WARNING] Undefined array key 1 in src/XF/Util/Color.php at line 253
XF::handlePhpError() in src/XF/Util/Color.php at line 253
XF\Util\Color::rgbToHex() in src/addons/Siropu/AdsManager/Service/Package/Placeholder.php at line 75
Siropu\AdsManager\Service\Package\Placeholder->rgbToHex() in src/addons/Siropu/AdsManager/Service/Package/Placeholder.php at line 32
Siropu\AdsManager\Service\Package\Placeholder->generate() in src/addons/Siropu/AdsManager/Entity/Package.php at line 307
Siropu\AdsManager\Entity\Package->enablePlaceholder() in src/addons/Siropu/AdsManager/Admin/Controller/Package.php at line 572
Siropu\AdsManager\Admin\Controller\Package->Siropu\AdsManager\Admin\Controller\{closure}() in src/XF/Mvc/FormAction.php at line 200
XF\Mvc\FormAction->run() in src/addons/Siropu/AdsManager/Admin/Controller/Package.php at line 88
Siropu\AdsManager\Admin\Controller\Package->actionSave() in src/XF/Mvc/Dispatcher.php at line 364
XF\Mvc\Dispatcher->dispatchClass() in src/XF/Mvc/Dispatcher.php at line 266
XF\Mvc\Dispatcher->dispatchFromMatch() in src/XF/Mvc/Dispatcher.php at line 121
XF\Mvc\Dispatcher->dispatchLoop() in src/XF/Mvc/Dispatcher.php at line 63
XF\Mvc\Dispatcher->run() in src/XF/App.php at line 2840
XF\App->run() in src/XF.php at line 844
XF::runApp() in admin.php at line 15

What I did was change my placeholder color and text color, now they won't save at the package level.

Also, why is the color chooser based on XF default style colors when we use our own styles? None of the palettes are correct.

Ugh, now I can't save any packages with Placeholder enabled I have to disable it for it to save.

 

[beerForo]

Some errors says key 1, some say key 0

 

[Siropu]

There is a bug due to a change in the color picker settings for placeholder colors. from rgb to hsl. It wil be fixed in the next release.

 

[beerForo]

I am back to hsl colors but they are wrong (different from the chooser).

For example if I choose something like:
background:
hsl(0, 10%, 62%)
text:
hsl(0, 77%, 37%)
That should be pink and red, but it's green and blue.
That's why I switched to rgb, but got the error.



front end:

 

[beerForo]

Is it possible for a user to collapse or hide a text ad (like a XF notice or collapsible widget)? How could this be done?

 

[beerForo]

defined in the position criteria like X10

View attachment 346067

If I have:


and


...nothing appears. I do have What's New as my homepage with more than the default amount of results, does that matter?

 

[beerForo]

The width is set to 150px but you can change that via CSS if you want.

Can you post how to do this? Thanks!

 

[beerForo]

Text ads with ad size (banner size) set in "Allowed ad sizes" should allow "2x banner file" uploads. By default text ads do not allow 2x uploads since images are sized using css, but once we determine a set size, the 2x should appear for uploads. Thanks

The reason this is an issue is with set sizes that are small like 100x100 which lose detail. A text ad with a 100x100 image should have the 2x option. Thanks

 

[beerForo]

Bug:
Text Ad with Unit Content. The unit content (text) is appearing to the right of the description in a new column, not under it, unless I choose Flexbox, then it is under the description.

Question:
How can I remove the space above unit content? I have a few ad styles and I don't want all that space there, looks like a line break amount. Thanks

 

[beerForo]

Bug:
User group discounts, this does not work. It should give 25% for each month and 50% for 6 months, but when purchasing 6 months and selecting the 6 month radio button, the discount is only 25%.

 

[new_view]

Does this add-on support AdSense video ads?

 

[Siropu]

I am back to hsl colors but they are wrong (different from the chooser).

That's because it was meant to work with rgb not hsl.

Is it possible for a user to collapse or hide a text ad (like a XF notice or collapsible widget)?

No.

I do have What's New as my homepage with more than the default amount of results, does that matter?

That position is for What's new page

Can you post how to do this?

In extra.less template:

.samItemImage
{
    width: 200px !important;
}

How can I remove the space above unit content?

In extra.less template:

.samUnitContent
{
    margin-top: 0 !important;
}

User group discounts, this does not work. It should give 25% for each month and 50% for 6 months, but when purchasing 6 months and selecting the 6 month radio button, the discount is only 25%.

Cannot reproduce this.

Does this add-on support AdSense video ads?

Support how? You can add any kind of code.

 

[new_view]

That's because it was meant to work with rgb not hsl.


No.


That position is for What's new page


In extra.less template:

.samItemImage
{
    width: 200px !important;
}

In extra.less template:

.samUnitContent
{
    margin-top: 0 !important;
}

Cannot reproduce this.


Support how? You can add any kind of code.

Sorry for being a noob; basically, what I meant was, like, you know, XenForo Media Gallery, where users upload videos. Suppose I want video Ads there to show there before the video plays (i.e., Google Adsense for Video), before the video plays; does this add-on support displaying ads?

 

[beerForo]

That position is for What's new page

It is the page, my homepage is What's New but that position shows nothing. The fact it is set as my index should not affect it, but nothing will show there., so I mentioned it as could be the issue.