Ads Manager 2 by Siropu

Ads Manager 2 by Siropu [Paid] 2.8.1

No permission to buy (€50.00)
@Siropu, having an issue, I cannot get the Advertise Here link to appear and it is enabled. I created a text package and banner package. No placeholders or ads yet. Just the space. I have enabled the package for all groups and in the groups ad purchase is enabled. And yes, 1 is available to purchase. The packages appear for purchase on the purchase page, but the link will not show in the location. I selected multiple locations just to check and the link did not appear in any of them. Not sure what is going on or what would prevent this. What should I check? Thanks
PS. If I check Placeholder nothing appears either. No link, no placeholder.
 
Last edited:
Basically I can't use discounts yet because those with a group discount will click the link and not see the package discount.
Group discounts overrides the package discounts.

What would cause in the recent update for a location to not "apply" when purchased?
A bug with the option to not inherit position from the last release.

In the meantime can the subscription box be automatically checked for a package?
It is optional for advertisers to check it or not.
don't understand this ad location because forum view does not include the node list, forum list does.
It can have sub-nodes and it is referring to that list.

crazy high impression counts ??
Indeed. Try enabling the "Hide from robots" setting.
 
What should I check?
It is a bug related to Position criteria inheritance from the last release. Just so you know, "Advertise here link" is displayed when ads are running and "Placeholder" when no ads are running.
 
It is optional for advertisers to check it or not.
Would be nice to be able to set a package to subscription only for things like ongoing sponsorships etc. Or in the least, be able to set the check by default but having dedicated subscriptions would be great!
It is a bug related to Position criteria inheritance from the last release
That explains it, will wait for new release.
Just so you know, "Advertise here link" is displayed when ads are running and "Placeholder" when no ads are running.
Yes I see how it works, it just wasn't working so I tried different things like link only, placeholder only, both, changing placements, etc. Now I see it is because of a bug.
It can have sub-nodes and it is referring to that list.
Doh!

Thanks
 
Group discounts overrides the package discounts.
First off, a suggestion. Can you please have the View Discounts link appear if only a group discount is enabled? That would be really helpful. For me it does not appear unless there is a package discount (but it will show the group discount, odd).

As far as the override, this does not make sense. If a banner costs $100/month, but $250 for 6 months, and a group gets 50% off, that group should be able to get 50% off the $250. It should not override it. They should get both discounts. What happens if the group discount is less than the package discount? They pay more? Anyway, that should not matter, they should get both so I am suggesting this, otherwise, I am not going to add any package discounts because it won't make much sense and may upset some advertisers.
 
@Siropu, if I upload GIF, WebP, PNG, or JPG. They're working to be fine with good pixels, and if I upload an MP4, it will be large on AdminCP at Ads Manager > Edit ad (Banner). The same as the dashboard / home page has an issue too.



Also, if you put a link at the target URL, the video cannot be clicked anytime. Only an image or animated GIF can be clicked on dashboard / home page.

1789064478473.webp



Only on the dashboard/home page for a fixed video large width with PC and Mobile responsive "extra.less":
Code:
.samBannerUnit[data-position="container_breadcrumb_top_above"] {
    .samItem {
        line-height: 0;
        overflow: hidden;
    }

    a { display: block; }

    img,
    video {
        display: block;
        width: 100%;
        max-width: 1065px;
        height: auto !important;
        aspect-ratio: 1065 / 171;
        object-fit: cover;
        object-position: left center;
        border: 0;
    }

    video { pointer-events: none; }
}

@media (max-width: 650px) {
    .samBannerUnit[data-position="container_breadcrumb_top_above"] img,
    .samBannerUnit[data-position="container_breadcrumb_top_above"] video {
        max-height: 80px;
    }
}
 
Last edited:
If a banner costs $100/month, but $250 for 6 months, and a group gets 50% off, that group should be able to get 50% off the $250. It should not override it. They should get both discounts. What happens if the group discount is less than the package discount? They pay more?
 
In previous versions, there was "Inherit package settings" for ads which inherited positions, settings and criteria from the package. In this version you can choose not to inherit positions and only settings and criteria
AH! So that's why we have advertisers writing us wonderiong where their ad is...

Is there a way to go back to having our packages positions Inherited by default?
Any setting or edit in a template we could do to make it so?

Thanks!
 
Last edited:
Siropu updated Ads Manager 2 by Siropu with a new update entry:

New Features, Improvements & Bug Fixes

Added Date criteria with the options to display ads based on day of the month/week and hour.
Added package advertising option to disable Queue when there are no empty slots available.
Added support for HTML5 ads.

Fixed an issue with inheriting position for advertiser ads.
Fixed an issue with group discounts not being displayed in package list for advertisers.
Fixed an issue with click tracking on Background banner ads where each banner click could count.
Fixed an issue with export of...

Read the rest of this update entry...
 
Thanks!

So when you say: "Fixed an issue with inheriting position for advertiser ads." And by calling it a bug earlier, you mean it should never have been checked in the first place?

The advertising department person feeding the ads in the Ads Manager 2 is clear about this: before the last update, she never had to select any option for inheriting the package position settings. After the last update, missing the position made the ads not show up.

So the fix today means that when creating a new banner, none of the inheriting of position and criteria will be defaulting to the Package settings?

So my question: why then are we selecting a package's position and criteria when creating a package? If we can check the boxes to have them inherited, but akready created a default position for the package, isn't that a duplication of tasks? IMHO, I would consider that to be a bug, that we need to indicate that the position selected should be defaulting to the default already picked for the package? It sounds strange to me.

Am I missing something? Wouldn't it be clearer to have an option to BYPASS the default settings we selected while creating the package?

In version 2.6.5, the option is: - "Inherit package settings." So both the position and criteria are bundled. Is it easier for you to maintain with the new version, to have these settings separated, we can choose to only inherit position or criteria?

In any case, love the addon, and thank you for the update. :)
 
you mean it should never have been checked in the first place?
Ads created from front-end are inheriting package settings and positions by default. The change I made in the previous version didn't inherited the position. Now should work as expected.

If you have the issue with ads created by advertisers you can use the package option to force inheritance to fix it
 
I can't disable a placeholder, unchecking and trying to save I get:
Code:
ErrorException: [E_WARNING] Undefined variable $ad in src/addons/Siropu/AdsManager/Entity/Ad.php at line 2089
XF::handlePhpError() in src/addons/Siropu/AdsManager/Entity/Ad.php at line 2089
Siropu\AdsManager\Entity\Ad->_postDelete() in src/XF/Mvc/Entity/Entity.php at line 1726
XF\Mvc\Entity\Entity->delete() in src/addons/Siropu/AdsManager/Entity/Package.php at line 317
Siropu\AdsManager\Entity\Package->disablePlaceholder() in src/addons/Siropu/AdsManager/Admin/Controller/Package.php at line 568
Siropu\AdsManager\Admin\Controller\Package->Siropu\AdsManager\Admin\Controller\{closure}() in src/XF/Mvc/FormAction.php at line 200
XF\Mvc\FormAction->run() in src/addons/Siropu/AdsManager/Admin/Controller/Package.php at line 88
Siropu\AdsManager\Admin\Controller\Package->actionSave() in src/XF/Mvc/Dispatcher.php at line 364
XF\Mvc\Dispatcher->dispatchClass() in src/XF/Mvc/Dispatcher.php at line 266
XF\Mvc\Dispatcher->dispatchFromMatch() in src/XF/Mvc/Dispatcher.php at line 121
XF\Mvc\Dispatcher->dispatchLoop() in src/XF/Mvc/Dispatcher.php at line 63
XF\Mvc\Dispatcher->run() in src/XF/App.php at line 2840
XF\App->run() in src/XF.php at line 844
XF::runApp() in admin.php at line 15
 
Also this is probably user error, but my placeholder is a missing image icon. No text. No background color. Even with the Advertise Here link enabled. What is causing that? Package is banner with 0 ads.
 
Last edited:
Problem now is, can't remove the broken image icon because can't disable placeholders, double whammy! 😭😭
 
Back
Top Bottom