Ads Manager 2 by Siropu

Ads Manager 2 by Siropu [Paid] 2.6.3

No permission to buy (€49.99)
Hello @Siropu
Our marketing team requested we add a close button to the ads, just as the footer_fixed position has.
It seemed quite simple- just change the relevant macro in the siropu_ads_manager_ad_macros template
HTML:
<xf:macro name="close_button" arg-position="">
    <xf:if is="$position">
        <a role="button" class="samCloseButton" data-xf-click="sam-close"><xf:fa icon="fas fa-times-square" /></a>
    </xf:if>
    ...
(basically make it appear in all positions)
Since I could not see the close button in all the positions- I tried adding position: relative; to the ad, but then- the ad views were not registered at all!
So I added an else condition with specific positions that the close button appeared well in them:
HTML:
<xf:elseif is="$position == 'big_main_banner' OR $position == 'right_of_page_body' OR $position == 'left_of_page_body'" />
        <a role="button" class="samCloseButton" data-xf-click="sam-close" style="margin: 0; left: 0;">
            <xf:fa icon="fas fa-times-square" />
        </a>

This works. But I would still like the close button on other ads.
Did you notice this issue?

Thanks
Hello @Siropu
I think you missed this message...

Is it possible to add a close button to all the ad positions?
 
Siropu updated Ads Manager 2 by Siropu with a new update entry:

Improvements & Bug Fixes

Added keyword and affiliate link ad type support for Bob's Classifieds add-on.
Added new position criteria for Bob's Classifieds add-on: "Item ID is" and "Item ID is Not".
Added ad setting to display a close button for users to hide the ad.
Added widget option for featured threads to select which ad type to display: sticky, promo or both.
Added "Notes" tab to ads where you can keep notes regarding the changes you have made.
Added "Max invoice amount" option to promo codes.

Fixed an issue...

Read the rest of this update entry...
 
Added widget option for featured threads to select which ad type to display: sticky, promo or both.
Added "Max invoice amount" option to promo codes.


SWEET! Two of my suggestions, thanks. I had another one. Can we assign a prefix when a promo thread expires? My forum uses a prefix in every forum so it looks odd when it is stripped. I could assign an expired prefix or similar. The ability to keep the current prefix and not strip could also be useful. Just some ideas. Thanks!
 
Back
Top Bottom