Hello
@Siropu
Our marketing team requested we add a close button to the ads, just as the
footer_fixed position has.
It seemed quite simple- just change the relevant macro in the
siropu_ads_manager_ad_macros template
HTML:
<xf:macro name="close_button" arg-position="">
<xf:if is="$position">
<a role="button" class="samCloseButton" data-xf-click="sam-close"><xf:fa icon="fas fa-times-square" /></a>
</xf:if>
...
(basically make it appear in all positions)
Since I could not see the close button in all the positions- I tried adding position: relative; to the ad, but then- the ad views were not registered at all!
So I added an else condition with specific positions that the close button appeared well in them:
HTML:
<xf:elseif is="$position == 'big_main_banner' OR $position == 'right_of_page_body' OR $position == 'left_of_page_body'" />
<a role="button" class="samCloseButton" data-xf-click="sam-close" style="margin: 0; left: 0;">
<xf:fa icon="fas fa-times-square" />
</a>
This works. But I would still like the close button on other ads.
Did you notice this issue?
Thanks