Ads Manager 2 by Siropu [Paid] 2.6.3

[80sDude]

Can I put adsense ads in between posts with this? Thanks!

 

[Sal Collaziano]

Can I put adsense ads in between posts with this? Thanks!

You can.

 

[Andy.N]

Just checking in to see if HTML5 is being supported now. I searched and it was asked in 2021 and @Siropu said "No idea yet".

 

[Orit]

Hello @Siropu
Our marketing team requested we add a close button to the ads, just as the footer_fixed position has.
It seemed quite simple- just change the relevant macro in the siropu_ads_manager_ad_macros template

<xf:macro name="close_button" arg-position="">
    <xf:if is="$position">
        <a role="button" class="samCloseButton" data-xf-click="sam-close"><xf:fa icon="fas fa-times-square" /></a>
    </xf:if>
    ...

(basically make it appear in all positions)
Since I could not see the close button in all the positions- I tried adding position: relative; to the ad, but then- the ad views were not registered at all!
So I added an else condition with specific positions that the close button appeared well in them:

<xf:elseif is="$position == 'big_main_banner' OR $position == 'right_of_page_body' OR $position == 'left_of_page_body'" />
        <a role="button" class="samCloseButton" data-xf-click="sam-close" style="margin: 0; left: 0;">
            <xf:fa icon="fas fa-times-square" />
        </a>

This works. But I would still like the close button on other ads.
Did you notice this issue?

Thanks

Hello @Siropu
I think you missed this message...

Is it possible to add a close button to all the ad positions?

 

[Siropu]

Just checking in to see if HTML5 is being supported now.

Not supported yet.

Is it possible to add a close button to all the ad positions?

It is possible. I will consider it.

 

[Siropu]

I just did some testing and advertiser is not getting added to the secondary user group specified in the Advertising settings.

I don't see any issues with it. Advertiser is added to the user group when the ad is active and removed when inactive.

Is it possible the errror can be removed?

Haven't seen this issue but I'm not planing to make changes to the notices page.

 

[beerForo]

Haven't seen this issue but I'm not planing to make changes to the notices page.

That's fine, I can ignore the warning banner. I'm just waiting for the update with the Max Value field for promo codes, so I can send one to a client.

 

[Siropu]

Siropu updated Ads Manager 2 by Siropu with a new update entry:

Improvements & Bug Fixes

Added keyword and affiliate link ad type support for Bob's Classifieds add-on.
Added new position criteria for Bob's Classifieds add-on: "Item ID is" and "Item ID is Not".
Added ad setting to display a close button for users to hide the ad.
Added widget option for featured threads to select which ad type to display: sticky, promo or both.
Added "Notes" tab to ads where you can keep notes regarding the changes you have made.
Added "Max invoice amount" option to promo codes.

Fixed an issue...

Read the rest of this update entry...

 

[beerForo]

Thank you for the update.

 

[beerForo]

Added widget option for featured threads to select which ad type to display: sticky, promo or both.
Added "Max invoice amount" option to promo codes.

SWEET! Two of my suggestions, thanks. I had another one. Can we assign a prefix when a promo thread expires? My forum uses a prefix in every forum so it looks odd when it is stripped. I could assign an expired prefix or similar. The ability to keep the current prefix and not strip could also be useful. Just some ideas. Thanks!

 

[JulianD]

Hello, I see the addon does not supports custom thread types, and only shows the default thread types (Discussion, Poll, Article, Suggestion and Question). I have a custom thread type which contains affiliate link ads but they are not being processed, I guess that's the reason because normal threads work as usual. Any ideas if this could be supported? Or maybe I'm doing something wrong?

 

[MentaL]

ACP > Setup > Options > Ads Manager [General]
Scroll at the end of the list and you will find the options.

Has this been removed? Latest version doesn't allow me to edit samBannerUnit to a bypassable type.

EDIT: had to edit style property to update.

 

[beerForo]

Bug: Min and Max Invoice and Discount values will not allow decimals. Example: Enter $37.50 and you are prompted to use a value between 37 and 38.

 

[beerForo]

I have found a few bugs. I am still testing it but one is this bug:
We’re sorry, this promo code is not applicable to purchases over $0.00.
Leaving max value as 0 should mean there is no limit. But a code will not work unless you define max value.

 

[Siropu]

Bug: Min and Max Invoice and Discount values will not allow decimals. Example: Enter $37.50 and you are prompted to use a value between 37 and 38.

Not actually a bug. That's how number box works in XF. Do you really need a decimal in this case?

We’re sorry, this promo code is not applicable to purchases over $0.00

Will look into it.

 

[beerForo]

Not actually a bug. That's how number box works in XF. Do you really need a decimal in this case?

I do yes. I noticed when inspecting the elements the "step" was 1. I edited it to .5 in the browser inspector and was able to save the discount to $37.50 (shows as 37.5). I'd love to not have to hack this. Many max invoices or discount amounts may be 19.99, 25.50, etc.

 

[Siropu]

I have a custom thread type which contains affiliate link ads but they are not being processed,

Is it from a custom add-on that can be purchased here? If you use "Enable page info" in admin options and view that thread it should tell you the name of the template and I can add it.

 

[JulianD]

Is it from a custom add-on that can be purchased here? If you use "Enable page info" in admin options and view that thread it should tell you the name of the template and I can add it.

Where can I add the template name to the code? It's a custom addon and if I release it, i'll let you know!

 

[Siropu]

Where can I add the template name to the code?

AdsManager/Listener.php


Add your template name to $threadTypes and your content type to $contentTypeMap