Ads Manager 2 by Siropu [Paid] 2.4.22

[Siropu]

Siropu updated Ads Manager 2 by Siropu with a new update entry:

Improvements & Bug Fixes

• Added ad option to include ads created from ACP in the advertiser list.
• Added package option to set a limit on how many ads an advertiser can create.
• Added admin option to display the advertiser section in the user account.
• Added bank transfer option as a payment profile.
• Added {match} placeholder support for affiliate link ad option "Replace affiliate website with URL".
• Free packages will now display "Free (x length)" in package list and ad creation page...

Read the rest of this update entry...

 

[Chernabog]

Siropu updated Ads Manager 2 by Siropu with a new update entry:

Improvements & Bug Fixes



Read the rest of this update entry...

YAY! Ad Manager in member account -- you ROCK!

 

[nocte]

I think there's a bug:

I have set "Edit own ads without admin approval" to "no" for registered users. But if I login as a normal user and edit an ad, it stays active.

Another suggestion: Views and CTR should not be displayed to the advertiser if views are not counted, because in that case this does not make sense.

 

[Siropu]

But if I login as a normal user and edit an ad, it stays active.

What changes have you made?

 

[nocte]

What changes have you made?

oh, i see now: When I change the url, the ad has to be re-approved, otherwise not. Why not when changing the banner image?

 

[Siropu]

Why not when changing the banner image?

It should require re-approval for that as well. I will do some testing.

 

[Joe Link]

Getting this when trying to create a package:

XF\Db\Exception: MySQL statement prepare error [1054]: Unknown column 'advertiser_purchase_limit' in 'field list' in src/XF/Db/AbstractStatement.php at line 212
XF\Db\AbstractStatement->getException() in src/XF/Db/Mysqli/Statement.php at line 196
XF\Db\Mysqli\Statement->getException() in src/XF/Db/Mysqli/Statement.php at line 39
XF\Db\Mysqli\Statement->prepare() in src/XF/Db/Mysqli/Statement.php at line 54
XF\Db\Mysqli\Statement->execute() in src/XF/Db/AbstractAdapter.php at line 79
XF\Db\AbstractAdapter->query() in src/XF/Db/AbstractAdapter.php at line 160
XF\Db\AbstractAdapter->insert() in src/XF/Mvc/Entity/Entity.php at line 1389
XF\Mvc\Entity\Entity->_saveToSource() in src/XF/Mvc/Entity/Entity.php at line 1121
XF\Mvc\Entity\Entity->save() in src/XF/Mvc/FormAction.php at line 69
XF\Mvc\FormAction->XF\Mvc\{closure}() in src/XF/Mvc/FormAction.php at line 159
XF\Mvc\FormAction->run() in src/addons/Siropu/AdsManager/Admin/Controller/Package.php at line 65
Siropu\AdsManager\Admin\Controller\Package->actionSave() in src/XF/Mvc/Dispatcher.php at line 249
XF\Mvc\Dispatcher->dispatchClass() in src/XF/Mvc/Dispatcher.php at line 88
XF\Mvc\Dispatcher->dispatchLoop() in src/XF/Mvc/Dispatcher.php at line 41
XF\Mvc\Dispatcher->run() in src/XF/App.php at line 1931
XF\App->run() in src/XF.php at line 328
XF::runApp() in admin.php at line 13

 

[Joe Link]

When trying to uninstall (in order to reinstall) I got this:

ErrorException: [E_WARNING] include(/home/domain/public/internal_data/code_cache/phrase_groups/l1/siropu_ads_manager_ad_type.php): failed to open stream: No such file or directory in src/XF/Language.php at line 274
XF::handlePhpError() in src/XF/Language.php at line 274
include() in src/XF/Language.php at line 274
XF\Language->loadPhraseGroup() in src/XF/Language.php at line 237
XF\Language->getPhraseText() in src/XF/Template/Compiler/Fn/Phrase.php at line 113
XF\Template\Compiler\Fn\Phrase->compile() in src/XF/Template/Compiler/Syntax/Fn.php at line 28
XF\Template\Compiler\Syntax\Fn->compile() in src/XF/Template/Compiler/Syntax/Expression.php at line 22
XF\Template\Compiler\Syntax\Expression->compile() in src/XF/Template/Compiler.php at line 237
XF\Template\Compiler->traverseBlockChildren() in src/XF/Template/Compiler.php at line 219
XF\Template\Compiler->compileAst() in src/XF/Service/Template/Compile.php at line 24
XF\Service\Template\Compile->recompile() in src/XF/Service/Phrase/Compile.php at line 71
XF\Service\Phrase\Compile->recompileIncludeContent() in src/XF/Entity/Phrase.php at line 198
XF\Entity\Phrase->_postDelete() in src/XF/Mvc/Entity/Entity.php at line 1517
XF\Mvc\Entity\Entity->delete() in src/XF/AddOn/DataType/AbstractDataType.php at line 117
XF\AddOn\DataType\AbstractDataType->deleteEntity() in src/XF/AddOn/DataType/AbstractDataType.php at line 103
XF\AddOn\DataType\AbstractDataType->deleteAddOnData() in src/XF/Job/AddOnUninstallData.php at line 54
XF\Job\AddOnUninstallData->run() in src/XF/Job/Manager.php at line 241
XF\Job\Manager->runJobInternal() in src/XF/Job/Manager.php at line 187
XF\Job\Manager->runJobEntry() in src/XF/Job/Manager.php at line 103
XF\Job\Manager->runByIds() in src/XF/Admin/Controller/Tools.php at line 120
XF\Admin\Controller\Tools->actionRunJob() in src/XF/Mvc/Dispatcher.php at line 249
XF\Mvc\Dispatcher->dispatchClass() in src/XF/Mvc/Dispatcher.php at line 88
XF\Mvc\Dispatcher->dispatchLoop() in src/XF/Mvc/Dispatcher.php at line 41
XF\Mvc\Dispatcher->run() in src/XF/App.php at line 1931
XF\App->run() in src/XF.php at line 328
XF::runApp() in admin.php at line 13

 

[Siropu]

When trying to uninstall (in order to reinstall) I got this:

You get this every time you try to uninstall? It is not a bug with Ads Manager itself.

P.S. Redownload the latest version, if you want to reinstall. It contains a fix for the package issue.

 

[Joe Link]

You get this every time you try to uninstall? It is not a bug with Ads Manager itself.

P.S. Redownload the latest version, if you want to reinstall. It contains a fix for the package issue.

Yep, every time I've tried to uninstall it. Any idea what it might be?

I'm installing the updated package now.

 

[Siropu]

Any idea what it might be?

It looks like XF bug to me.

 

[shining]

Getting this when trying to create a package:

XF\Db\Exception: MySQL statement prepare error [1054]: Unknown column 'advertiser_purchase_limit' in 'field list' in src/XF/Db/AbstractStatement.php at line 212
....

Same here without any work on this add-on. Updated 2 days ago... now this error shows up.

 

[Siropu]

If you have upgraded from an older version, you shouldn't get this error after the upgrade is complete.

 

[shining]

That was an update from 2.0.6 to 2.1.3

 

[Siropu]

So if you now edit and save a package, you get that error?

 

[shining]

No, seems like this error only came up with the update itself.
By saving changes to an add no error apears. (Did not have to change a package yet)

 

[Siropu]

Did not have to change a package yet

Just hit save without changing anything.

 

[clackey]

Any chance this might support more than just country selection for geo location ads in the future? I realize it might require a subscription to maxmind or similar service for real-time location detection.

 

[Siropu]

It is something I'm considering in the future.

 

[gforce]

i'm still running 2.0 like a champ