Add-on Install & Upgrade 1.4.3

[Moshe1010]

I have pretty weird problem. I see updates available in the add-on list itself, but not on the menu sidebar in the ACP. Any idea? It shows [0] all the time regardless if there are updates or not.
Thanks.

 

[Chris D]

Have you modified the phrase used in the sidebar?

 

[Moshe1010]

Have you modified the phrase used in the sidebar?

I see the issue. Was it changed in the last updates or it's my bad translation skills ?

 

[Liam W]

@Chris D

Where is the directory created? I recently switched from suPHP and therefore 777 the data and relevant internal_data directories, but this is giving me a unable to create directory error when truing to upgrade an add-on...

 

[Chris D]

install/addons

 

[The Grand Potentate]

Chris - I had a bunch of Waindigo add-ons randomly shift from ok into needing an upgrading yesterday, despite them not having a new version. I upgraded them all, stupidly, without looking. Well today they're all back again. Just thought I'd let you know in case it was something you were tracking.

Also, this add-on: https://xenforo.com/community/resources/new-user-conversation.3644/

Never stops telling me it needs updating no matter how many times I dismiss it.

 

[Chris D]

Yeah that happens when developers update the version number in the RM without updating the version number in the download.

You can ignore an update though so do that to shut it up.

 

[The Grand Potentate]

Yeah that happens when developers update the version number in the RM without updating the version number in the download.

You can ignore an update though so do that to shut it up.

Yeah, I figured on the Waindigo front. The weird thing about the Andy add-on is that no matter how many times I ignore it, it always comes back. I have some of his other add-ons and they work fine. Just not that one.

 

[Chris D]

What version do you have installer according to the list of add ons?

 

[The Grand Potentate]

Here you go

 

[Liam W]

For some reason, this isn't working on my live site with my latest addon update...

The files don't seem to copy over correctly. The XML file does appear to be being imported correctly though.

Any ideas?

Liam

 

[Liam W]

Oh.

It appears all of my addon updates have been going into a secondary library directory, inside the existing library directory.

I only just noticed...

Whoops.

@Chris D any ideas? This is my general structure:

download_zip.zip
----UPLOAD
--------library
------------LiamW
----------------<addon files>
----addon XML

These have been going into <xf root>/library/library/LiamW/<addon files> for some reason.

 

[Chris D]

Hmm...

Does it make any difference if it's upload rather than UPLOAD ?

 

[rdn]

Try to change "UPLOAD" folder to "upload" ?

 

[Liam W]

Hmm...

Does it make any difference if it's upload rather than UPLOAD ?

Try to change "UPLOAD" folder to "upload" ?

Yeah, that worked.

But I like using upper case for the UPLOAD directory

 

[Chris D]

I will more than likely change it, but that's the best practice for now.

It's worth noting, however, that "upload" in lower case is usually more consistent with XenForo, official XenForo add-ons and most third party developers.

 

[Liam W]

It's worth noting, however, that "upload" in lower case is usually more consistent with XenForo, official XenForo add-ons and most third party developers.

It's hard to break an established habit, but I'll bare that in mind.

Liam

 

[refael]

I have a similar issue that library and js are uploaded inside library and js.
I tracked that down to AddOnInstaller_ControllerAdmin_AddOn #259

elseif ($key == 'js' || $key == 'library' || $key == 'styles')
{
    $addOnModel->recursiveCopy($dir . '/..', './' . $key);
}

Removing the '/..' from the dir fixed the issue.

elseif ($key == 'js' || $key == 'library' || $key == 'styles')
{
    $addOnModel->recursiveCopy($dir, './' . $key);
}

I don't know why you needed to add that, so I don't know if that will make another issues, but hope it will help in some way.

 

[Chris D]

Thanks @rellect

I will do some testing with that. I can reproduce the issue. I am wondering whether it is a difference in how the file system handles it. I would have originally developed it on Windows; presumably it worked at that point.

It's worth noting, too, that I rewrote some of this recently and I can't produce it in that version at all, so it might be time to release that updated code.

@pegasus, just so you know, I am still looking into the Vault Wiki issue. As you can appreciate with nearly 1500 downloads if my code was dropping blank index.html everywhere then this will have cropped up before. At the risk of complicating what I'm about to say... actually, it did crop up once before but that was a specific change I made which specifically created directories using the XenForo File helper which has an option to create a blank index.html however this very much so isn't the case any more, and I can reproduce it with your add-on. There isn't anything obviously wrong in the way your add-on is packaged, nor the way my code should handle it, so it's very peculiar. I am looking into it though.

@Liam W can you give me access to one of your add-ons that behaves wrong. I tried with one and it seemed to work fine, though this may also be an OS behaviour hence why I can't reproduce it, but I will be testing it cross platform to be sure.

 

[m1ne]

Hey Chris.

Since updating to the latest version, installing/updating any addon results in the forum going offline (Cloudflare). I then have to click "Retry for live version", and click the manual rebuild option.
Any ideas? This does not happen when uploading files and importing xml.