Add-on Install & Upgrade 1.4.3

[Arkshine]

Chris, for the add-ons where it detects an update and actually there is not because of incorrect string version, could you add a link in the overlay which says "Add-on is fully up to date." to ignore this update ?

 

[Chris D]

That's already a feature.

When you click the Check for Updates button:



Ignore this update logs the current version string and doesn't notify you there's an update until that version string changes again.

 

[xf_phantom]

Not going to happen.

Your add on would actually be the first I've seen that is released in two separate packages and I feel it's not ideal.

Is there any reason you can't make your add on backwards compatible with 1.1.x?

what about providing a callback before the addon installation where the addon coder can define the xml and data paths?

e.g. like this pseudocode
addoninstallercallback.php
if xenforo_version < 1.1.2


another great addition would be a batch process to install dozen addons at once, this could even be enhanced to some sort of composer alternative (e.g. addon X requires addon Y... before addon X is being installed, addon Y will be isntalled automatically, if the zip url is available.

e.g.

$config = array(
'dependencies' => array(
array(addon_id => foo, min_version_id => 11111, 'fetch_url' => ..),
array(addon_id => tms)
)


with this one would just need to create a "my addons startpackage" with the commands file (including the dependencies and urls) and everything would be installed automatically

 

[Chris D]

I don't want to create any code that supports the continued use of old XenForo versions. Most, if not all, of my add-0ns going forward will be exclusively for XenForo 1.2.

I recommend all add-on developers doing the same.

 

[Arkshine]

Chris I'm well aware of that. I'm talking on some addons, where you don't have this overlay but instead this one :

And you can you do nothing to ignore it.

I don't use thi add-on on screnshot, but I have others add-on which does that :

- [******] Custom Node Icon
- XF Arcade
- WDB Extra Stats
- Show the Hooks
- Pastebin.com BBcode mediasite

 

[Chris D]

another great addition would be a batch process to install dozen addons at once

I missed this bit earlier.

My add-on already allows you to install multiple add-ons at once.

Just upload multiple zips and it extracts them all and installs them all.

There's no dependencies though. That itself could be a good feature.

 

[rdn]

I missed to read this:

DO NOT UPGRADE USING THE ORIGINAL ADD-ON INSTALLER.

But already tried it, and I guess it works.

 

[Chris D]

That comment was more about upgrading the beta version to the 1.0 version.

I myself upgraded to the latest version.

But caution should be exercised because there are sometimes changes in the code that could cause errors.

So, actually. The advice still stands. Do not upgrade the installer with the installer.

 

[AdamD]

Hi Chris, does this work aok on 1.2?
I noticed since removing then installing 1.04 on XF 1.2, the menu items don't work in the admin panel.
Both links show -
The requested page could not be found.

 

[Chris D]

Yep it works on 1.2.

You should manually upload the files to your server and install/upgrade with the XML file.

Seems to me like the correct files aren't present.

 

[AdamD]

Hmm, yea I definitely did that
I've reuploaded three times now just to be sure,
I've just uninstalled and am now reinstalling the XML file.
Hmm odd, same problem.

 

[AdamD]

Tried running the cronjob -Automatic Check for Add-on Updates

got:

Fatal error: Call to undefined method XenForo_Model_AddOn::getAllUpdateChecks() in /home/theguard/public_html/library/AddOnInstaller/CronEntry/UpdateCheck.php on line 11

 

[Robby]

Hello, Great addon, wich url to put for original resource manager from xenforo?

 

[Chris D]

Chris Deeming updated Add-on Install & Upgrade with a new update entry:

Blank index.html issue

I think I may have identified a circumstance where blank index.html files were being created (often used to prevent direct access to a folder) where they shouldn't be.

This update ensures that blank index.html files are not created.

Read the rest of this update entry...

 

[Gazhyde]

@Chris Deeming - I'm so glad you spotted this as it disabled my board! Your update came just at the right time for me to sort the issue out.

Made some edits elsewhere in the templates, and my forum went blank. Found an index.html in my forum folder which when renamed, fixed it... Phew!

 

[Chris D]

Yeah sorry about that.

Worryingly, the "broken" update has been out for weeks but it's only just come up now... Not sure what triggered it. Must be a certain add-on that's packaged in a certain way that meant when recursively creating the directories it threw a blank HTML in the root, or similar.

 

[Gazhyde]

Yeah sorry about that.

No problems at all on that Chris, just pleased to get a solution dropped in my lap! Hopefully my one and only 'official' support ticket created and closed!

If it helps, I just completed upgrading to 1.2. Had removed the version I was running on 1.1.4 and then upgraded it to the 'latest' version available by uploading and then importing the xml file.

I then used it to import about 6 updated add-ons from Zip files without issue. Went away and did some other stuff like a celebratory "we are now upgraded to 1.2" post, and general tinkering.

This issue only happened when I imported MattW's "Back to the Top" from the freshly downloaded zip. It's subsequently imported fine using the version you just released.

 

[MattW]

and all that add-on contains is the XML file and a JS folder

 

[Arkshine]

Still no fix for the issue where some add-on have bad version string and we can't skip update ? :/

 

[Chris D]

No. Not yet.

Primarily it is down to the add-on developer to ensure the version string they provide in their add-on XML file matches that of the one on the Resource Manager.