Fixed XF:action_groups:start and XF:action_groups:end in wrong place

[Jon W]

Affected version

2.1.0

Possibly too late to move now as someone might be using them, although I would be surprised as I can't think of any reason why anyone would want to use them in their current position.

Wouldn't it make more sense to put them outside of the <xf:if contentcheck="true"> and </xf:if> tags?

 

[DragonByte Tech]

Maybe I'm misunderstanding, but why does that make a difference?

If you want to add new buttons, you can use the <!--[XF:action_group_$:start]--> (where $ is a number) or corresponding end block depending on where you want it to go.

 

[Jon W]

Maybe I'm misunderstanding, but why does that make a difference?

If you want to add new buttons, you can use the <!--[XF:action_group_$:start]--> (where $ is a number) or corresponding end block depending on where you want it to go.

Right, if I wanted them in the same button group, then I would use those hooks, exactly.

But if I want a new button group, I want to add it outside of the <xf:if contentcheck="true"> and <xf:if> tags. If I add it inside those tags, it will only appear if those other buttons are visible, which means I have no control over whether my button is visible or not.

 

[Jon W]

The <!--[XF:action_groups:middle]--> hook is in the correct place.

 

[Chris D]

I do see your point so we've just added two new positions to cover it.

XF:action_groups:outer_start which appears outside of the initial <xf:if contentcheck="true"> and XF:action_groups:outer_end which appears outside of the corresponding </xf:if>.

You'll have to bear in mind that as these are new positions they will only exist in XF 2.1.1 and above so you may want to consider making any add-ons which use them require XF 2.1.1.

 

[XF Bug Bot]

Thank you for reporting this issue. It has now been resolved and we are aiming to include it in a future XF release (2.1.1).

Change log:

Add new template extension points for member_macros in the XF:action_groups:outer_start and XF:action_groups:outer_end positions.

Any changes made as a result of this issue being resolved may not be rolled out here until later.

 

[Snog]

XF:action_groups:outer_start which appears outside of the initial <xf:if contentcheck="true"> and XF:action_groups:outer_start which appears outside of the corresponding </xf:if>.

I hope you mean XF:action_groups:outer_start and XF:action_groups:outer_end

 

[Chris D]

Yeah trust @XF Bug Bot more than me in this case

(I wrote what he said too but )