Xen Notices [Deleted]

[Chris D]

You could try that if it isn't too much trouble. You could export your xf_notification and xf_notification_dismissed tables first. If reinstalling makes no difference you could always just re-import those tables.

Struggling to envisage what could be causing this...

Have you disabled all notifications apart from a single one with no criteria?

 

[Chris D]

Wait a minute... do you have Notices switched off completely?

 

[Martok]

Wait a minute... do you have Notices switched off completely?

Bingo!

Switching Notices back on has made the notifications appear again!

Does Notifications 1.7.x require Notices to be enabled? The previous version didn't and as I wasn't using the standard Notices system, I switched it off.

 

[Chris D]

Yes.

The code was all handled in template hooks before. They are deprecated and although they work now, I can't guarantee they'll stay working.

So I basically use the notices_prepare event now. It has access to the PAGE_CONTAINER template, a template object and container data. Basically everything I need all in one place.

I guess the only "down side" is that it requires Notices to be enabled. But, at the same time, having Notices enabled has no adverse effects, no additional query overhead on page load, etc.

 

[Martok]

Yes.
.
The code was all handled in template hooks before. They are deprecated and although they work now, I can't guarantee they'll stay working.

So I basically use the notices_prepare event now. It has access to the PAGE_CONTAINER template, a template object and container data. Basically everything I need all in one place.

I guess the only "down side" is that it requires Notices to be disabled. But, at the same time, having Notices disabled has no adverse effects, no additional query overhead on page load, etc.

Sorry, I'm slightly confused here. You say "Yes" that Noticed need to be enabled, but in your last sentence you say that Notices need to be disabled. Please can you clarify?

If Notices do indeed need to be enabled, you might want to add that to the resource description.

 

[Chris D]

Typo. Yes, notices need to be enabled.

 

[Martok]

Typo. Yes, notices need to be enabled.

Anyway, thanks for sorting this before I attempted an uninstall and reinstall. I guess then that I'm the only Notifications user who had switched off Notices. Either that or the only one so far to discover that it doesn't work when it's switched off.

 

[kontrabass]

I'm sad. Didn't save my last download email and I'm not getting any new ones. Checked spam. :hiding:

Forgot it was sent to my paypal email. I'm an idiot, and hiding under a rock now.

 

[Chris D]

The email I have on file for you is accounting@...

Have you been checking the right email account?

 

[Sunka]

Some server error.
Notifications v1.7.2
XenForo v1.3

Error Info
ErrorException: Fatal Error: syntax error, unexpected end of file - library/GritterNotifications/Listener.php:47
Generated By: Unknown Account, Today at 4:34 PM
Stack Trace

#0 [internal function]: XenForo_Application::handleFatalError()
#1 {main}

Request State

array(3) {
  ["url"] => string(62) "http://www.pijanitvor.com/archive/index.php/t-12404.html?pda=1"
  ["_GET"] => array(1) {
    ["pda"] => string(1) "1"
  }
  ["_POST"] => array(0) {
  }
}

 

[Chris D]

The URL above appears to be working now.

Has this happened only once or does it keep happening?

The time the error was logged, was that roughly the time you were perhaps uploading updated files?

 

[Sunka]

Just happened once.
No uploading anything, I was not on forum on that time.

 

[Chris D]

The reason I asked is Line 47 as mentioned in the error is far from the end of the file as the error suggests. So it's usually indicative of some sort of file system error such as you might get if a file was only partially uploaded.

If it has only happened once, it's probably nothing to worry about. Let me know if it happens again.

 

[Liam W]

I've got a template error:

Template Errors: PAGE_CONTAINER
Invalid argument supplied for foreach() in /home/xfliam/public_html/library/XenForo/Template/Abstract.php(265) : eval()'d code, line 591:
590:     ';
591: foreach ($notifications AS $notificationId => $notification)
592: {

It appeared after I added a notification for a specific forum node. That appeared on the forum list.

EDIT: The template error appears in the node the notification is set to appear in.

Liam

 

[Chris D]

Yeah think I caught that last night.

Turn off Debug mode

 

[Liam W]

Yeah think I caught that last night.

Turn off Debug mode

It's on for my IP only

 

[Chris D]

Only you'll see the error then, but it's fixed in 1.7.3 which will be released later today/tomorrow.

This is quite a new bug, actually. Prior to 1.7.0, the template would only ever have been injected into its template hook if there were Notifications.

Because I don't use template hooks anymore and because the template modification is inserted into the PAGE_CONTAINER regardless, it requires an additional check in the template to see if there are any notifications or not.

If you wanted to fix it now, it's just as you'd expect. Above:

<xen:foreach loop="$notifications" key="$notificationId" value="$notification">

Add:

<xen:if is="{$notifications}">

And of course </xen:if> at the bottom, after the loop closes.

 

[Liam W]

OK. No notifications are showing however...

The error didn't start until I added the last notification (I think). Is there a way I can stop it from happening until the update?

 

[Chris D]

Read my edit above.

 

[Liam W]

Ok, another strange bug...

No notifications are appearing now...

EDIT: If notices are disabled, then notifications are disabled to... I'm assuming this isn't intended?