Kevin
Well-known member
Isn't that what it's supposed to do? I'm not seeing where turning on test mode would only generate just one one email, just that that all emails get redirected to the 'Test Email Address' instead.
What's New Digest 5.0.6
- Thread starter Sim
- Start date
Sim
Well-known member
Yes @Sunka - @Kevin is correct, it has done exactly what that option says it will do.
If you want to test sending just one email, there is a function in Admin > Tools to do that.
I admit that the Test Mode setting in Options isn't especially useful when you already have a large number of users registered - it was more intended for use in development. I might limit it to sending 5 emails or something.
To disable sending emails by default, you should set Default Frequency to "None" - in which case only users who have explicitly chosen to receive the emails will get them. To disable sending emails completely, you should turn off the two Cron jobs.
Sim
Well-known member
1. From the FAQ:
Q) How many threads are included?
A) Up to 10 "New" threads (ie created within the last week or last 24 hours, ordered by most replies), plus up to 10 "Updated" threads (ordered by most number of replies made in the last week or 24 hours).
2. I'm really busy working on porting all of my other addons to XF2 right now in preparation for upgrading my 8 sites - I will revisit feature requests once I have time to do so.
Creaky
Well-known member
Can other content types be added to this?
I use Bob’s Article Management System and would like to include any new articles in the email.
This is the demo for the add on, https://demos.xenaddons.com/articles/
I use Bob’s Article Management System and would like to include any new articles in the email.
This is the demo for the add on, https://demos.xenaddons.com/articles/
PHP 7.3.2
MariaDB 10.3.12
XF 2.1.0
Error
MariaDB 10.3.12
XF 2.1.0
Error
Code:
Server error log
ErrorException: [E_NOTICE] compact(): Undefined variable: total src/addons/Hampel/WhatsNewDigest/XF/Admin/Controller/Tools.php:80
Generated by: Admin Feb 11, 2019 at 3:52 AM
Stack trace
#0 [internal function]: XF::handlePhpError(8, '[E_NOTICE] comp...', '/home/nginx/dom...', 80, Array)
#1 src/addons/Hampel/WhatsNewDigest/XF/Admin/Controller/Tools.php(80): compact('users', 'newThreads', 'updatedThreads', 'test', 'period', 'total', 'done', 'messages')
#2 src/XF/Mvc/Dispatcher.php(321): Hampel\WhatsNewDigest\XF\Admin\Controller\Tools->actionWhatsNewDigestTest(Object(XF\Mvc\ParameterBag))
#3 src/XF/Mvc/Dispatcher.php(244): XF\Mvc\Dispatcher->dispatchClass('XF:Tools', 'WhatsnewdigestT...', Object(XF\Mvc\RouteMatch), Object(Hampel\WhatsNewDigest\XF\Admin\Controller\Tools), NULL)
#4 src/XF/Mvc/Dispatcher.php(100): XF\Mvc\Dispatcher->dispatchFromMatch(Object(XF\Mvc\RouteMatch), Object(Hampel\WhatsNewDigest\XF\Admin\Controller\Tools), NULL)
#5 src/XF/Mvc/Dispatcher.php(50): XF\Mvc\Dispatcher->dispatchLoop(Object(XF\Mvc\RouteMatch))
#6 src/XF/App.php(2177): XF\Mvc\Dispatcher->run()
#7 src/XF.php(390): XF\App->run()
#8 admin.php(13): XF::runApp('XF\\Admin\\App')
#9 {main}
Request state
array(4) {
["url"] => string(36) "/admin.php?tools/whatsnewdigest-test"
["referrer"] => string(60) "https://www.site.com/admin.php?tools/whatsnewdigest-test"
["_GET"] => array(1) {
["tools/whatsnewdigest-test"] => string(0) ""
}
["_POST"] => array(4) {
["test"] => string(5) "users"
["period"] => string(5) "daily"
["_debug"] => string(1) "0"
["_xfToken"] => string(8) "********"
}
}
Kevin
Well-known member
Just curious follow-up... have you modified your XF email template, or at least your whatsnewdigest_email template, or are you still using the defaults?
Amphicar770
Active member
Great concept and a much needed feature.
I just installed and ran the test tool to see which users will receive a daily digest. I was surprised to see a very lengthy list.
Is the default behavior to subscribe users to the digest upon install of the add-on? That's not a good thing as many will object to getting emails they did not opt-in to.
Is there a way to only send to those who have opted in either at or after registration?
I just installed and ran the test tool to see which users will receive a daily digest. I was surprised to see a very lengthy list.
Is the default behavior to subscribe users to the digest upon install of the add-on? That's not a good thing as many will object to getting emails they did not opt-in to.
Is there a way to only send to those who have opted in either at or after registration?
Sim
Well-known member
In the options, the "default" Default Frequency is set to
Weekly - which effectively makes it opt-out and means that everyone who has not explicitly chosen to not receive the emails by setting their personal preference to None (or Daily) will receive the weekly emails.Change the "Default Frequency" to
None which makes it opt-in and means that it will only send to members who have explicitly chosen to receive the daily or weekly emails.Amphicar770
Active member
DaveM
Well-known member
Every week after it runs I get the following error
Code:
Exception: Email to [unknown] failed setup: Trying to send email to user without email (ID: 2780) src/XF/Mail/Mail.php:83
Generated by: Unknown account Sep 23, 2019 at 2:52 AM
Stack trace
#0 src/addons/Hampel/WhatsNewDigest/Mail/Mailer.php(30): XF\Mail\Mail->setToUser(Object(Snog\Flags\XF\Entity\User))
#1 src/addons/Hampel/WhatsNewDigest/Cron/SendDigest.php(74): Hampel\WhatsNewDigest\Mail\Mailer->getMail(Object(Snog\Flags\XF\Entity\User), false)
#2 src/addons/Hampel/WhatsNewDigest/Cron/SendDigest.php(16): Hampel\WhatsNewDigest\Cron\SendDigest::sendDigest('weekly')
#3 [internal function]: Hampel\WhatsNewDigest\Cron\SendDigest::sendWeeklyDigest(Object(XF\Entity\CronEntry))
#4 src/XF/Job/Cron.php(35): call_user_func(Array, Object(XF\Entity\CronEntry))
#5 src/XF/Job/Manager.php(253): XF\Job\Cron->run(G)
#6 src/XF/Job/Manager.php(195): XF\Job\Manager->runJobInternal(Array, G)
#7 src/XF/Job/Manager.php(79): XF\Job\Manager->runJobEntry(Array, G)
#8 job.php(42): XF\Job\Manager->runQueue(false, 8)
#9 {main}
Request state
array(4) {
["url"] => string(8) "/job.php"
["referrer"] => string(28) "https://www.triumphtalk.com/"
["_GET"] => array(0) {
}
["_POST"] => array(0) {
}
}Sim
Well-known member
This is the key bit here:
Exception: Email to [unknown] failed setup: Trying to send email to user without email (ID: 2780) src/XF/Mail/Mail.php:83You have users in your database who don't have an email address assigned.
To work around this you should edit that user's preferences and set "Receive Email Digest" to
None
I'll add some code to ignore users with empty email addresses - but that might take me a couple of days to find time to release an update, pretty busy right now.
Sim
Well-known member
You mean there wasn't an entry in the user database for that user ID ?
DaveM
Well-known member
No it does not seem so
XF 2.1 - User ID - How do I Find User
I am running an error on one of my add ons and it gives me the User ID, how do I find the actual user for this ID?
xenforo.com
Sim
Well-known member
It sounds like you've got some more serious issues happening there if you can't even view members.
Take a look in your database and see what's actually going on - if you've got incomplete user records, that will cause all sorts of havoc. Is there a row for that user in the user table?
There has to be an entry in the user table for my addon to try and send them an email. If you can't actually access the user records, then you've got some database corruption or something happening.
The admin URL to edit a user will look like this:
Try disabling all addons and see if that makes a difference - there is a chance that one of them is causing the issue of not being able view this user record.
Take a look in your database and see what's actually going on - if you've got incomplete user records, that will cause all sorts of havoc. Is there a row for that user in the user table?
There has to be an entry in the user table for my addon to try and send them an email. If you can't actually access the user records, then you've got some database corruption or something happening.
The admin URL to edit a user will look like this:
http://www.example.com/admin.php?users/1/edit ... change the number to the userid you want to view and change the domain to match your forum. If you get an error viewing your user - you need to diagnose that first before trying to sort out problems with my addon.Try disabling all addons and see if that makes a difference - there is a chance that one of them is causing the issue of not being able view this user record.
Similar threads
- Question
- Question
