Yes. I would never hire any of the people that have worked on vb5.
Not sure if it's fair to blame individual people for this.Yes. I would never hire any of the people that have worked on vb5.
/* ## This check is here on purpose, do not remove it ##
No. It is. There is no excuse what-so-ever for any of what I am reading.Not sure if it's fair to blame individual people for this.
I can't understand how anyone could be paid for this quality for work. I am literally just stunned going through the code.
I don't want to be pasting code but I will pick a random spot and explain the stupidity in it.Give us a taste(example)! I need to see the l33t codes that were on the white board that started this whole mess!
I don't want to be pasting code but I will pick a random spot and explain the stupidity in it.
switch ($theCase)
{
case 'slavik':
$class = 'Slavik';
break;
case 'robbo':
$class = 'Robbo';
break;
case 'namewithmixed':
$class = 'NameWithMixed';
break;
// etc
}
The file that starts everything off has a big switch statement, goes for 70 lines. All it does is convert lower case strings into case sensitive strings. So I'll make an example with peoples names here...
Now this is terrible for multiple reasons. It is used to take calls from their API to controllers or something.Code:switch ($theCase) { case 'slavik': $class = 'Slavik'; break; case 'robbo': $class = 'Robbo'; break; case 'namewithmixed': $class = 'NameWithMixed'; break; // etc }
First thing all they had to do for most of these is this...
$class = ucfirst($theCase);
However they also have a terrible design flaw in general which causes bad naming like the namewithmixed I did. All they had to do is something along the lines of make their api seperate words with "-". So name-with-mixed.
This would be easier to read, better design and more importantly they could use various methods to convert to their class that are way better than a massive switch.
it is a stellar example of why you cannot outsource software development to China.
// Set file
if ($fileVar)
{
$this->fileVar = $fileVar;
}
Source? Has it been said that vB5 development is outsourced?
I did think it smelled of outsourced code while reading it, that or they only hired juniors.
... sigh. Just... I've seen a heap of classes added before by JS libraries but really? And id="htmlTag"??Just saw this HTML code posted by DP:
<html id="htmlTag" xmlns="http://www.w3.org/1999/xhtml" xmlns:fb="http://www.facebook.com/2008/fbml" xml:lang="en-US" lang="en-US" dir="ltr" class=" js flexbox no-touch hashchange history rgba hsla multiplebgs backgroundsize borderimage borderradius boxshadow textshadow opacity cssanimations csscolumns cssgradients cssreflections csstransforms csstransforms3d csstransitions fontface generatedcontent cookies no-bgpositionshorthand cssfilters lastchild boxsizing mediaqueries no-overflowscrolling cssremunit subpixelfont pointerevents cssresize cssscrollbar filereader placeholder fileinput formvalidation no-firefox">
That is their opening HTML tag...
Edit, damn I think someone posted this already~!
I am just shocked.. I mean, this can't be what they are releasing, it just can't.. If this is close to the final VB 5 product, then it is a stellar example of why you cannot outsource software development to China. I am just in disbelief over here. I hope this isn't being too negative but wow, I just can't believe it! I tested this forum and it is like a stripped down version of PHPBB 1.0. I wish the lawsuit was over, because I can definitely see our migration to other platforms agenda moving away from the back burner. This is absolutely insane.
We use essential cookies to make this site work, and optional cookies to enhance your experience.