Fixed /threads/.../show-posts Soft 404

[Jake B.]

Affected version

1.5.10

I'm honestly not sure what this route is even supposed to do, but we're getting a ton of soft 404 errors in Google Search Console from this line:

return $this->responseError(new XenForo_Phrase('no_posts_matching_criteria_specified_were_found'));

 

[Chris D]

I believe the only place that is used is for the deleted message placeholder in threads. So I'm slightly confused why Google would even know about it, unless you have a system that displays deleted message placeholders to guests or similar?

Probably a valid report though. We should probably add a 404 code there.

 

[Jake B.]

I'm slightly confused why Google would even know about it, unless you have a system that displays deleted message placeholders to guests or similar?

Honestly have no idea, it's on a client's site and they've got a bunch of add-ons installed, so that may be the case

 

[Mike]

I've added a 404 code in this situation (and actually, a 406 for another related scenario, if the output can't be represented in the requested format).

 

[Jake B.]

Thanks!