1. This site uses cookies. By continuing to use this site, you are agreeing to our use of cookies. Learn More.

Threadmarks 1.3.0

Tag specific posts in a thread so they can be easily navigated to.

  1. Sidane

    Sidane Active Member

    Sidane submitted a new resource:

    Threadmarks - Tag specific posts in a thread so they can be easily navigated to.

    Read more about this resource...
     
    Digital Doctor likes this.
  2. tajhay

    tajhay Well-Known Member

    That looks awesome Si! Definately a much needed app for a sports forum! Thanks heaps mate!
     
  3. imthebest

    imthebest Formerly Super120

    I find the idea very smart!!! Thank you very much for releasing this add-on for the community!
     
  4. Xon

    Xon Well-Known Member

    @Sidane any reason for using template hooks? They are largely considered deprecated, and typically offer poorer performance.

    I'll have a pull request from github with some improvements soon.

    :edit:
    I'm immediately working on changes for:
    1. Making thread marks respect a post's visible status, and handling when posts are hard deleted that the old thread mark is cleaned up.
    2. Converting the global options into per-group permissions.
     
    Last edited: Jan 8, 2015
  5. AndreaMarucci

    AndreaMarucci Well-Known Member

    Wow very interesting! Just a question. I'd like to install it on my forum so that admin and moderator can manage TM but users can only see and use them. Is that the way it's meant to be? I've seen a permission option just to manage TM but not to see them by the users and I don't want users can set TM.
     
  6. tajhay

    tajhay Well-Known Member

    Yes its all permission driven. Works great!
     
  7. Xon

    Xon Well-Known Member

    I'm currently adding the ability allow users to set thread marks on their own threads in my development copy.

    I've already started requesting that @Sidane accept my changes on GitHub. At worse I can fork this addon, and re-upload with minimum changes due to the licencing of this addon.
     
    Digital Doctor likes this.
  8. AndreaMarucci

    AndreaMarucci Well-Known Member

    Could be interesting this feature...
     
  9. erich37

    erich37 Well-Known Member

    great (y)
     
  10. Sidane

    Sidane Active Member

    Cheers @Xon, will review that pull request this evening.

    Wasn't aware template hooks were deprecated, good to know :)
     
    Xon likes this.
  11. Xon

    Xon Well-Known Member

    Great!

    The next feature I want to add is to move all the configuration bits into per-group permissions. And to allow thread-starters to mark *any* post in the thread with a threadmark (also gated by permissions).

    Looking through your commit log, I can see why you used them.

    My recommendation is to use template modifications to inject an template include statement like so:
    Code:
    $0
    <xen:include template="mytemplate" />
    
     
    Last edited: Jan 8, 2015
    Digital Doctor likes this.
  12. Sidane

    Sidane Active Member

    Yeah I've used that approach in other add-ons. Definitely a tidier way of doing it.
     
    Xon likes this.
  13. Sidane

    Sidane Active Member

    Sounds good.
     
    Xon likes this.
  14. Floyd R Turbo

    Floyd R Turbo Well-Known Member

    Nice looking addon! Watching this one
     
  15. Ville

    Ville Member

    This works well! One suggestion: could the "Threadmarks" drop-down menu be visible even when there is just one page? Otherwise set threadmarks can't be managed until there is at least one full page + 1 messages.
     
  16. Sidane

    Sidane Active Member

    Yes, this is a known issue that will be fixed in an upcoming version.
     
    Ville likes this.
  17. resonansER

    resonansER Well-Known Member

    @Sidane, if your add-on enabled - five queries on page! Are you kidding?! Please, fix it. Now threadmarks is mysql killer.
     
  18. Xon

    Xon Well-Known Member

    This is on the list of things to improve.
     
    resonansER likes this.
  19. Sidane

    Sidane Active Member

    Damn, sorry about that - is my face red! :(

    Will get that sorted and a new version released asap.
     
    Xon and resonansER like this.
  20. resonansER

    resonansER Well-Known Member

    And thank you so much for this addon! Very clever idea. Just keep maintain and develop his. Very usefull, indeed.
     

Share This Page