Cory Booth
Well-known member
Error
Please enter a valid callback method.
When attempting to upgrade to 1.1
Please enter a valid callback method.
When attempting to upgrade to 1.1
Resource icon
Thread Watchers 1.2
- Thread starter Chris D
- Start date
Shelley
Well-known member
Oh I see it's like that then? you sneakily tried to make an update without me noticing? That will not do at all chris, where do I complain?
Seriously, nice work. Going to install this right now.
Edit: Installed and upgraded to 1.1 without any issues whatsoever. Excellent work yet again chris.
Shelley
Well-known member
Ensure you upload the threadwatchers folder to the library folder.You may have accidentally upload library folder into the library folder.
Basically, what Shelley said. Everything seems to be working fine.
Try again and if it still fails, completely uninstall and reinstall the add-on.
I have a suggestion. People with disabled javascript will get a seperate page instead of the thread watchers overlay. The link structure of those pages is always "threads/threadTitle.23/watchers". So they can easily get to pages with threads not watched by anyone. On those pages it would be suitable to output a "This thread currently isn't watched by anyone" message instead of nothing.
Veer
Well-known member
Thank you very much Chris for implementing Text only mode, Loved it
Just noticed that Guest visitors (and bots) can also see the link "Watchers", I think guests should not be able to see this information.
You're absolutely right, I will make that change.
I disagree. I see no problem with guests viewing the list of people watching the thread. After all, there's nothing to stop guests from viewing the list of people who have liked each post. I don't see any harm caused by a guest seeing how many watchers or who they are.Thank you very much Chris for implementing Text only mode, Loved it
Just noticed that Guest visitors (and bots) can also see the link "Watchers", I think guests should not be able to see this information.
However, I should have prevented bots from indexing that link - and I didn't. So I will implement that too.
Cory Booth
Well-known member
Worked - oddly, when re-copying the library files to be overwritten were the 1.0 ones.
Must have clicked "Skip" or something.
Appoligizes.
Shelley
Well-known member
Hey chris,
I'm just wondering if you would consider moving the watchers container above the "search this thread, thread tools etc" text? I just think any containers should be above it and it looks kind of odd when you have closed topics container as well. My suggestion would be to move it above the text?
I'm just wondering if you would consider moving the watchers container above the "search this thread, thread tools etc" text? I just think any containers should be above it and it looks kind of odd when you have closed topics container as well. My suggestion would be to move it above the text?
V
vVv
Guest
Nice plugin Chris, might come in handy on my forums. And yeah, like Shelley said above there, would be nicer if it's above that, or maybe some how "merge"/"append" it in with the current thread status, if thread status isn't used, the watchers would be used?
If thread status = not used, else; thread watcher ; >
"Thread Status: Not open for further replies. Watchers: This thread is being watched by 2 users." If "thread status" isn't triggered, the "Watchers" would be used by default? To help save on space/keep it together..
And yeah, like Shelley said above there, would be nicer if it's above that, or maybe some how "merge"/"append" it in with the current thread status, if thread status isn't used, the watchers would be used?If thread status = not used, else; thread watcher ; >
"Thread Status: Not open for further replies. Watchers: This thread is being watched by 2 users." If "thread status" isn't triggered, the "Watchers" would be used by default? To help save on space/keep it together..
V
vVv
Guest
aight, fair enough.
i'm just one to keep things in one place lol. 
i used to tweak my wordpress themes like that haha. figured, if things could / can be "compiled", then why not
I would definitely do it if there was an elegant way of doing it. It's always best to use template hooks where possible and the closed status isn't within one so it's awkward to add code within it.
Better? The problems I was having with that hook previously were due to the text link... that's done differently now so this change was easy.
Hey chris,
I'm just wondering if you would consider moving the watchers container above the "search this thread, thread tools etc" text? I just think any containers should be above it and it looks kind of odd when you have closed topics container as well. My suggestion would be to move it above the text?
Better? The problems I was having with that hook previously were due to the text link... that's done differently now so this change was easy.
V
vVv
Guest
I would definitely do it if there was an elegant way of doing it. It's always best to use template hooks where possible and the closed status isn't within one so it's awkward to add code within it.
Better? The problems I was having with that hook previously were due to the text link... that's done differently now so this change was easy.
hell yes, now release update lmao. I haven't installed this yet, so.. my as well do installation of it when/if that version released..
xD
Shelley
Well-known member
I would definitely do it if there was an elegant way of doing it. It's always best to use template hooks where possible and the closed status isn't within one so it's awkward to add code within it.
Better? The problems I was having with that hook previously were due to the text link... that's done differently now so this change was easy.
Looks good to me Chris
V
vVv
Guest
What's the opinion on the lock icon and the glasses icon being on opposite ends?
Does it look odd? It's bothering me
just make it so it floats: right lol. i know what you mean though, it would bug me as well haha. i like things uniformed and simple/sexy lol
Shelley
Well-known member
What's the opinion on the lock icon and the glasses icon being on opposite ends?
Does it look odd? It's bothering me
I think floating it to the right for consistency sake would be a good move. anyone wanting to have it to the left will/can easily make the css edit.
