1. This site uses cookies. By continuing to use this site, you are agreeing to our use of cookies. Learn More.

XF 1.4 Server error when upgrading from 1.4.1 to 1.4.2

Discussion in 'Installation, Upgrade, and Import Support' started by Stuart Wright, Oct 14, 2014.

  1. Stuart Wright

    Stuart Wright Well-Known Member

     
  2. Stuart Wright

    Stuart Wright Well-Known Member

    Keep getting it. AVForums is down until this can be fixed.
    HELP!
     
  3. Brogan

    Brogan XenForo Moderator Staff Member

    We have seen one other instance of this and it was related to one or possibly two add-ons - User Essentials and Paygates.

    Try disabling those in the ACP.
     
    maszd and MattW like this.
  4. Stuart Wright

    Stuart Wright Well-Known Member

    Have user essentials. Deactivated but made no difference.
    Trying again after deactivating each addon...
     
  5. Brogan

    Brogan XenForo Moderator Staff Member

    Did you try running the rebuild again after deactivating it?
     
  6. Stuart Wright

    Stuart Wright Well-Known Member

    Refreshing the halted window didn't do anything, but after disabling about half the addons, I hit the 'Begin Upgrade' link instead and that completed. Chris is on the site now, helping. Many thanks for the quick replies.
     
  7. Chris D

    Chris D XenForo Developer Staff Member

    It's sorted now. Yeah the error was still happening during the rebuild after User Essentials was disabled. I decided to just disable everything. So, sadly, we won't know exactly which one caused it.

    But I do have a list of add-ons for cross referencing should anyone else experience the same thing.
     
    rainmotorsports likes this.
  8. Mike

    Mike XenForo Developer Staff Member

    Just to clarify, you do need to restart the rebuild process to workaround this. By the time the error is triggered, the bad data has been written.

    It's something I will look into working around if possible, but the main workaround would slow down template importing so I'm not totally sure of the feasibility. The issue is that while template importing, we don't do a test compile when updating a template as would normally happen when editing a template; we assume that what has been provided is valid. Here, the template modifications made something that was syntactically valid (lexed/parsed) but violated some of second-pass compilation limits. The only way I could see working around this is to do the full test compile when importing but I'm unsure of the potential speed overhead; a mitigation could be to only do it when there are template modifications being applied.

    I should note that this isn't a new behavior -- it's worked identically since the template modification system was introduced in 1.2. This may have been the first time where it came up.

    It seemed to be User Essentials when I resolved it earlier, but it may have actually been an interaction between User Essentials and Paygates. (I believe there's a regex bug in Paygates' modification.)
     
    Walter and Stuart Wright like this.
  9. Stuart Wright

    Stuart Wright Well-Known Member

    We don't have the Paygates modification. Plenty of others, though.
     
  10. Daniel Hood

    Daniel Hood Well-Known Member

    I've just released an update to User Essentials that removes the troubled template modification. I meant to remove this template modification before hand, it was actually never used and shouldn't have been included. I apologize for the inconvenience.
     
    Walter, Russ and Chris D like this.
  11. Daniel Hood

    Daniel Hood Well-Known Member

    What if you make it a Deferred task for each template mod; it could work like this: disable all template mods, create a deferred task for each one, reenable them as they're verified individually. Granted it may put a board online without all their template mods intact for a moment but it beats the alternatives*, in theory at least.

    Alternatives being:
    • This error possibly happening again.
    • Slowing down the upgrade process, keeping boards offline longer.
    [Edit]

    Also I just remembered. Templates that aren't compiled correctly have a red 1 next to them instead of a green 1. Why not just skip those entirely, treat them as they're disabled or something? Keep in mind I'm tossing these ideas without looking at the code of the current process.
     
  12. electrogypsy

    electrogypsy Active Member

    i'm having the same issue, and i can't get the upgrade to finish. how do i restart the rebuild process? i added the "$config['enableListeners'] = false;" to my config to disable all my plugins, but i'm still getting the error.

    is there a way to get into the ACP? i can't think of any other way to upgrade the user essentials plugin since i'm stuck in the upgrade process.
     
  13. Mike

    Mike XenForo Developer Staff Member

    You can get into the control panel by putting this in your config.php file:
    Code:
    $config['checkVersion'] = false;
     
  14. electrogypsy

    electrogypsy Active Member

    awesome, thank you :)

    i was able to get into the ACP with that, then upgrade the xml for user essentials, then complete the upgrade process, and now everything looks good.
     
    Chris D and Daniel Hood like this.
  15. Alfa1

    Alfa1 Well-Known Member

    I can get in the admin panel, but it looks all messed up. Upgrading user essentials to version 211 does not work, because it leads to the same error.
     
  16. Chris D

    Chris D XenForo Developer Staff Member

    Run this DB query and try again:

    Code:
    UPDATE xf_addon SET active = 0
     
  17. Alfa1

    Alfa1 Well-Known Member

    Still the same error when I start the rebuild process.
     
  18. Chris D

    Chris D XenForo Developer Staff Member

    You're the first...

    Code:
    TRUNCATE xf_deferred
    That will clear out any outstanding rebuilds.
     
  19. Alfa1

    Alfa1 Well-Known Member

    Now the board seems upgraded. But I wonder if everything works as it should. Do I need to do anything next like rebuild everything?
     
  20. Chris D

    Chris D XenForo Developer Staff Member

    I would do the following:
    • While all add-ons are still disabled reinstall the latest User Essentials
    • Rebuild Master Data (go back to the install page)
    • Re-enable all add-ons
     
    Daniel Hood likes this.

Share This Page