1. This site uses cookies. By continuing to use this site, you are agreeing to our use of cookies. Learn More.

Fixed RSS Feed not showing images

Discussion in 'Resolved Bug Reports' started by DaveM, Dec 27, 2014.

  1. DaveM

    DaveM Well-Known Member

    I have the following RSS feed http://feeds.feedburner.com/shorpy?q=rss.xml however on my one forum it does not show the images.

    Not showing images on this forum here - http://goodolddaysforum.com/forums/hostgator.178/
    Showing images on this forum here - http://www.triumphtalk.com/forums/hostgator.388/

    The big difference here seems to be my hosting and I did report it to the host about it not showing the images and they had this to say.

     
  2. Chris D

    Chris D XenForo Developer Staff Member

    It seems to me like on one forum you have the Image Proxy in use and in another you don't. That is probably what the difference is. What this does mean is the image URLs become relative to your forum URL which is obviously not going to work if viewing externally, e.g. via an RSS feed.

    This actually may need a change in behaviour on our end. We'll look into it.
     
  3. DaveM

    DaveM Well-Known Member

    Thanks you are correct about the image proxy as I had to turn it off on the shared hosting as it does not work at all with any hot linked images
     
  4. Snog

    Snog Well-Known Member

    A simple test using straight HTML shows the site had some sort of hotlink protection.

    Code:
    <html>
    <head>
    </head>
    <body>
    <img src="http://www.shorpy.com/files/images/SHORPY-4a12313a.preview.jpg">
    </body>
    </html>
    
    The image will show occasionally, but if you refresh the page, it doesn't.
     
  5. Chris D

    Chris D XenForo Developer Staff Member

    Although that may be true, relative URLs pointing at proxy.php aren't going to work anyway so we will be addressing that.
     
    Snog likes this.
  6. Snog

    Snog Well-Known Member

    OK. I was just pointing out that the hot linked image (not using proxy system) is being protected somehow.

    I agree it should work with the proxy system though.
     
  7. Chris D

    Chris D XenForo Developer Staff Member

    We're actually disabling the proxying of links and images in our RSS feeds as of XF 1.4.4.

    Although this won't break existing code, it is recommended to do the same if you have an add-0n that outputs images or links in RSS feeds; basic code example:

    PHP:
    $bbCodeParserXenForo_BbCode_Parser::create(XenForo_BbCode_Formatter_Base::create('Base', array('view' => $this)));
    $contenttrim($bbCodeParser->render($snippet));
    Would become:

    PHP:
    $bbCodeParserXenForo_BbCode_Parser::create(XenForo_BbCode_Formatter_Base::create('Base', array('view' => $this)));
    $rendererStates = array(
        
    'disableProxying' => true
    );
    $contenttrim($bbCodeParser->render($snippet$rendererStates));
     
    Brogan and Mike like this.

Share This Page