Responsive Social Sharing Buttons

Responsive Social Sharing Buttons 1.5.7

No permission to download
Overview FAQ Updates (16) Reviews (21) History Discussion
SimonV said:
I cant replicate it. Look like the js is not working from what I can see.

Try creating a new default unedited style, does it work then?
Click to expand...
Same problem unfortunately, I have noticed that when clicking on new posts your addon throws up a js error.
upload_2015-5-30_2-42-25.webp
 
That can safely be ignored.

You must have another addon that's conflicting as I cant replicate the issue with my addon and [bd] Widget Framework V2.5.9.
 
@SimonV,

is there something wrong with this add-on and Facebook SDK?

If I try to include the following plugin in the threads in one of the ad_ templates;

https://developers.facebook.com/docs/plugins/page-plugin

It does not work.

When I disable your add-on, it does work.

I think your plugin has a conflict with Facebook SDK.

EDIT:

Facebook's sdk.js isn't loaded when your add-on is enabled. This goes for all front page view, thread view and page node view I believe (if those views are enabled).

When I disable your add-on, sdk.js is loaded.

I can reproduce this on your site I think (I couldn't see sdk.js being loaded).
 
Last edited:
Lile said:
@SimonV,

is there something wrong with this add-on and Facebook SDK?

If I try to include the following plugin in the threads in one of the ad_ templates;

https://developers.facebook.com/docs/plugins/page-plugin

It does not work.

When I disable your add-on, it does work.

I think your plugin has a conflict with Facebook SDK.

EDIT:

Facebook's sdk.js isn't loaded when your add-on is enabled. This goes for all front page view, thread view and page node view I believe (if those views are enabled).

When I disable your add-on, sdk.js is loaded.

I can reproduce this on your site I think (I couldn't see sdk.js being loaded).
Click to expand...


I cant replicate this, can you PM me more details, also are you using the most up to date version 1.5.5?

In my testing Im adding the FB js to "page_container_js_body" and then just adding the fb plugin code to "ad_above_content"
 
SimonV said:
I cant replicate this, can you PM me more details, also are you using the most up to date version 1.5.5?

In my testing Im adding the FB js to "page_container_js_body" and then just adding the fb plugin code to "ad_above_content"
Click to expand...
The below is from your add-on's template modification, which will allow you to see the original core XF template (page_container_js_body) which has the Facebook SDK init thing:
1.webp


The below is from XF Facebook Options:
2.webp





As you can see, there should be no need to add the Facebook javascript code manually if you have the above Facebook App ID and Application Secret set up in the XF core options.

page_container_js_body loads the FB sdk.js automatically in XF core if the above is set up (as you can see from the first image, it inits the sdk.js if the app id and secret are correctly set in the options).


HOWEVER

With your add-on enabled and if you have your buttons enabled say on front page and thread view, the sdk.js IS NOT loaded automatically. Your add-on stops that.

You can try enabling only thread view responsive share buttons and disabling front page/page node responsive share buttons, and the sdk.js IS then loaded on the front page but not on thread view/page node.

So try removing any custom/manual Facebook javascript plugin code, enable the app id and app secret properly in XF options, and you should be able to reproduce the problem; sdk.js IS loaded when your add-on is disabled, but IT IS NOT loaded when your add-on is enabled (except for in responsive share button views that are disabled, e.g. if you have front page view disabled and thread view enabled from your add-on's settings, then front page Facebook sdk.js is loaded but not thread view).

Can you reproduce now? I sure hope so or then it's something on my end...

Thank you!

PS. Yes I tested with your add-on version of 1.5.5.
 
Now I see what you are doing I can reproduce what you are describing.

Adding a FB appID and secret has nothing to do with the facebook sdk.js being included. The facebook sdk.js will be loaded in locations that have the default facebook share buttons enabled.

When you turn on the responsive buttons in locations that remove the default facebook share buttons of course the sdk.js from facebook is removed. Its removing the sdk.js from the page as its not being used just as it should else it adds unnecessary bloat to the page. So it IS loaded when the default sharebuttons are enabled on a page but IT IS NOT loaded when they are removed.

Now, you could add this code to the template "SV_rrssbShares", but that will only force sdk.js to be loaded in pages that would normally have the facebook share buttons, if you need it in other locations where the default facebook share buttons are not shown you will need to load the fb js manually.

Code: 
<xen:container var="$facebookSdk">1</xen:container>
 
Last edited:
Support for secure social share buttons so as not to conflict with the German (or european) data protection regulations.

Shariff does that, with one simple click:
Wenn the site loads, users can see the social share buttons but no spy data is send to facebook, google and co. Data will send later, after clicking on a social share button.
 
SimonV said:
dynamically loading of the Pintrest js when the button is pressed would be the way forward.
Click to expand...
That would be awesome, for not being able to select a content image to pin kinda defeats the pinterest button :)
 
Last edited:
otto said:
Support for secure social share buttons so as not to conflict with the German (or european) data protection regulations.

Shariff does that, with one simple click:
Wenn the site loads, users can see the social share buttons but no spy data is send to facebook, google and co. Data will send later, after clicking on a social share button.
Click to expand...

As I said, this add-on doesn't load any code from social media sites and uses the same sharing methods as Shariff.
 
maxicep said:
How can i float to right this social share area ? I set it to 60% max-width but sharing block floating to left always.

Thanks @SimonV
Click to expand...

This will override the responsive width settings so if you want to make the responsive width different to 60% it will require more CSS.

Set the max-width back to 100% and then add this CSS to your EXTRA.css
Code: 
.share-container ul.rrssb-buttons {
   float: right;
   width: 60%;
}
 
SimonV updated Responsive Social Sharing Buttons with a new update entry:

Responsive Social Sharing Buttons 1.5.5

v1.5.6 update contains the following:
  • Added dynamic loading of Pinterest pinmarklet.js for Pinterest button
  • Removed forum name from share titles/text
  • Fixed PopupCenter issue on certain buttons
  • Updates to CSS for naming convention
  • Button option reordering
To Update:

Re-upload all the files from the upload folder and then upgrade the addon with the new xml file from the xml folder.
Click to expand...

Read the rest of this update entry...
 
Newt said:
That would be awesome, for not being able to select a content image to pin kinda defeats the pinterest button :)
Click to expand...

Added this to the latest version, let me know if it works OK as I dont really use Pinterest and so only tested basic function.
 
Pinterest button doesn't seem to be working, clicking it just scrolls to the bottom of the forum.
 
TJA said:
Pinterest button doesn't seem to be working, clicking it just scrolls to the bottom of the forum.
Click to expand...

ahh, your site is running from https, I think the Pinterest script is being classed as mixed content and maybe being blocked by the browser. It jumping to the bottom will be related to your custom template, I will change to #navigation in the next release which I think is what the default template uses.

See if this works, in the file <FORUMROOT>/js/rrssb/rrssb.min.js search for this line:
Code: 
http://assets.pinterest.com/js/pinmarklet.js
and change to:
Code: 
https://assets.pinterest.com/js/pinmarklet.js
 
  • Like
Reactions: TJA
is it possible to make two rows of buttons on the sidebar instead of one? i got so many icons they're starting to get tiny.
 
You must log in or register to reply here.

Similar threads

Osman
[XTR] Unlimited Social Sharing Buttons [Paid]
Replies
15
Views
1K
HybridBoy
HybridBoy
Varma
Lightweight, Responsive, SVG Social sharing Buttons
2
Replies
22
Views
9K
WoodiE
WoodiE
CTXMedia
  • Question Question
How do I find out if people are using the social media sharing buttons on threads?
Replies
7
Views
616
Chris D
Chris D
Top Bottom