Report Improvements by Xon 2.21.3

[II ExecBod]

Many thanks for the most excellent plugins. I use several of your plugins.

This is not a bug report as I updated xenForo in a massive bungle. I had my live and devel sites up in two tabs and did the update on the live site when I thought I was updating the devel site. So, my bad.

Here are two issues that cropped up. I did hacky fixes to just get things to work. Thought this info might assist you.

FATAL
Forgot to log the error message: getModeratorsWhoCanHandleReport functions to not match...

  src/addons/SV/ReportImprovements/XF/Repository/Report.php line 480
  public function getModeratorsWhoCanHandleReport(\XF\Entity\Report $report) <-- does not match src/XF/Repository/ReportRepository.php line 75

THE TEMP "FIX"
  public function getModeratorsWhoCanHandleReport(\XF\Entity\Report $report, $notifiableOnly = false)

WARNING
Call to undefined method XF\Service\Report\NotifierService::notify()

  src/addons/SV/ReportImprovements/XF/Service/Report/Notifier.php:57
  parent::notify(); <-- does not exist
  
THE TEMP "FIX"
  //parent::notify(); -- just remarked out

 

[Xon]

Sadly that isn't quite enough, but it should at least reduce the errors.

I'm really hopeful to track down the last few bugs so I can release this week

 

[Ivancas]

@Xon I'm getting the following errors after upgrading to XF 2.3.2:

[30-Aug-2024 01:19:35 UTC] PHP Fatal error:  Declaration of SV\ReportImprovements\XF\Repository\Report::getModeratorsWhoCanHandleReport(XF\Entity\Report $report) must be compatible with XF\Repository\ReportRepository::getModeratorsWhoCanHandleReport(XF\Entity\Report $report, $notifiableOnly = false) in /home/xxx/public_html/forum/src/addons/SV/ReportImprovements/XF/Repository/Report.php on line 480

[30-Aug-2024 01:17:37 UTC] PHP Fatal error:  Declaration of XF\Http\Stream::write(string $string): int must be compatible with Psr\Http\Message\StreamInterface::write($string) in /home/xxx/public_html/forum/src/XF/Http/Stream.php on line 33

 

[II ExecBod]

Temporary fix:

Open this file:

  src/addons/SV/ReportImprovements/XF/Repository/Report.php

Goto line 480 and add ", $notifiableOnly = false" to the function parameters.

  public function getModeratorsWhoCanHandleReport(\XF\Entity\Report $report, $notifiableOnly = false)

 

[DevPunk]

2.3 Status?

 

[Recep Baltaş]

2.3 Status?

I haven't been feeling well the last day. But I'm hopeful I can still get the update for this add-on out by the end of the week

 

[Semper Fidelis]

I appreciate these updates and Xon's work. I'm patiently waiting for report improvements, warning improvements, and Elasticsearch Essentials, and then I'll pull the trigger to migrate my board.

 

[Xon]

Xon updated Report Improvements by Xon with a new update entry:

2.19.5 - XenForo 2.3 support

• Require StandardLib v1.21.0+
• Restore XF2.1 support
• XF2.3 support
• php 8.4+ compatibility fixes
• Fix "Resolve report" would display on the "manage reply bans" page even if the user couldn't resolve any reports

Read the rest of this update entry...

 

[MentaL]

double yay

 

[unproperlypropagated]

This add-on introduces potentially breaking changes to moderation permissions. Please review usergroup permissions carefully!

What changes does it introduce? What should we look for?
Kinda ambiguous ominous warning.

Also, I couldn't see the option to edit or delete comments on reports.
I only saw a link that discloses my own IP added under the comment, I pretty much don't want that!

 

[Xon]

I've updated the product description, a bit as the permission list was out of date and the warning about report permission changes needed to indicate what to look for.

It should assign permissions to the default admin/moderator groups, but it might not capture weirder permissions setups. so you need to review the "report center" permissions this add-on adds.

Also, I couldn't see the option to edit or delete comments on reports.

There is an "Edit any report comment" or "Edit own report comment" permission. This add-on doesn't allow deleting report comments however.

I only saw a link that discloses my own IP added under the comment, I pretty much don't want that!

This requires the "View IPs" permission, like the other ip logging features for XF.

 

[unproperlypropagated]

Awesome thanks!!!

 

[Xon]

Xon updated Report Improvements by Xon with a new update entry:

2.19.6 - Bugfix update

• Fix possible XF2.3 error on report notifications

Read the rest of this update entry...

 

[Kirby]

Macro svReportImprov_report_macros::reportInfo_conversation_message uses phrases

conversation_starter
conversation_participants

which don't exist in XF 2.3

 

[Xon]

Xon updated Report Improvements by Xon with a new update entry:

2.20.0 - Feature update

• Display warnings/warning actions (Warning Improvements)/member notes (@Z61's Member Notes addon) for the reported user when viewing a report
• Add "svSearchImprov_search_container.report" phrase for better phrasing support on Advanced search page

Read the rest of this update entry...

 

[Xon]

The warning list is going to need to have a limit added because problem users with large numbers of warnings really make a report unreadable on a mobile device

 

[Cyberkef]

The warning list is going to need to have a limit added because problem users with large numbers of warnings really make a report unreadable on a mobile device

Ah nice, my moderators LOVE the function but hate the scrolling too Thx in advance!

 

[Xon]

Xon updated Report Improvements by Xon with a new update entry:

2.20.1 - Bugfix update

• Fix incorrect phrase usage for direct messages with XF2.3
• When viewing a report, show a 'user info tab' by default instead of a list of warnings to avoid page jank & excessive scrolling

Read the rest of this update entry...

 

[Brettflan]

With this addon installed and enabled, moderators of specific forums only are able to see all Reports. With the addon disabled again, it goes back to them only seeing Reports for posts in the forums they moderate. Is this intentional? Is there a way to disable that? I don't want section moderators seeing every report, just the relevant ones for the forums they moderate.
I do see in the options for this mod the option "Reports respect view-node permission", but that's not quite the same; the moderators can see the other forums (they're visible), but personally I don't want that to equate to them being able to see all of those reports if they don't moderate those forums.
I also couldn't find any relevant permissions from the addon that would have this effect.

In case it's relevant, I do also use your Moderator Essentials addon and Andrew's Moderator Panel addon.

 

[Xon]

Just grant the "view post report" permission via a user-group to all moderators which will let them see all post reports. Using the content moderator option only grants this permission per-forum.