Fixed Link proxy doesn't work with unfurling

[Jake B.]

Affected version

2.1.x

If a link has been unfurled it doesn't get sent through the link proxy regardless of settings

 

[Chris D]

I'm fairly sure it does:

XenForo Themes and Add-ons – ThemeHouse

We offer premium quality XenForo themes and add-ons for XF1 and XF2. We also offer XenForo hosting and custom design work.

www.themehouse.com

Do you have a more specific example of a URL which doesn't work, and can you reproduce that here?

 

[Chris D]

Which instantly proves me wrong.

We attempt to use the link proxy but it does look like there could be a bug in how we're building the URL, so that may be more specifically what you're referring to.

We'll look into it, thanks.

 

[Jake B.]

Perhaps I'm missing something, but that link doesn't appear to be getting proxied?



Edit never mind, got ninjaed by your response. Thanks!

 

[Chris D]

If there's a data-proxy-href attribute (which there seems to be for me) then it is using the proxy. We switch the link targets at click time.

But it just so happens (our posts crossed) that we do appear to be building the proxy-href link incorrectly (it looks like it could be double encoded).

 

[XF Bug Bot]

Thank you for reporting this issue, it has now been resolved. We are aiming to include any changes that have been made in a future XF release (2.1.8).

Change log:

When rendering an unfurl do not double escape the proxied version of the URL.

There may be a delay before changes are rolled out to the XenForo Community.