Fixed Link proxy doesn't work with unfurling

Affected version
2.1.x

Chris D

XenForo developer
Staff member
I'm fairly sure it does:

Do you have a more specific example of a URL which doesn't work, and can you reproduce that here?
 

Chris D

XenForo developer
Staff member
Which instantly proves me wrong.

We attempt to use the link proxy but it does look like there could be a bug in how we're building the URL, so that may be more specifically what you're referring to.

We'll look into it, thanks.
 

Jake B.

Well-known member
Perhaps I'm missing something, but that link doesn't appear to be getting proxied?

Screen Shot 2020-03-05 at 10.23.45 AM.png

Edit never mind, got ninjaed by your response. Thanks!
 

Chris D

XenForo developer
Staff member
If there's a data-proxy-href attribute (which there seems to be for me) then it is using the proxy. We switch the link targets at click time.

But it just so happens (our posts crossed) that we do appear to be building the proxy-href link incorrectly (it looks like it could be double encoded).

1583425554879.png
 

XF Bug Bot

XenForo bug fixer bot
Staff member
Thank you for reporting this issue, it has now been resolved. We are aiming to include any changes that have been made in a future XF release (2.1.8).

Change log:
When rendering an unfurl do not double escape the proxied version of the URL.
There may be a delay before changes are rolled out to the XenForo Community.
 
Top